Repository navigation
[PR] fix: refresh skipped-proxy evidence in repeated alerts - #7370
ranxianglei merged 1 commit into
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复. Searched open+closed issues/PRs (GitHub + mirror) for the same "stale skipped-proxy evidence" symptom. The only open PR addressing #7369 is this one (#7370). Related closed work is distinct, not parallel: #2860 (introduced the structured 标签: added Local verification (independent of CI):
8问 (structured review):
行为变更披露(旧 → 新): 旧——无 skipped 的重复失败保留早先 测试有效性: 4 条新行为断言(3 个路由切换走生产 diff 整洁度 / 代码整洁: 3 文件、83 增 0 删,无跑题改动、无空行/重排噪音;命名达意、无死代码、无魔法数、无新依赖、风格与仓库一致。外部提交质量达标,无需对齐重构。 判定: 可合(mergeable),待 CI 全绿确认。 修复正确、最小、打在根因层,回归覆盖有真实断言支撑;路由/重试/熔断零改动。 |
Problem
An active upstream alert could keep its old skipped-proxy endpoint after later requests started using that proxy or deliberately bypassed it. Its English hint was refreshed, but the localized web banner continued reading the obsolete structured fields and giving incorrect recovery advice.
Changes
Replace the optional skipped-proxy fields with the latest failure's evidence, including clearing them when absent. The alert's instance, count, timestamps and failure code stay intact. A later skipped proxy still replaces the previous endpoint/source with the existing credential redaction.
This is one alert-state correction shared by the JSON overview and the localized banner. Routing, retry and circuit policies are unchanged.
Verification
1e357bf2d6632bfbd2a74ffb70ecee1af1ec7cc3(currentmaster, 0.1.216).npm run typecheck,npm run build,npm run check:unused-exports,npm run check:test-import-graphandgit diff --check: passed.ba9f0bff05ff781150fc40964fadb970b0e5a781matches the locally validated tree.Related #2860 and #5574. The former introduced the structured evidence, while the latter expires inactive rows; this corrects the evidence of an alert that is still actively failing.
Fixes #7369