Repository navigation
[PR] fix: clarify preflight fail-fast NOT-forwarded message is per-request (#7344) - #7368
ranxianglei wants to merge 1 commit into
Conversation
…#7344)⚠️ MODEL-FACING TEXT CHANGE: the preflight fail-fast error message now says "This request's over-window payload was NOT forwarded to the upstream." instead of "The over-window payload was NOT forwarded." The old wording ("The over-window payload") reads as a global statement, which is misleading when a concurrent request (different session, or a client retry) forwards its own over-window payload via a forward-once arm (probeForEvidence #2313 / imageArbitration #496/#1800 / post-fold #3146/#4185). The new wording makes it clear that the NOT-forwarded guarantee is scoped to THIS specific request, not to all in-flight traffic on the session or the proxy. The upstream 400 log (relay.ts ← upstream) already carries the session id, so operators can now correlate the two lines and see they are different requests rather than a contradiction. Closes #7344
f504b13 to
15917ad
Compare
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复 — 本 PR 是 #7344 措辞问题的唯一修复,无并列 PR/issue 动同一处。 Reviewed PR #7368 (closes #7344). Clean 2-line change: What I verified
One finding (filed, non-blocking) CI: still in progress — all 26 checks queued as of the last mirror-cache read (07:23 UTC). I'll confirm green once the 结构化八问
判定: 代码层面可合——方向对、diff 干净(2 行)、测试钉死、无回归。待 CI |
What
The preflight fail-fast log line and client-facing error message ended with "The over-window payload was NOT forwarded." The definite article "The" reads as a global statement — as if no over-window payload on the proxy was forwarded. In practice the guarantee is per-request: this specific request's payload was withheld, while a concurrent request (different session, or a client retry on the same session after the lock releases) can still forward its own over-window payload via a forward-once arm (probeForEvidence #2313, imageArbitration #496/#1800, post-fold #3146/#4185).
Why
Issue #7344: an operator saw
preflight fail-fast 502 ... NOT forwardedand← upstream 400: requested 1667733 tokensin the same millisecond and read them as contradictory. The 400 was from a different (larger) request, not the fail-fasted one. The old wording sent the operator down the wrong debugging path (checking window/threshold config that was actually correct).Fix
Change the final clause from "The over-window payload was NOT forwarded." to "This request's over-window payload was NOT forwarded to the upstream." — making the scope (this request) and the destination (the upstream) explicit. The
← upstreamlog in relay.ts already carries the session id, so operators can now correlate the two lines and see they are different requests.Regression test
tests/issue1993-preflight-400.test.ts:205pinned the old exact string; updated to the new string. All other "NOT forwarded" assertions use substring/regex matches that still pass.Closes #7344