Repository navigation
[PR] fix(codex-lane): context-only prewarm probe relay + hosted web_search_call ordering (#4594, #7296) - #7322
ranxianglei wants to merge 2 commits into
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.11114-pr.7322.1376053This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr7322.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) Picked up — reviewing PR #7322 (root-cause aggregation fix for the codex-lane batch #7314: #4594 + #7296 in one PR). Duplicate check: not a duplicate. This is the single consolidated fix PR for the codex-lane aggregation #7314. The earlier PRs #4595 and #7302 are labeled Labels: the source PR already carries Review in progress: diff read, cherry-pick provenance, regression paths, CI lanes, then the structured verdict. |
(ai: vllm-qwen/qwen3.8-27b) Review verdict: mergeable — CI green on head What I independently verified (not a re-read of the issue body):
Behavior changes — all four disclosed in the PR body, all verified as intended (probe recognition widened; probe egress direct → proxy; context-only prewarm no longer in Drive-by filed: #7327 — the host's hosted-call type set duplicates the kernel's Post-merge note (for you): #4595 and #7302 are marked 八问(中文结构化结论)
收工判定:可合并。 CI 在 |
) responsesToCore flattens hosted calls (web_search_call, file_search_call, mcp_call, ...) into contentType:"reasoning" cores. The Responses ordering repair classified them as a second reasoning item and inserted a user separator between the real reasoning and the hosted call, splitting the assistant run — the server then rejects the web_search_call "without its required 'reasoning' item". Classify a flattened hosted-call core (whose rawResponsesItem sidecar carries a hosted-call wire type) as tool-call (phase 2) so the reasoning -> hosted call run stays intact. The separator still lands between distinct runs. Closes #7296 (cherry picked from commit 2a2a9e9)
…tream proxy (#4594) A generate:false request that replays no conversation turn (empty input, or only developer/system/user messages) is a prewarm probe: forward it verbatim instead of running it as a zero-message ACP turn, which deactivated every fold block and re-injected the whole forged-summary list. History prewarms keep riding the pipeline. The probe relay now egresses through the same upstream proxy the relay resolves; ws-bridge exposes the resolved proxy instead of a boolean so the tunnel guard and the probe share one decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit cdda1b3)
6da9871 to
e7b3a51
Compare
(ai: vllm-qwen/qwen3.8-27b) Merge conflict resolved — PR rebased onto current master and pushed. What I did this run:
Post-push live state (mirror cache, fetched this run): CI in progress on Scope check: the diff vs master is identical in scope to the reviewed PR — same 9 files, +219/−27, no new lines introduced by the rebase. Both cherry-pick commits keep their original authors (z0d0dOr, ci-check) and 七问(中文结构化结论)
收工判定:冲突已解、最终 head |
Root-cause fix for the codex-lane batch (aggregation #7314): the two previously separate Codex Responses-wire defects, fixed in one PR per the root-cause aggregation contract.
#4594 — context-only prewarm ran as an ACP turn; probe relay bypassed the upstream proxy
src/responses-ws.tsonly treatedgenerate:falsewith an emptyinputas a prewarm probe. Codex's startup/idle-thread warmup sendsgenerate:falseplus its developer/user context items, so it fell through into the ACP pipeline as a zero-message turn: it deactivated every fold block (0 active blocks saved), re-injected the wholecodexForgedSummarieslist, and inflated the request with ACP tools. The probe relay also egressed on the bare transport, bypassing the upstream proxy that pipeline turns use.Fix: a
generate:falserequest that replays no conversation turn (empty input, or only developer/system/user messages) is now a probe — forwarded verbatim through the relay's upstream proxy, never run as a turn. History prewarms keep riding the pipeline.ws-bridgenow exposes the resolved proxy (egressProxyFor) instead of a boolean so the tunnel guard and the probe share one decision.Cherry-picked from #4595 (author z0d0dOr) with
-x, rebased onto current master.#7296 — ordering repair split a reasoning item from its hosted web_search_call
responsesToCorerepresents hosted call items ascontentType: "reasoning";repairResponsesAssistantOrderingmistook the hosted call for a second reasoning and inserted a synthetic user separator between the real reasoning and the call, so the Responses server rejected theweb_search_call("provided without its required 'reasoning' item").Fix: a reasoning-content core whose
rawResponsesItemsidecar carries a hosted-call wire type is classified as a tool-call (phase 2), keepingreasoning → hosted callin the same run. Separators still land only between distinct runs.Cherry-picked from #7302 (author ci-check) with
-x.Rebase note (#4594 commit)
src/inline-ws.tsandsrc/inline-engine.tspostdate #4595's base and calledinstallWebSocketBridgewith the oldisEgressProxied?: (url) => booleansignature. The rebase adapts them to the newegressProxyFor?: (url) => string | undefinedsignature (plus one fixture intests/ws-bridge-pending-close.test.ts). No behavior change beyond what #4595 intended — the inline WS bridge's prewarm probes now egress through the upstream proxy too.Behavior changes (intended, old → new)
generate:false+ empty input →generate:false+ no conversation turn (empty, or only developer/system/user messages).stats.requests(parity with empty-input probes, which were never counted).reasoning → hosted web_search_callno longer split by a synthetic user separator (distinct runs still separated).Verification
codex-responses-ws(38 tests),issue564-responses-ordering,ws-bridge-pending-close,issue2627-turn-sep-coverage,issue5139-turn-separator-ranges,invariant-judge,fold-round2-shape,responses-ws-http-fallback,ws-bridge(79 more). Full-suite verdict = CItestlanes on this head.superseded(their commits live here via cherry-pick-x, authorship preserved).Fixes #4594
Fixes #7296