Repository navigation
[PR] fix(web): select freshest disk session summaries - #7290
ranxianglei merged 1 commit into
Conversation
(ai: vllm-qwen/qwen3.8-27b) Review of #7290 (fixes #7289) — independent of the PR's own validation claims. 查重 (dedup): Not a duplicate. Searched open PRs — only this PR addresses the stale-twin selection in the file-backed dashboard summary path. (#5005 also matches the "7289" token but is an unrelated session-meter fix.) 标签 (labels): applied What I verified myself:
Direction (①): The root cause is real. Regression (②):
Quality (②a / ⑤b): High. Minimal diff (+6/-1 source, +51/-1 test); the comment explains WHY (walk order would pick a stale twin); no dead code, no new deps, no magic numbers; naming clear; the test has real assertions covering both tie-break directions plus list/overview/page/warm-cache/live-precedence. No alignment refactor needed. Diff cleanliness (⑤): 2 files, every line on-topic, no whitespace or lock-file churn. One honest, non-blocking note (④): the test's ability to catch the original bug leans on the directory walk visiting CI at review time: in progress — 13 checks green, 11 skipped (gated e2e lanes), 9 still queued (gates + 结构化八问
判定:可合(mergeable once CI green)。 方向对、根因修、无回归、diff 干净、测试是真回归测试。等 CI 的 hermetic test 分片跑绿即可合;合并权在 owner。 |
|
(ai: OpenAI/GPT-6 Astra Pro) CI follow-up, updated after the maintainer's targeted rerun: #7290's original core CI is now green on the unchanged head The rerun resolves that red CI leg. The previously requested
For #7285, the review's suggested merge order remains owner PR #7282 first, then update this contribution against that cache shape. #7279 already has its successful full matrix and does not need another request. |
(ai: vllm-qwen/qwen3.8-27b) I verified the CI state live before responding. #7290's red leg — confirmed, and unrelated to the diff. The original run's one failure is On triggering For #7290 specifically:
Leaving the re-run / |
(ai: vllm-qwen/qwen3.8-27b) Live state re-verified, then the red leg was handled. No code change needed — the failure is a timing flake in a test this PR does not touch, and a targeted rerun is now in flight. Live state at wake: the mirror showed 0 failed / 0 pending on head The red leg (job log verified):
Why this is a flake, not a regression (evidence):
Action taken: triggered If the rerun goes red again: two consecutive reds on the same 5s-window assertion would point at a genuinely too-tight window, and the right move is a test-robustness fix on master/ci-fixes (widen the observation window) — that I would route as a 🔶 需要决策 rather than silently changing a master-owned test inside this external PR. Note (not a CI failure): the PR is 17 commits behind master; that is a merge-time concern for the author/owner, not a check failure. 七问
|
(ai: vllm-qwen/qwen3.8-27b) Rerun confirmed green — the PR is now clean. |
[ework] CI fix verified green ✓ |
Fixes #7289.
Problem and change
When multiple disk files represent one session, the web index already selects a winner by newest
savedAt, then modification time. The summary merge ignored that index and let the last file visited overwrite earlier summaries. A stale twin could therefore replace the title, request count and token totals shown by the session list, search and overview.Read each selected file through the existing
byIdindex. Live sessions retain precedence, and the authoritative unified-index path is unchanged. No new cache, configuration, dependency or storage format is introduced.Validation
Old historyinstead ofCurrent history. They cover newer saved data with an older filesystem timestamp, plus the modification-time tie-break when saved timestamps are equal.npm run typecheck, the completenpm run build(kernel, Pi extension, main bundle and distribution checks), andgit diff --checkpass.Validation uses Linux and Node.js 24.22.3 against master
04ecbb42dd38543e9c407bd40eb773ae5ec8b60b. The fixtures use private temporary directories and the real session serialization/indexing paths. This is a dashboard data-selection correction; no latency benchmark or change to the model-facing request path is claimed.