Repository navigation
[PR] fix: route compress to stale persona fork that holds the cited refs (#7075) - #7202
ranxianglei wants to merge 1 commit into
Conversation
…7075) Pre-#6883 traffic minted refs in a |sub: fork (persona-order ladder). Post-#6883 compress forwards stamp the raw id and the purpose header routes them to the parent. The fork went stale (no model traffic for >10 min) so livePersonaDescendant's freshness filter excludes it, but its ref space still holds the refs the compress cites. Fix: stalePersonaWithRefs — no freshness gate, refs are the discriminator. When livePersonaDescendant returns undefined (fork not fresh), fall through to stalePersonaWithRefs which finds the fork whose minted ref space contains the cited refs. Closes #7075
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.10855-pr.7202.9d2bad1This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr7202.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) Verdict: mergeable — fixes a real, session-breaking bug; one narrow regression to track (filed as #7210). What I verified (evidence, not "should work"):
The fix is correct for the reported shape. One regression to decide on (narrow, filed as #7210). The fallback drops the BIRTH-ORDER gate that keeps an active raw parent authoritative. In the parallel-persona shape (active parent P + parallel Recommendation: merge — the #7075 bug is common (every #6883 upgrade path) and session-breaking, while the regression is narrow and low-probability. Track the residual risk in #7210 for a content-based discriminator. Final call is yours. 八问(结构化结论)
判定:建议合并(修复真实且常见的会话卡死,净收益;窄回归已立 #7210 跟踪)。是否合并由 owner 拍板。 |
Problem
Pre-#6883 traffic minted refs in a
|sub:fork (persona-order ladder). Post-#6883 compress forwards stamp the raw id and the purpose header routes them to the parent. The fork went stale (no model traffic for >10 min) solivePersonaDescendant's freshness filter excludes it, but its ref space still holds the refs the compress cites.Result:
every ref is unknown to this session— the compress is routed to the parent (which doesn't hold the refs) instead of the fork (which does).Fix
stalePersonaWithRefs— no freshness gate, refs are the discriminator. WhenlivePersonaDescendantreturns undefined (fork not fresh), fall through tostalePersonaWithRefswhich finds the fork whose minted ref space contains the cited refs.This recovers already-broken sessions: the next compress call will be routed to the fork that holds the refs, and the compress will succeed.
Tests
5 unit tests for
stalePersonaWithRefs:Closes #7075