Repository navigation
Conversation
Merge upstream master 6a641f3, including the architecture module-map and schedule-independent ranxianglei#2929 probe fixes. Preserve the existing PR head and exact contribution patch. Validation of this refreshed head runs in upstream CI; no local test rerun is claimed.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The egress runner hands a plugin the live outbound Buffer. A plugin can mutate it before throwing, returning an invalid result, or timing out. The fail-open path then returns the same reference with damaged bytes. A timed-out plugin can also corrupt a body after the runner has already returned it. This affects binary passthrough and Buffers produced by an earlier plugin.
Change
Give each matching plugin a private Buffer draft. Only a successful, valid returned
bodyreplaces the accepted body, matching the existing result contract. Strings retain their existing value semantics; empty, disabled and unmatched pipelines retain their no-op behavior. Successful header changes still commit independently of body replacement.The isolation costs one linear Buffer copy per matching plugin that receives a Buffer. String-based JSON requests do not take that copy path.
Verification
301e1a5459a77d5578206927c8062a58381af642.npm run typecheck,npm run build, andgit diff --check: passed.127.0.0.1:8199is unreachable; real four-phase host acceptance remains unrun.Duplicate checks covered all states and Afloat16's history. #6608 explicitly isolated only headers and left Buffer/body handling unchanged; it does not prevent the byte corruption reproduced here. #6606 handles case-insensitive header replacement. The new change is limited to body ownership in the shared egress runner.
Fixes #7043