Repository navigation
Conversation
Merge upstream master 6a641f3, including the architecture module-map and schedule-independent ranxianglei#2929 probe fixes. Preserve the existing PR head and exact contribution patch. Validation of this refreshed head runs in upstream CI; no local test rerun is claimed.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
consumeRoundstops at a Responses terminal event and releases the reader lock without cancelling the remaining HTTP body. An upstream that keeps that body open retains its connection even though the guard has finished the round. A continuation can then wait for a pool slot still occupied by its own previous round; the cleared idle timer no longer releases it.Change
Cancel a round body whenever consumption exits before EOF, then release the reader lock. Cancellation is observed without awaiting it, so a tee's other consumer or a rejecting cancellation cannot hold up the terminal response. Completed EOF, folding decisions, output events and usage accounting retain their existing behavior.
Verification
301e1a5459a77d5578206927c8062a58381af642.response.completed.npm run typecheck,npm run build, andgit diff --check: passed.127.0.0.1:8199is unreachable; real four-phase host acceptance remains unrun.All-state and author-history searches found no equivalent round-body release. #1113 handles raw passthrough/backpressure cleanup; this fixes the separate parsed reasoning-round consumer introduced in #740. The shared guard is unchanged in both compression modes apart from transport cleanup.
Fixes #7039