Repository navigation
Conversation
Merge upstream master 6a641f3, including the architecture module-map and schedule-independent ranxianglei#2929 probe fixes. Preserve the existing PR head and exact contribution patch. Validation of this refreshed head runs in upstream CI; no local test rerun is claimed.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
An expired legacy or namespaced session envelope may have another fresh envelope for the same session ID. Both copies reference the same restored-image export directory. Session GC currently co-deletes that directory when it removes the first expired copy, even while the fresh copy survives, leaving image references unavailable.
Change
Check for surviving session twins through the existing indexed filename-suffix lookup before co-deleting shared image exports. The last removed twin releases the directory once. A surviving unreadable envelope is handled conservatively, and an unrelated session does not retain another session's images. The independent stale-mtime export cleanup remains unchanged.
This changes disk retention shared by the proxy and plugin store; it does not alter request rendering, compression, identity generation, or configuration.
Verification
301e1a5459a77d5578206927c8062a58381af642.tests/preload-storage-baseline.mjsandtests/preload-test-env.mjs.npm run typecheck,npm run build, andgit diff --check: passed.This is separate from #2022's image cache, #4724's directory naming and #6611's suffix-index performance change. Live searches and author history found no equivalent co-deletion fix.
Fixes #7029