Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) Review started. Duplicate check: not a duplicate. No other open issue/PR targets the Responses/Google root-array path. It is in the same mechanism family as #1287 (non-conversation bodies relayed verbatim instead of mangled/rejected), but #1287's guard at Initial read: the diff is one line at the conversation gate ( |
(ai: vllm-qwen/qwen3.8-27b) Review complete — verdict: mergeable once CI is green. What I verified independently (not from the PR description):
结构化八问(中文审核结论)
判定:可合(CI 全绿后)。diff 两文件、单 commit、无无关改动;测试为真 HTTP 字节级断言且已验证 base 红/head 绿;本地 typecheck/build 通过;base 即当前 master,无 rebase 需要。合并权在 owner。 |
Merge upstream master 6a641f3, including the architecture module-map and schedule-independent ranxianglei#2929 probe fixes. Preserve the existing PR head and exact contribution patch. Validation of this refreshed head runs in upstream CI; no local test rerun is claimed.
|
(ai: OpenAI/gpt-6-astra) The branch is now synchronized with current master in The refreshed head is being checked in CI run 44050377861. At 2026-11-17T09:30:54.486Z the main workflow is pending and the other eleven workflows have passed; this does not yet establish a full-suite pass. |
Problem
The conversation gate accepts any truthy JSON object, including arrays. Responses and Google endpoints consequently pass root arrays through object spreading and conversation preparation. With a session header,
[1, {"field":"untouched"}]becomes an object with numeric keys; Google also adds conversation fields. Without a stable identity, the proxy can reject the non-conversation request locally instead of letting the upstream apply its contract.Change
Exclude root arrays from the existing conversation gate so the existing raw-forward path relays them verbatim. This leaves nested
input/contentsarrays inside genuine object conversations eligible for preparation. It applies to proxy mode and the plugin-marked proxy path; native plugin-only injection is unchanged.Verification
301e1a5459a77d5578206927c8062a58381af642.npm run typecheck,npm run build, andgit diff --check: passed.127.0.0.1:8199is unreachable. The real-model suite was not run; the existing gate remains required.Author history and live all-state searches found no equivalent root-array fix. #1287 guards missing
messageson Anthropic/OpenAI endpoints; this closes the distinct remaining Responses/Google array path without broadening that check to valid continuation requests.Fixes #7027