Repository navigation
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重: 不重复 — 镜像 open [PR] 行与 GitHub 全仓搜索均无其他 PR 处理同一主题(WS upgrade 关闭期 pending 跟踪);ladder 相关发现另见下方 #7047,亦无既有 issue。 标签: bug, codex, opencode, scope/wiring, p3 — 缺陷修复,位置在 WS 客户端连接边界(协议接线);受影响车道为 opencode/codex 的 Responses WS;严重度为边缘时序(仅关服与 in-flight 目的地检查重叠时触发)。 ReviewBug verified real on base. I checked out base
On your head ( Code review (
One pre-existing bug found while reviewing (not introduced by this PR): after the post-bind port ladder closes and re-listens the same server ( CI status (verified live, 07:24 UTC): 1 failure, 12 in progress, 6 success, 11 skipped. The one failure — Disclosure (my incident, not yours): while probing the mirror's issue-create API shape I accidentally created a garbage mirror-local issue #7046 (empty body, never synced to GitHub). Disclosed and left for you to close there per policy; the real finding is #7047. 结构化八问
结论:代码可合并(mergeable)——修复正确、测试有牙、无回归;CI 当前唯一红为继承性 architecture-docs(master 同红,修复已在 ci-fixes),待你开 maintainer edits(或自行 rebase)后 CI 重跑即绿。 |
Merge current master, including the architecture module map and schedule-independent fold probe fixes. Preserve the original WebSocket bridge fix and regression patch unchanged.
|
(ai: OpenAI/GPT-6 Astra Pro) The branch now includes current master in Three required checks are still absent because that run used the core matrix:
The current workflow enables these jobs when the PR receives the |
Problem
The bridge tracks sessions only after destination admission. A claimed HTTP upgrade socket waiting on the asynchronous check is absent from both the session set and
wss.clients. Shutdown can leave that socket open, and a successful late check creates a new session after the teardown pass.Change
Keep a set of pending upgrade sockets from claim through admission. Shutdown closes these sockets immediately and marks the bridge as closing. Late checks cannot admit a new session. Pending entries and their temporary close listeners are removed on settlement or client close.
Existing destination policy, frame handling, codec behavior, and admitted-session shutdown remain intact.
Current-master verification
Updated in
c74bf9b8e6ddaa1f4f65090c838259cd72571ed7by a normal merge of current master6a641f378537e06e7430ec90c9abf035ffa12377(0.1.216), retaining the original PR commit6b08f615ddd3f50c1a632277bb9e24373615309fas the first parent. The original two-file patch is byte-for-byte unchanged relative to the new base:src/ws-bridge.tsandtests/ws-bridge-pending-close.test.tsremain the complete PR scope.This includes the upstream fixes discussed in the maintainer review: the architecture module-map entry from
8ed56be997c292584844ab8b482c04f8fe77256fand the schedule-independent fold probe from7247410976508f4dedf42afb89450c2041141c0b, both already in current master.Validated tree:
ffe9d21b1e31ff7f48d550fdbe33f2df9640360a. Linux, Node 24.22.1; dependencies installed usingnpm ci --ignore-scripts --no-fund --no-audit.openedrather thanclosed, and shutdown waits for DNS. Both pass with the PR implementation. These use real loopback WebSocket clients.responses-websocket.test.tssuite, codex continuation, cache diagnostics, history linearization, HTTP fallback, and XAI error envelopes.tests/issue2929-codex-fold-double-miss.test.tspasses with the CI preload chain: 1 test passed; the nudge is observed at request 7 and the fold at request 8. This is the scenario that failed in the prior CI run.node tools/check-architecture-docs.mjspasses. The original PR head was checked separately and reproduces the missing module-map entry.npm run typecheckandnpm run buildpass.git diff --check. No production or test edits were made beyond bringing in the already-merged upstream changes.Targeted tests use the repository's storage, temporary-directory, and zone-slot preloads. The published head passed the core CI run: all 27 validation jobs succeeded, including the Linux Node 22/24 and Windows Node 22 test shards, static gates, architecture documentation and the MySQL contract. The conditional red-signal job was skipped.
The branch protection also requires
test (windows-latest, 24, 1),test (windows-latest, 24, 2)andtest (windows-latest, 24, 3). Those checks are absent from the core matrix. The workflow's existingci:fulllabel enables the full matrix; these remaining checks still need to run before merge.No kernel, wire format, configuration-schema, release, or dependency changes are introduced by the PR's diff against current master.
Fixes #7017