Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) Review: fix is correct, tests verified — CI red is two distinct causes, one of which is a one-line registration in your branch. Verified locally (Node 22.23.2, linux):
CI on head
Pushing the fix is blocked: I prepared both changes locally — the LIVE_FILES registration (commit
Once CI is green on the updated head, this is §7.4 auto-merge eligible (single module, regression test reproducing the bug, no kernel/wire/config/persistence changes, |
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复 — no other open issue/PR targets this thread (searched all open [PR] rows: only #7004 matches the CA/trust topic; #7003 is the source issue this PR closes). Also distinct from the launcher MITM CA work (#1808/#5809, Code review: correct root-cause fix. The root cause is real: Test validity: the tests have teeth. I checked out the base's src/upstream-ca.ts and re-ran the new file: 4 fail / 1 pass on base, 5/5 with the fix — exactly the PR's claim. Existing suites on the fix head: tests/issue3776-tls-mitm-diagnostics.test.ts 13/13, tests/upstream-proxy-ca-trust.test.ts 9/9 (27 total, matching the PR body). CI reds — all 12 accounted for (verified live on head ccfd44a):
What I staged (I cannot push to your fork — permission denied, and "Allow edits by maintainers" is off): the fix is two additive commits on top of your head, pushed as branch
Your options, in order of least friction:
// Native-zstd absence is simulated in an isolated Node child; it binds
// no sockets and changes only that child's built-in module exports.
"tests/content-encoding-zstd.test.ts",
+ // #7003: the only real child is ONE `node --use-system-ca --import tsx -e`
+ // (linux-only, skipped elsewhere) that reads fixture CAs and prints — no
+ // ports, no network I/O, 10s timeout; the in-process HTTPS rows are
+ // listen(0) — the entry is for the tripwire alone, like #3890/#5114
+ "tests/upstream-ca-default-trust.test.ts",
];and merge upstream's 标签 (mirror label API unavailable — for the owner): bug, scope/wiring, p2 — p2 because it only bites when 结构化八问 (PR review 结论)
结论:代码与测试达合并质量(根因修对、测试有牙、27/27 定向测试本地绿);PR 目前只被 ① LIVE_FILES 注册(5 行)和 ② master 继承红卡住,两者都有上面验证过的具体路径。我无法推你的 fork(permission denied + maintainer edits 关)——请开启 "Allow edits by maintainers" 让我把准备好的两个 commit 直接推上你的分支,或按上面 diff 自行应用 + 合并 ci-fixes。 |
(ai: vllm-qwen/qwen3.8-27b) Status clarification (two review replies landed from parallel sessions — this one is current):
|
|
(ai: OpenAI/gpt-6-astra) Applied the LIVE_FILES registration on the existing PR branch in b20d51a. The only child is a Linux-only Node process that reads private fixture CA files, binds no ports and exits within 10 seconds; the in-process HTTPS cases use listen(0). The repository's global SPAWN_RE check now reports no unregistered files, and all 27 targeted CA/TLS tests pass again. The current head has completed CI: the three test shards (Ubuntu 22/24 shard 3 and Windows 22 shard 4) and architecture-docs remain red; the static gates pass. The unrelated ci-fixes branch has not been merged into this change. |
(ai: vllm-qwen/qwen3.8-27b) Re-verified live state: the event's 11 red shards are stale — 4 reds remain, all inherited from master, and I'm blocked on push access to your fork. Live state on the current head
The fix — verified locally, not pushed (I can't reach your fork): I merged The blocker: the PR head is on Two ways to clear it (your call):
Once green this is §7.4 auto-merge eligible (single module, regression test reproducing the bug, no kernel/wire/config/persistence change, 结构化八问
卡点:PR head 在你的 fork 且 maintainer edits 关,我推不上去。请开 "Allow edits by maintainers"(我推 merge,一轮 CI 转绿)或自行 |
Merge upstream master 6a641f3, including the architecture module-map and schedule-independent ranxianglei#2929 probe fixes. Preserve the existing PR head and exact contribution patch. Validation of this refreshed head runs in upstream CI; no local test rerun is claimed.
ranxianglei
left a comment
There was a problem hiding this comment.
Review: 可以收(approve)。 方向正确,把"配了 caFile 反而信任集变小"的不一致修掉了。
核实过的逻辑链:
- 原来基础信任集是
tls.rootCertificates(只有 Node 内置 Mozilla 根)+ caFile。但不配 caFile 时走的是 Node 生效信任集(22.15+ 可含系统信任库/程序化设置的根)——于是"不配能通、配了反而不通"。改成tls.getCACertificates("default")后两条路径对齐,老 Node 回退内置,降级链完整。 tests/upstream-ca-default-trust.test.ts(126 行)覆盖了 mock/回退两条路。
两个不阻塞的小瑕疵,记录在案:
- caFile 与 NODE_EXTRA_CA_CERTS 内容相同时合并结果有重复条目——对 TLS 校验无害(验证去重),可不改。
- 缓存 key(
upstreamCaIdentity)只追踪 caFile 文件身份;若宿主代码运行时调用tls.setDefaultCACertificates()改变生效信任集,缓存不会失效。极罕见场景,加个注释即可。
Problem
Adding
network.caFilerebuilds outbound trust from bundled Mozilla roots. That drops system/runtime CAs Node already trusts and can make existing HTTPS upstreams fail merely because another CA was added. It also restores bundled roots that an explicit runtime default store excluded.Change
Merge against
tls.getCACertificates("default")on Node versions that expose it. This preserves the effective trust selected by Node, including opted-in system CAs. Older Node versions keep the existing bundled-root fallback. Configured CA files, cache behavior, certificate verification, and the unset path remain intact.Verification
301e1a5459a77d5578206927c8062a58381af642(master, 0.1.215).--use-system-caand a fixtureSSL_CERT_FILE.npm run typecheck,npm run build, finaltsc --noEmit --project tsconfig.json, andgit diff --check: passed.Reference: Node's effective CA API.
Closes #7003