Repository navigation
[PR] fix(storage): accurate unified-FULL boot log for the default case (顺带 #6994) - #7000
ranxianglei wants to merge 2 commits into
Conversation
) The boot log said 'unset the knob to roll back', but pure-SQLite full mode is the DEFAULT when neither BILI_STORAGE_UNIFIED nor storage.unified is set — there is no knob to unset. It also claimed 'legacy files keep being written', which is false for the pure-SQLite default (jsonWriter off). That misleading line is what sent #6994's reporter hunting for a knob they never set. Now it names the default explicitly and gives the correct rollback (set storage.unified=legacy or BILI_STORAGE_UNIFIED=legacy).
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.10591-pr.7000.924a5e2This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr7000.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) Re-verified the live check state first: Diagnosis — inherited master-red, not this PR's code. The failing line was Fix. Merged Live re-verification after push: the new CI run on No design decision needed — pure inherited-failure sync: no new issue, no PR-body edit, no authorization gate touched. 结构化八问
判定:继承红已清除, |
(ai: opencode/qwen3.8-27b) CI 自动修复 — test 分片红 → 绿(flake 重跑确认,无代码改动) 1. 是什么问题 2. 什么原因导致的 3. 影响范围与严重程度 4. 怎么修复的 5. 是否有回归问题 6. 是否破坏缓存 7. 是否改了设计方向 8. 是否引入了新的配置 备注(状态源差异):GitHub API 已确认 run conclusion=success(attempt 2,全绿),但镜像缓存此刻仍显示该分片 判定:收工。 PR CI 已绿,flake 重跑确认,无代码改动。 |
(ai: opencode/qwen3.8-27b) Duplicate wake — already resolved in the previous run. Live re-verification this run:
The flake was confirmed and re-run green in the prior run (see the 八问 above). No code change, no push, no further work. If this wake recurs, it's the mirror cache catching up — the authoritative GitHub state is green. |
顺带小修:unified-FULL 启动日志对默认档的措辞不准确(发现于 #6994)
#6994 的报告者「没设开关」却看到
unified FULL mode ENABLED,被启动日志里的 "unset the knob to roll back" 带偏去找一个根本不存在的 knob。问题:
src/storage/shadow.ts:378的启动日志:(storage.unified=full or BILI_STORAGE_UNIFIED=full),漏了「两者都未设时默认就是 full」这一档(0.1.214+ 的纯 SQLite 默认,[PR] storage: pure-SQLite default — JSON envelopes stop being written unless dual-write is requested (#6479) #6480);storage.unified=legacy或BILI_STORAGE_UNIFIED=legacy。修法:一行日志措辞,显式点出默认档 + 给正确的回滚开关。不动任何行为/逻辑,纯日志文本。
回归面:无 —— 只改一条 info 日志的字符串;
tests/issue4341-early-twin-adoption.test.ts与tests/issue4977-present-twin-persist-gate.test.ts只 match 前缀/\[storage\] unified FULL mode ENABLED/,前缀保留,不受影响。发现于 #6994 的 triage(#6994 主诉 A/B/C 的根因修复在 #5178 / #5691,不在本 PR)。