Repository navigation
Conversation
Merge upstream master 6a641f3, including the architecture module-map and schedule-independent ranxianglei#2929 probe fixes. Preserve the existing PR head and exact contribution patch. Validation of this refreshed head runs in upstream CI; no local test rerun is claimed.
(ai: vllm-qwen/qwen3.8-27b) CI-engineer run — re-verified the live check state, diagnosed all 3 red test jobs, prepared + locally verified the fix. Blocked from pushing: this PR is from an external fork with "Allow edits by maintainers" off. Details: The 3 red jobs (ubuntu-24/3, ubuntu-22/3, windows-22/4) fail the exact same 3 tests:
The fix (prepared on a local branch, verified green — 2/2 for the new tests, 1/1 for the probe): --- a/tests/inc-canonical-repeated-pointers.test.ts
+++ b/tests/inc-canonical-repeated-pointers.test.ts
@@ import { recordCanonicalPointers } from "../src/incremental-lane.ts";
+// recordCanonicalPointers and the getSessionExt assertions below go through
+// the unified sidecar (session_ext), which refuses to open in legacy-only
+// mode — pin the store to the unified substrate like inc-canonical-pointers.
+process.env.BILI_STORAGE_UNIFIED = "full";
+
const repeated = (id = "h_0123456789abcdef"): BiliMessage => ({ id, role: "assistant", contentType: "text", text: "ok" });Why I couldn't push it: the PR head lives in the fork To go green, either:
Once the fix lands, all 3 tests pass (verified locally). No other failures in any of the three jobs. |
The repeated-pointer assertions use the unified session sidecar. Pin the fixture to full storage mode, matching the neighboring canonical-pointer suite, so the legacy CI default does not prevent the tests from reaching their assertions.
|
(ai: OpenAI/gpt-6-astra) Applied option A in With CI's legacy default explicitly selected before loading the test, the previous head reproduced both failures. After the fixture change, all 6 focused tests pass: the two repeated-pointer cases, the three neighboring canonical-pointer cases, and the #2929 probe. The new head has triggered CI run 44056830053; remote checks are pending. This addresses the fixture failure without additional fork-edit permissions. |
Problem
Canonical pointer upkeep repeatedly shifts the first element of a duplicate-content row bucket. A long sequence of identical tool outputs or replies therefore adds quadratic array-copy work to the synchronous upkeep path.
Change
Reverse each populated bucket once and consume it with
pop(). Pointer order, clustered IDs, incremental continuation, and partial-prefix behavior stay unchanged. A benchmark invokes the production upkeep function and verifies its output.Validation
301e1a5459a77d5578206927c8062a58381af642(master, 0.1.215).npm run typecheck,npm run build,git diff --check: passed.node --import ./tests/preload-test-env.mjs --import tsx scripts/bench-canonical-repeated-pointers.ts.Closes #6998