Repository navigation
[PR] Gate: add two toggles — laneScript + snapshotRender (#6785 real verification on the body plane) | gate 补两个开关:laneScript + snapshotRender(#6785 正文平面真验证) - #6913
Merged
Conversation
# Conflicts: # tests/e2e/e2e-native-dsh-persona.test.ts # tests/e2e/e2e-native-dsh.test.ts # tests/e2e/e2e-native-opencode.test.ts # tests/e2e/e2e-native-pi.test.ts # tests/e2e/e2e-pi-codex-ws.test.ts # tests/e2e/e2e-subagent-sessions.test.ts # tests/notice-registry.test.ts # tests/plugin-fork.test.ts
On Windows, new URL(import.meta.url).pathname yields /D:/a/... (leading slash before the drive), so path.resolve prepends the current drive and the module-level readFileSync opens D:\D:\a\...\package.json and crashes the whole test file at import time. import.meta.dirname is the cross-platform form already used by every sibling e2e test.
# Conflicts: # tests/e2e/e2e-selfupdate-cli.test.ts
- storage-durability: drop the #4609 verdict cache (index.db.chk) after corrupting the db — the flip keeps size + mtime (4 ms granularity), so a cached 'ok' skipped quick_check and the corrupt open succeeded, failing the assert.throws / shadow-alarm expectations. - wire-exit-matrix: abortAfterFirstByte now waits for a ready predicate (up.requests() >= 1) before destroying the client socket — the 400 ms fallback used to fire before the proxy forwarded on slow runners, leaving requests=0 / closed=0. Applied to all four abort cells. - issue4612-gc-online-guard: wrap the 21,000 fixture inserts in one BEGIN/COMMIT — autocommit paid one fsync per row (WAL + synchronous=FULL), ~17 min on slow-fsync disks, past the runner timeout.
The snapBase storage substrate reaches the R lanes via the bundled restart-lanes.mjs, but the P lanes prefer the candidate checkout OWN plugin-lanes.mjs — which predates the GATE_SNAPBASE knob, so P ran off-state in candidate-branch verification. laneScript forces the bundled copy (the entrypoint already supports GATE_LANE_SCRIPT for exactly this). snapshotRender flips BILI_ROLLOUT_SNAPSHOT_RENDER (env tier > 0% rollout) so the egress BODY plane renders live — without it storage.snapBase only exercises the v2 substrate, not the body path the verification is actually after. Both keys documented in config.example.json.
…es lane proxies cleanEnv() strips BILI_* from the lane spawn env by design, so BILI_ROLLOUT_SNAPSHOT_RENDER set container-wide still resolved to off(bucket) in every lane (verified in the #6785 gate run: rollout line showed snapshotRender=off(bucket, 7206/10000 vs 0bp) with the env set). The knob now writes rollout.features.snapshotRender=true into the P/R lane bili.json — the config tier the rollout resolver honors above bucketing. GATE_SNAPSHOT_RENDER stays harness-internal; the proxy never sees it.
Contributor
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.10380-pr.6913.f11c2deThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr6913.tgz
npm install -g packageInstall instructions are refreshed on each push. |
buildCorpus() produces a 441-line file, but the t1 recipe said "~1300
lines". Most models ignored the mismatch; opencode/codex occasionally
flagged it ("the file is only 441 lines, but the task says ~1300") and
wasted the turn, red-ing S40/S07 t1 (2026-11-16 gate run 4). Quote the
actual count instead.
Owner
Author
[bot] 🏷 查重: 不重复 —— 镜像内检索 gate/laneScript/snapshotRender/正文平面 无同题条目;相关的 #6785(候选 gate 来源)与 #6889(snapBase 前作)范围不同,本 PR 是它们共同暴露的 gate 开关缺口。 PR #6913 审核完成,结论 APPROVE,无阻断项。全部技术声明已逐条对源码验证过,不是照抄 PR 描述。 审核要点(独立重读 diff + 源码)
结构化八问
判定:APPROVE,无阻断项。等 aa92494 的 CI 重跑转绿后,由人合并(agent 不 merge)。 |
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.1217-master.642000e # this exact build
npm install -g billion-context@master # always the newest merged build
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gate 补两个开关:正文平面真验证
背景
跑 #6785(msgid × 快照平面)候选 gate 时发现两处"开关没真正生效",正文(出站字节)平面实际没被验证:
scripts/gate/plugin-lanes.mjs,而候选分支早于 [PR] Gate switch: let P/R lanes run with candidate snapBase planes enabled (verify #6785) | gate 开关:让 P/R 车道开着候选 snapBase 平面跑(验证 #6785) #6889 的GATE_SNAPBASE旋钮 → P 车道的 bili.json 里没有storage.snapBase(实跑验证:候选分支 run 里 P 车道 0 个文件含 snapBase,R 车道因为固定用镜像脚本才是开态)。snapshotRender默认 0%(src/rollout.ts),storage.snapBase只开了存储底库;出站正文要走snapshotRender平面。不翻它,"看正文"看的是 client 原始字节。改动(2 文件,+14)
scripts/gate/bili-gate.sh新增两个可选配置键(都向后兼容,缺省 = 现状):laneScript:透传GATE_LANE_SCRIPT—— entrypoint 本来就支持这个逃生门(注释里明说用途:"fixes not yet merged into master"),现在配置能喂进去了。设/gate-tools/plugin-lanes.mjs即强制用带旋钮的 harness 脚本。snapshotRender:往 P/R 车道 bili.json 写rollout.features.snapshotRender: true(config 层,优先于 0% bucket)。注意:第一版走 env 层(BILI_ROLLOUT_SNAPSHOT_RENDER)是错的 ——cleanEnv()按设计剥掉车道 spawn env 里的BILI_*,真跑验证时 rollout 行仍是off(bucket);第二个 commit 改成 config 层。插件模式车道(dsh 包 / pi 原生)按设计 client-authoritative(正文本就不走平面),正文渲染真正跑在 codex / opencode / claude 前缀车道上。scripts/gate/config.example.json:两键 +_doc说明。验证
bash -n+ config JSON parse 通过--dry-run:配置含两键时 docker 命令带GATE_LANE_SCRIPT=...与BILI_ROLLOUT_SNAPSHOT_RENDER=1;缺省时两者均不出现