Repository navigation
[PR] fix+feat(launcher-lane): antigravity-desktop launcher + zcode absolute node path (root-cause batch #6895) - #6898
ranxianglei wants to merge 4 commits into
Conversation
…DE (#4675) The desktop app spawns the same closed Go language_server as the agy CLI and honors the identical CLOUD_CODE_URL env override, so this adds an antigravity-desktop alias launch client that reuses the exact same env lane as bili antigravity — only the launched binary differs. It probes the standard desktop install paths (Windows %LOCALAPPDATA%\Programs\antigravity and %PROGRAMFILES%\antigravity; macOS /Applications/Antigravity.app; Linux /usr/bin and ~/.local/share/antigravity) with a --bin/BILI_CLIENT_BIN override for custom locations. Docs: docs/clients.{md,zh-CN.md,ja.md} and README.{md,zh-CN.md} gain a desktop bullet, the manual-attach-to-bili-start recipe, and the single-instance caveat. (cherry picked from commit d210f2a)
CI (windows-latest, node 22) failed the new antigravity-desktop test: the production darwin branch builds its candidate with path.join, which yields backslashes on a win32 runner, while the test compared against a hardcoded forward-slash literal. Build the expectation with path.join (the same host-independent pattern as the #2260 test in this file) so the injected-platform assertion holds on every host. Production behavior is unchanged — the darwin branch only ever runs on darwin. (cherry picked from commit 516bcba)
`bili plugin install zcode` wrote a bare `node` as the spawn command for both the SessionStart hook and the stdio MCP server in ~/.zcode/cli/config.json. The ZCode binary executes that JSON command directly (no shell), so the token only resolves through the client process's own PATH — when node is not there the spawn dies silently, the MCP handshake collapses, and compression never activates while `bili doctor` still reports ok. The bare-`node` shape came from the #1902 rule, which exists for the SHELL-STRING hooks (claude/kimi) where a spaced command token breaks PowerShell/cmd parsing; it does not apply to a JSON args array. - applyZcodeManagedConfig takes nodeCommand; zcodeInstall passes process.execPath (the node bili itself runs under). - doctor probe: an absolute spawn command becomes an existence-checked target (node binary gone → broken); a bare token becomes an advisory warning (the lane still works when node IS on the client PATH) — verdict unchanged, surfaced via LanePresence.spawnWarnings → DoctorLane.warnings. - Reinstall self-heals pre-fix bare-`node` entries (ownership detection matches args, not command). - Docs (en/zh/ja) updated to describe the pinned absolute node path. (cherry picked from commit fe102ad)
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.10336-pr.6898.d808d19This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr6898.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Duplicate check: not a duplicate. GitHub #6898 is the single aggregation PR for the launcher-lane root-cause batch (#6895); it supersedes the two member PRs (#6761 antigravity-desktop, #6892 zcode). No parallel second fix PR targets this thread. The member PRs should be closed by the owner once #6898 lands (already requested in the PR body). The other matched rows (#6472 sess_ prefix, #4758 antigravity UA) are different symptoms/mechanisms — not duplicates. This is a root-cause-batch aggregation PR (GitHub #6898) carrying the two launcher-lane member fixes. It is already open and in CI. I pulled the branch and independently verified it — I did not re-do the work. Verification (evidence, on head
Behavior changes (already documented in the PR body; confirmed reasonable):
八问:
判定:CI 转绿后可合(当前运行中,0 failed)。成员 PR #6761/#6892 待 owner 在 #6898 落地后关闭。 |
|
@ranxianglei the fact that this hasnt merged yet as a P1 is crazy.. |
Verified live just now — the PR is ready to merge and isn't stuck on anything technical.
The reason it hasn't merged is simply that merging is a human-only action in this repo — the agent (me) is not permitted to merge PRs, so it's sitting waiting on @ranxianglei to click merge. Nothing on the CI or conflict side is holding it up. If you'd like it rebased onto current master before it lands (so the 87-commit gap closes), say the word and I'll do it and re-run CI — otherwise it's green and mergeable right now. |
|
rebase it i guess, and if you can do the same thing you did like this |
You don't need a rebase to use the fix — the artifact for the current PR head ( npm install -g billion-context@0.0.10336-pr.6898.d808d19That exact version carries both fixes (the The rebase itself I can only do on the owner's (@ranxianglei) explicit say-so — it rewrites the PR branch, so it's an owner-gated action, not something I take on a commenter's word. And it isn't required here: the |
|
that is old, i want the latest version with this fixes |
Understood — you want the build on current master (87 commits newer than the branch's base) with these two fixes on top, not the older-base artifact. I checked: the rebase onto current master is clean (no conflicts — I test-rebased it in a throwaway branch and all 4 commits applied). So technically it's a quick, safe rebase. But I still can't do it on a commenter's word, for two concrete reasons:
The clean path (needs the owner): @ranxianglei approves the rebase here, I rebase + push + re-run CI, and the CI comment posts the new Until then, |
Root-cause batch for launcher-lane (aggregation issue #6895): one PR carrying the two member fixes. Commits are cherry-picked (with
-xprovenance, authorship preserved) from the two member PRs, which are superseded by this PR:nodedies silently when node is off the client's PATH (#6891) #6892 (1 commit) — zcode absolute node pathFix 1:
bili antigravity-desktop— first-class launcher for the Antigravity Desktop IDE (feat, #4675)The desktop app spawns the same closed Go
language_serveras theagyCLI and honors the identicalCLOUD_CODE_URLenv override, soantigravity-desktopis an alias launch client (baseantigravity, same precedent aspi-test→pi): the env lane (buildAntigravityEnv), route discovery, web UI and i18n are all reused untouched — only the launched binary differs.%LOCALAPPDATA%\Programs\antigravity\Antigravity.exe→%PROGRAMFILES%\antigravity\Antigravity.exe; macOS/Applications/Antigravity.app/Contents/MacOS/Antigravity; Linux/usr/bin/antigravity→~/.local/share/antigravity/antigravity.--bin/BILI_CLIENT_BINstill wins for custom locations.--help): desktop bullet, manual-attach-to-bili startrecipe, single-instance caveat.Fix 2: zcode — pin the absolute node path in hook/MCP entries (fix, #6891)
bili plugin install zcodewrote barenodeas the spawn command for both managed entries in~/.zcode/cli/config.json. The ZCode binary executes that JSON command directly (no shell), so the token only resolves through the client process's own PATH — when node is not there the spawn dies silently, the MCP handshake collapses in ~100 ms, and compression never activates whilebili doctorstill reports ok. The bare-nodeshape came from the #1902 rule, which exists for the SHELL-STRING hooks (claude/kimi) where a spaced command token breaks PowerShell/cmd parsing; it does not apply to a JSON args array.applyZcodeManagedConfigtakesnodeCommand;zcodeInstallpassesprocess.execPath(the node bili itself runs under).broken); a bare token becomes an advisory warning (the lane still works when node IS on the client PATH) — verdict unchanged, surfaced viaLanePresence.spawnWarnings→DoctorLane.warnings.nodeentries (ownership detection matches args, not command).~/.zcode/cli/config.jsonmanaged entries:commandgoes from"node"to the absolute path of the node bili runs under — on new installs and reinstalls only; existing installs keep"node"until re-run, and doctor now tells them to.bili doctorzcode lane: pre-fix bare-nodeinstalls gain aok); a pinned node path missing from disk flips the lane tobroken(new — previously that case died silently with no signal at all).bili antigravity-desktop(purely additive; thebili antigravityCLI lane is byte-identical, pinned by a negative test).No model-facing text changes: no prompt surface touched — launcher help and doctor output are user-facing CLI text only.
Verification
testlanes on the pushed head.Fixes #4675
Fixes #6891
Supersedes (cherry-picked with
-x): PR #6761, PR #6892 — please close those once this lands.