Repository navigation
Conversation
…ei#6875) DSH read_image results carry {type:"image", attachment:{attachmentId, ...}} in tool results. Two gaps stacked: the codec reduced tool results to text so the part never reached a CoreMessage, and extractMediaRefs never enumerated the shape so the message pinned forever. This lands both halves together: the tool branch preserves attachment-carrying image parts (and re-emits them), the classifier reads attachmentId as a durable re-access handle, and the drop detector stops counting preserved parts as dropped. Already-BLOCKED history migrates via the existing ranxianglei#2607 mechanism on the next compress.
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 Searched open+closed issues/PRs for the DSH attachment / read_image / BLOCKED / recoverable-media signatures. The only related prior work is #3398/#3412 (merged 2026-10-18) — same root problem (DSH Review of PR #6879 — I checked out the PR head ( What I verified locally:
Code assessment: The fix is a root-cause fix (疏, not 堵) with two required halves, both correctly implemented:
The Two findings (minor, non-blocking):
Open question (does not block the review, but worth confirming): the PR's test header states the maintainer's triage that the tool branch dropped the part at parse time. If the part never reached the CoreMessage on the unpatched code, the classifier would never have seen it, and the message should have been foldable as plain text — yet the reporter observed BLOCKED. The exact historical pinning path is not fully resolved from the available evidence (the reporter's reconstructed log shows core messages with no sidecar). The fix is correct regardless (both halves are needed: retention without recognition would newly pin), but the "why was it BLOCKED" question is worth a one-line confirmation from the reporter. 八问:
判定:代码质量良好,两半修复逻辑正确,测试有效(含负向断言),verif 守卫全过。有一个需要确认的回归风险(上游是否接受重发的 attachment part)和一个理论性小缺陷(drop detector 过度抑制)。建议:① 等 CI 全绿;② 请 reporter 在真实 DSH 会话上确认 DeepSeek 接受重发的 part(或提供日志);③ 确认后可合入。kernel 变更属 human-only review tier,不 auto-merge。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) CI 全绿。 16 success / 14 skipped / 0 failed。11 个 test shard(ubuntu/windows × node 22/24)全过,static-gates ×2、mysql-contract、gate ×2 全过。14 个 skipped 全是 e2e lane(含 最终判定不变:代码质量良好,两半修复逻辑正确,测试有效,verif 守卫全过,CI 全绿。合入前唯一需要确认的事项:
kernel 变更属 human-only review tier,不 auto-merge。等 reporter 确认上游接受性后,可由 owner 合入。 |
Re-bump kernel 0.0.200 -> 0.0.201; both lockfiles synced.
What broke
DSH read_image and screenshot results carry their image as {type:"image", attachment:{attachmentId, ...}} in tool results. Two gaps stacked: openaiToCore's tool branch reduced every tool result to text, so the part never reached a CoreMessage; and extractMediaRefs never enumerated the attachment shape, so even a carried part classified as unrecoverable media. The messages pinned forever and their refs went BLOCKED, about 160K tokens stuck in the reporter's session.
What changed
kernel-change: DSH attachment refs are recoverable media (#6875)
How verified
compress.stripImages默认开启——否则带图消息不可压缩会形成只升不降的输入地板撑爆上下文 #2607 migration mints a fresh number. A directed test runs the full chain (parse a DSH tool result, then assignRefs over a stale BLOCKED binding).Scope note
Folding keeps the attachmentId handle in the summary's MEDIA REFS section, same as remote-URL media since #5620; the image bytes themselves no longer ride the request, same as remote-URL media. The reporter's second question is answered by the migration above: already-BLOCKED ranges unblock on the next compress after this lands.
Fixes #6875