Repository navigation
[PR] fix: recognize pi-web-access 0.46 shared proxy marker and keep inline traffic off real DNS - #6841
[PR] fix: recognize pi-web-access 0.46 shared proxy marker and keep inline traffic off real DNS#6841sx4im wants to merge 3 commits into
Conversation
… traffic off real DNS pi-web-access 0.46 only sets __piWebAccessProxyFetch when the wrapped fetch already has it, and marks its own wrapper with __piWebAccessSharedProxyFetch instead. The fetch chain only knew the old name, so the ranxianglei#2435 coexistence branch was unreachable and every install fell into the generic re-chain. The ranxianglei#1662 escape then handed the rewritten INLINE_ORIGIN request to the oldest live anchor, a real DNS lookup that dies ENOTFOUND, and only the first occurrence is logged, so every later model call failed silently. Recognize both markers in the depth-1 branch, the install guard, and the marker the chain forwards, and never route pseudo-origin traffic to the anchor: send it down the chain instead, where the hop stamp lets the inline transport serve it in-process.
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Reviewed the diff, traced the fetch-chain mechanics, and ran the targeted suites locally. What I verified
八问(结构化审核)
本地验证:定向套件 34/34 通过(含两条 #6829 回归测试),typecheck 干净。 CI 状态(实时):仍在跑——30 项中 0 失败 / 13 pending(test 分片排队/进行中,e2e 车道按门跳过,static-gates 进行中)。已绿:mysql-contract、architecture-docs、lock-sync、lifecycle-ledger-guard、test-import-graph。 判定:代码方向正确、修复到位、测试有牙、本地定向全绿。等 CI 全绿后给最终合入判定——CI 落地后我会补一条确认。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) CI 落地了,补最终判定。 CI 结果(实时):30 项全部完成。11 个 test 分片(ubuntu/windows × node 22/24)全绿;static-gates ubuntu 24 绿;mysql-contract / architecture-docs / lock-sync / lifecycle-ledger-guard / test-import-graph 全绿。唯一红: 红的根因(与本 PR 无关):失败的是 kernel 性能测试 处置:建议对 最终判定:代码方向正确、修复到位、测试有牙、本地定向 34/34 + typecheck 干净、test 分片全绿;唯一红是无关的 kernel 计时抖动。可合——代码无问题,等 re-run 转绿即可,或 owner 直接合(红的不是本 PR 的锅)。 |
(ai: vllm-qwen/qwen3.8-27b) CI fixed — What I did this run:
八问:
判定: PR #6841 CI 全绿(head |
[ework] CI fix verified green ✓ |
…s proxy scope on (ranxianglei#6829) With a pi-web-access proxy scope active, the wrapper sitting above the inline link curls INLINE_ORIGIN URLs itself, so the ranxianglei#1662 depth-1 fix never runs on that path and 0/2 inline-origin requests reach the engine (scope OFF: 2/2). A second leak exists for requests inheriting a stale dispatchDepth (ranxianglei#5614 shape), which skip dispatchBody entirely. Fix (routing-only, no default/budget change): - fetch-chain: exact-origin classifier isInlineOriginUrl (URL-parse; http only, exact hostname, default port, no credentials) and a classify-first check in patched — INLINE_ORIGIN requests run the link's own dispatch at a fresh depth 1 instead of being handed down the chain. The old depth-1 prefix route-down is removed. - pi-inline: the serve logic is extracted as exported serveInlineOrigin (undefined when not installed or not an inline-origin URL); the link dispatch delegates to it. - native-intercept: the dispatch's send is wrapped so every INLINE_ORIGIN send is served in-process via serveInlineOrigin; all other sends pass through untouched. Unconditional: bili cannot observe the wrapper's scope state from outside, so there is no signal to divert on. Tests: three new regression tests in tests/pi-inline.test.ts (proxy-scope ON/OFF, stale dispatchDepth, exact-origin classification) plus an updated ranxianglei#6829 expectation (the wrapper never sees pseudo-origin traffic now); 11/11 pi-inline, 29/29 self-heal + ranxianglei#5614 neighbours. Fixes ranxianglei#6829
pi-web-access 0.46 changed how it marks its proxy fetch: it only sets
__piWebAccessProxyFetchwhen the wrapped fetch already has it, and marks its own wrapper with__piWebAccessSharedProxyFetchinstead. The fetch chain only knew the old name, so the #2435 coexistence path was unreachable and every install fell into the generic re-chain. The #1662 escape then sent the rewritten inline-origin request to the oldest live anchor, which is a real DNS lookup for a host that has no DNS record, so model calls failed with ENOTFOUND. Only the first one is logged, so the rest failed silently.This recognizes both marker names in the depth-1 branch, the install guard, and the marker the chain forwards, and never routes pseudo-origin traffic to the anchor: it goes down the chain instead, where the hop stamp lets the inline transport serve it in-process.
Verified with two new regression tests: the pi-inline composition test with a 0.46-style wrapper (model and management requests served in-process, wrapper hook still runs) and the self-heal diagnostics test (shared-marker install adopted as coexistence). Targeted suites pass 34/34 and typecheck is clean. Full-suite verdict is remote CI on this head.
Fixes #6829