Repository navigation
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 Searched open+closed issues/PRs for the same diagnostics-truncation / lone-surrogate / Labels intended (the label API is not implemented in this mirror shim, so I'm recording them here): I'm now reviewing the diff and verifying the fix against live master. Initial read: the 5 |
[bot] 🏷 PR Review: fix: preserve Unicode boundaries in diagnostics reportsDedup: Not a duplicate. Searched open + closed issues/PRs for the same failure signature (diagnostics truncation + surrogate pair + Labels (recorded here; mirror shim has no label endpoint): Verdict: Mergeable (with one finding below)The 5-site fix is correct, minimal, and well-tested. I verified:
Finding: 6th truncation site the PR missed
Observed client user-agents are published into the diagnostics blob via Repro (verified): UA = The fix is 1 line: I prepared the fix locally (commit This is the same mechanism, same failure domain, different file. Per the "one issue = one scope" and "same mechanism → same issue" policies, it belongs in this PR, not a separate one. 结构化八问
合并判定:可合。 5 点修复正确、测试充分、CI 全绿。唯一发现是 |
Use safePrefix at the registry's 120-code-unit bound so valid Unicode observations remain encodable in diagnostics reports. Extend the public report matrix with split-pair, whole-pair and ASCII user-agent cases. The split-pair regression fails on 7ab1d63 with URIError; both controls pass. With this change, all 45 related tests, typecheck and build pass. The UA cases exercise programmatic registry input and report generation. Addresses the follow-up in ranxianglei#6750.
|
Applied the sixth-site correction in The public diagnostics matrix now also covers split-pair, exactly fitting whole-pair, and ASCII user-agent values. On the previous PR head The three new UA cases exercise programmatic registry input through public report generation; the actual HTTP cases cover configuration and topic input. The PR description now includes this follow-up and its validation. |
|
The latest head b894002 has completed the CORE CI run successfully (36 successful checks, 12 skipped), but the merge box still has three required contexts at Expected: I checked the workflow and the published master protection contexts: those Windows/Node 24 legs are only in the FULL matrix, while the default PR path selects CORE. The workflow is identical on this head and current master, so a base merge alone would not supply the missing checks. Could you apply the existing |
[bot] 🏷 Follow-up review: UA registry fix (commit
|
[bot] 🏷 Thanks for the detailed CI analysis. I can confirm the situation:
I cannot apply the Suggested path: @ranxianglei (owner) can apply the The code fix itself is fully verified (45/45 tests, typecheck, build, diff-check all clean on |
(ai: vllm-qwen/qwen3.8-27b) Cross-link: #6759 是本 PR 的重复(已在其线程下打 duplicate 标签并说明)。 A later PR (#6759, opened 2026-11-14T15:38Z) fixes the same bug #6749 with the same mechanism: its Two unblock actions remain on this PR (verified during the #6759 review):
|
…6750) into batch8-wave8
Reapply the remaining PR ranxianglei#6750 follow-up on current master f21b601. The diagnostics report fix and its first 17 tests are already on master. Retain the reviewed safePrefix correction at the registry boundary and its three public-report regression cases without changing their bytes. Original follow-up: b894002. Refs ranxianglei#6749 and ranxianglei#6750.
b894002 to
5491beb
Compare
|
Closes pair #6749 was auto-closed by the batch merge. Superseded by #6765 (merged to master as 95227c1). Your commit b894002 is in master verbatim — same content, same authorship, only the object ID changed (the batch used a real Thanks for the fix — it is live in master from 95227c1 onward. Note: you rebased this branch after the merge. The content is already in master via tip b894002 (pre-rebase) and is byte-identical to your new tip (verified: the only diff against the base is your two target files). The rebase minted fresh object IDs, so GitHub cannot match the PR to its in-master content. |
|
Superseded by #6765 (merged to master as 95227c1). Your commit b894002 is in master verbatim — same content, same authorship, only the object ID changed (real git merge, no rebase/cherry-pick rewrite). You rebased this branch after the merge; the content is already in master and byte-identical to your new tip (verified). The rebase minted fresh object IDs, so GitHub cannot match the PR. Thanks! |
…6750) into batch10-wave10
Closes #6749
Problem
The diagnostics report truncates valid strings with UTF-16
slice()before passing the complete report toencodeURIComponent(). If an emoji crosses a display boundary, truncation leaves a lone high surrogate and URL generation throwsURIError: URI malformed.This affects storage log lines, conflict log lines, serialized configuration, conflict-ledger detail, unknown topic labels, and recorded user-agent values. In a real local HTTP request, the existing
/__bili/diagnosticshandler has already selected status 200, but the exception leaves an empty response body instead of the report JSON. The copy/report UI cannot obtain the diagnostic evidence.Change
Use the existing
safePrefix()helper at all five report truncation points and at the user-agent registry's 120-code-unit input bound. A pair that would cross the existing UTF-16 limit is omitted as a whole; fully fitting pairs and ASCII text retain their previous output. This preserves the existing limits, ellipses, total-length note, topic trimming, and per-section plus final publish redaction.The fix concerns truncation of valid Unicode input. It does not add arbitrary malformed-input repair, change the diagnostics response shape, or change request processing.
Verification
URIErrorthrough the public report builder using real log/config files and the real conflict ledger. Two more use the actual proxy's local HTTP management endpoint and reproduce its empty JSON response.7ab1d635, the split-pair case fails withURIErrorand both controls pass. These cases callrecordClientUa()directly and then the public report builder; the actual HTTP cases cover configuration and topic input.npm run typecheck,npm run build, andgit diff --checkpass.Prior-work check
The diagnostics enrichment and retained-log changes (#3623, #5487) keep these UTF-16 cuts. The publish-redaction work (#4509), client coverage (#4650), and error-dump byte-budget fix (#4299) address different paths or behavior. The author's previous PR patches and issue index contain no implementation or report of this diagnostics truncation failure.