Repository navigation
[PR] fix: stop Markdown entity lines from looping in blockquote parsing - #6698
Merged
ranxianglei merged 1 commit intoNov 14, 2026
Merged
ranxianglei merged 1 commit into
ranxianglei merged 1 commit into
Conversation
This was referenced Nov 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A literal
>at the start of a Markdown source line enters the blockquote branch, but its inner loop only consumes a raw>marker. The source index never advances. Both server-rendered handoffs/articles and the browser renderer can therefore block indefinitely on ordinary text documenting an HTML entity.Change
Recognize blockquotes from the raw
>marker, using the same condition as the consuming loop. Literal entity text proceeds through the normal paragraph escaping path. Genuine quotes, code blocks, and paragraph formatting keep their existing behavior. The shared factory remains self-contained for browser inlining.Verification
markdownToHtml()wrapper and an actual esbuild-minified factory evaluated without its module scope, matching browser inlining.9495c764d36909eec263f404d4802d68b608f23f, both rendering tests fail withERR_SCRIPT_EXECUTION_TIMEOUT; the ordinary-quote and embedded/code-entity control tests pass. The VM execution budget interrupts synchronous nontermination instead of leaving the test runner hung.npm run typecheck,npm run build, andgit diff --checkpass. Full repository tests were not run locally; hosted CI remains pending.Prior work checked
The complete Afloat16 historical patch index has no earlier change to this renderer. The actual heads of related #5482 and #5901 still contain the mismatched quote conditions; #4737 does not change either Markdown implementation, and #2270 changes the independent static website renderer. The separate inline-code patch only prevents later inline-format regexes from reinterpreting code spans; it does not address this block-level nontermination.
Closes #6697