Repository navigation
Conversation
[bot] (ai: vllm-qwen/qwen3.8-27b) (前一轮会话因磁盘写满挂起 33 分钟被强重启,重启后从零复审本 PR,结论如下。) ⛔ 阻塞项(合并前必须改):PR 全文引用错了 issue 号PR 标题、正文(
后果:GitHub 的 需改齐的四处:
按「标题/正文属用户原始输入、agent 不改写」的规矩,我没有替你改正文/标题;合并是人工门禁,owner 合入前会看到本条。四处请作者一并改齐——别只改正文不改代码,否则代码写 #6588、正文写 #6587 对不上。 结构化八问
测试有效性新用例是真测试、非恒真: CIhead 标签已给 #6588(真正的问题单,作者无 admin 权限打不上)补: 判定代码可合,但先改 issue 引用:四处 #6587 → #6588 改齐后本 PR 即可合入。修复本身正确、最小、无回归,测试能兜底。 另有一个可选小清理(不强求):#2559 里那条现在冗余的 |
(ai: vllm-qwen/qwen3.8-27b) Re-verified the live check state, diagnosed all 5 red shards, and fixed the inherited red on the PR branch. What was red (head
Diagnosis: all 5 are inherited master-level failures — none caused by this PR. The PR touches only
Action taken (per CI-failure-coordination policy 2026-10-24 — inherited red converges on ci-fixes, not on PR branches):
七问
判定: 本 PR 自身改动无问题;notice-registry 红已随 ci-fixes 合入修复(新 head |
782f90e to
7d7ce10
Compare
|
(ai: DeepSeek-V4.1-Flash) 四处错号已改齐:正文(4 处,含 CI:32 绿 / 12 跳 / 0 失败(head |
7d7ce10 to
4e12515
Compare
(ai: vllm-qwen/qwen3.8-27b) 已重新核对 live 状态,CI 全绿:
|
ranxianglei
left a comment
There was a problem hiding this comment.
(ai: vllm-qwen/qwen3.8-27b)
Verdict: APPROVE — the code fix is correct and the regression test is valid. One pre-merge reference fix is needed (see "Finding" below); it does not affect the code.
Correctness. The fix adds color-scheme: dark to the OS-driven dark palette (@media (prefers-color-scheme: dark) { :root:not([data-theme]) { … } }, src/web/styles.ts:67). This is the canonical CSS mechanism for making the UA paint native control chrome (a <select>'s option popup, checkbox/radio glyphs, scrollbars) in dark. It is correctly scoped:
- The media query is narrowed to
:not([data-theme]), so it does NOT touch the explicit pins —:root[data-theme="dark"]already carriescolor-scheme: dark(line 112), and:root[data-theme="light"]carriescolor-scheme: light(line 156). - The base
:rootkeepscolor-scheme: light dark(line 7), which resolves tolightwhen the OS has no preference — the correct default.
All four scheme bindings are now consistent, and the palette values are untouched.
Test. The new #6587 test (tests/dsh-settings-ui.test.ts:2264) reads the styles file and asserts color-scheme: dark is present in BOTH dark palettes, scoping the read to each block (not a bare includes(), which would pass against the base :root's light dark). I ran the file on the fixed head: 28/28 pass, including the #2559 set-equality test. The PR author's A/B claim (strip the fix → red, restore → green) matches the test logic — the OS-driven assertion is the one that flips.
Regression surface. Pure CSS + test. No wire / config / persistence / kernel / version impact. No behavior drift beyond the intended one (native controls now follow the dark palette on the OS-driven path). Both compression modes are unaffected (this is a web-UI CSS change, not a wire change).
Finding (pre-merge — needs author/owner, not code). The PR title and body reference #6588, but #6588 is the dsh-go host issue ("DSH Go Host: Verified Working but Undocumented"). The actual color-scheme defect is #6587 ("In dark mode, native controls on the settings page remain light…"). I corrected the two in-code references (the styles.ts comment and the test name) in commit 983b272. The PR body, however, still says Fixes #6588 — merging as-is would auto-close the dsh-go issue #6588 (which has its own PR #6591) instead of the color-scheme issue #6587. Please change Fixes #6588 → Fixes #6587 in the body (and the title) before merging. I cannot edit the PR title (system-owned) or the body (only the kernel-change line is permitted), so this needs the author or owner.
已顺手修:PR 误引 #6588(那是 dsh-go 宿主 issue),实际 color-scheme 缺陷是 #6587;代码内两处引用(styles.ts 注释 + 测试名)已改为 #6587 + commit 983b272
8问(中文结论)
- 是什么问题:深色模式下走 OS 驱动路径(文档不带
data-themepin)时,设置页的原生控件(compress 提示词包<select>下拉、checkbox/radio、滚动条)仍按浅色绘制,与已切深的调色板错配。 - 什么原因导致的:
src/web/styles.ts里两份深色调色板本应各有一份color-scheme,但 OS 驱动那份(@media (prefers-color-scheme: dark) { :root:not([data-theme]) { … } })漏了color-scheme: dark。UA 画原生控件 chrome 依据的是color-scheme而非 CSS 变量;基础:root的light dark在 OS 未表态时解析为 light,于是自动路径出现「调色板已深、控件仍浅」。显式 pin 那份自带dark,所以只有自动路径中招。 - 影响范围与严重程度:仅影响自动/OS 驱动深色路径下的原生控件 chrome(不止一个下拉);属体验瑕疵(控件可用、颜色不对),不影响功能/数据/wire。p2 级。
- 怎么修复的:给 OS 驱动那份深色调色板补上
color-scheme: dark;,与显式 pin 那份对齐;color-scheme会继承,一次覆盖页面所有原生控件。不动调色板取值。 - 是否有回归问题:无。纯 CSS + 测试改动;媒体查询收窄到
:not([data-theme]),不碰显式 pin(dark 已有dark、light 已有light);基础:root保持light dark。#2559集合相等断言仍绿(整文件 28/28)。 - 是否破坏缓存:不涉及(无缓存/重试/游标/去重键)。
- 是否改了设计方向:不涉及(无架构/边界/数据流转向)。
- 是否引入了新的配置:不涉及(无新 env/config/默认值)。
判定:代码正确、测试有效,可合。合并前请把正文/标题的 #6588 改为 #6587,否则会误关 dsh-go 的 #6588。
[bot] 🏷 PR #6589 reviewed → APPROVE (GitHub review What I did / verified:
Finding fixed on the spot — the PR referenced the wrong issue: #6588 is the dsh-go host issue ("DSH Go Host: Verified Working but Undocumented"); the actual color-scheme defect is #6587. I corrected the two in-code references (the 8问(中文结论)
判定:代码正确、测试有效,可合。合并前请把正文/标题的 |
983b272 to
ffe29b3
Compare
ranxianglei
left a comment
There was a problem hiding this comment.
APPROVE — re-reviewed on the rebased head ffe29b320 (base = current master f21b601893).
The net diff is unchanged from the prior round (58 lines, 2 files) — the branch was rebased onto current master, and the issue reference is now correctly #6587 in the title, body, and code (the prior round's finding: it cited #6588, the dsh-go host issue).
Verified on this head:
src/web/styles.ts—color-scheme: darkadded to the OS-driven dark palette (:root:not([data-theme]), L67). All four scheme bindings consistent: base:rootlight dark(L7), OS-drivendark(L67), pinned darkdark(L112), pinned lightlight(L156). Palette values untouched; the media query is narrowed to:not([data-theme])so explicit pins are unaffected.tests/dsh-settings-ui.test.ts:2264— the#6587test scopes the read to each block (not a bareincludes(), which would pass against the base:root'slight dark), so it genuinely catches a regression in either dark palette.- Targeted test pass; full file 28/28;
npm run typecheckexit 0. - No
kernel// config / wire / persistence / version impact; both compression modes unaffected.
8问(中文结论)
- 是什么问题:深色模式下走 OS 驱动路径(文档不带
data-themepin)时,设置页的原生控件(compress 提示词包<select>下拉、checkbox/radio、滚动条)仍按浅色绘制,与已切深的调色板错配。 - 什么原因导致的:
src/web/styles.ts里两份深色调色板本应各有一份color-scheme,但 OS 驱动那份漏了color-scheme: dark。UA 画原生控件 chrome 依据的是color-scheme而非 CSS 变量;基础:root的light dark在 OS 未表态时解析为 light,于是自动路径出现「调色板已深、控件仍浅」。显式 pin 那份自带dark,所以只有自动路径中招。 - 影响范围与严重程度:仅影响自动/OS 驱动深色路径下的原生控件 chrome(不止一个下拉);属体验瑕疵(控件可用、颜色不对),不影响功能/数据/wire。p2 级。
- 怎么修复的:给 OS 驱动那份深色调色板补上
color-scheme: dark;,与显式 pin 那份对齐;color-scheme会继承,一次覆盖页面所有原生控件。不动调色板取值。 - 是否有回归问题:无。纯 CSS + 测试改动;媒体查询收窄到
:not([data-theme]),不碰显式 pin(dark 已有dark、light 已有light);基础:root保持light dark。#2559集合相等断言仍绿(整文件 28/28)。 - 是否破坏缓存:不涉及(无缓存/重试/游标/去重键)。
- 是否改了设计方向:不涉及(无架构/边界/数据流转向)。
- 是否引入了新的配置:不涉及(无新 env/config/默认值)。
判定:代码正确、测试有效,可合。
[bot] 🏷 PR #6589 re-reviewed on the rebased head → APPROVE (GitHub review The branch was rebased onto current master ( Verified on this head (
8问(中文结论)
判定:代码正确、测试有效,可合。上一轮的问题引用(#6588→#6587)已由作者/owner 在标题/正文/代码里全部改正,无遗留项。 |
95db7c0 to
6cfd666
Compare
The OS-driven dark block supplied the dark CSS vars but left `color-scheme` at the base `light dark`, which resolves to light when the OS asks for neither scheme. Native control chrome is painted from `color-scheme`, not from the vars, so the compress prompt-pack <select> on #/config popped a white option list over the dark page while every other surface was dark. Both dark palettes now declare `color-scheme: dark`. The regression test reads each dark block on its own so the base `light dark` declaration cannot satisfy it. Fixes ranxianglei#6587
…for the color-scheme fix
6cfd666 to
7558ee7
Compare
|
Closes pair #6588 was auto-closed by the batch merge. Superseded by #6765 (merged to master as 27bf2e5). Your commit 983b272 is in master verbatim — same content, same authorship, only the object ID changed (the batch used a real Thanks for the fix — it is live in master from 27bf2e5 onward. |
Fixes #6587 ## 改了什么
src/web/styles.ts:给 OS 驱动的深色块@media (prefers-color-scheme: dark) { :root:not([data-theme]) { … } }补上color-scheme: dark;。tests/dsh-settings-ui.test.ts:新增#6587回归用例——分别切开两块深色调色板的声明集,断言color-scheme: dark在两边都在。diff @media (prefers-color-scheme: dark) { :root:not([data-theme]) { + color-scheme: dark; --bg: #0d1117;## 为什么 深色模式下设置页(#/config)的 compress 提示词包<select>展开后是白/浅底选项表,压在深色页面上;同页其它原生控件(checkbox / radio / 滚动条)一样停在浅色分支。 两个面各有一份color-scheme,但只有显式 pin 那份有: | 规则 |color-scheme| |---|---| |:root(基础) |light dark| |:root[data-theme="dark"](显式 pin) |dark| |@media (prefers-color-scheme: dark) { :root:not([data-theme]) { … } }(OS 驱动,含整份深色变量) | 缺 | 基础那份light dark在"OS 没明确表态"时解析为light。而 UA 画原生控件 chrome 用的是color-scheme,不是 CSS 变量——于是 OS 驱动这条路径出现调色板已切深、控件仍按浅色绘制的错配。显式 pin 那条路径自带dark,所以只有自动路径中招,也正好解释了为什么#2559那条声明集合相等断言里要continue跳过color-scheme。color-scheme会继承,页面上所有原生控件一次覆盖;不动调色板取值、不动 wire / 配置面 / 持久化。 ## 取证 按§7.2目标套件本地跑(完整 verdict 以本 PR head 上的 CItest车道为准)。 - 回归用例 A/B(证明它真能变红):--test-name-pattern='#6587',摘掉src/web/styles.ts的修复 → 红,报the OS-driven dark palette binds color-scheme: dark for native controls;加回修复 → 绿。 - 受影响套件:tests/dsh-settings-ui.test.ts+tests/web-blocks-tree.test.ts+tests/web-i18n.test.ts,预载链按scripts/run-ci-tests.mjs的PRELOAD_ARGS:tests 58 / pass 58 / fail 0。 -npm run typecheck:exit 0。 - 复现环境:bili0.1.213,dsh 插件原生内嵌?embed=1设置页,Windows 11。 ## 附注 - 本 PR 由上游 forkOMSociety/billion-context发起(账号对上上游无推送权),按贡献者路径提交。 - PR 正文之外的 issue #6587 标签打不上:标签 API 对上上游要求 admin(Must have admin rights to Repository)。按reference/triage.md应打p1/p2/p3之一 + 宿主车道 +scope/*,相应为p2·dsh·scope/ui(另有bug),麻烦 owner 侧补一下。 - 未动kernel/、src/update.ts、配置面、持久化格式、wire 协议,无version变更。