Repository navigation
[PR] fix: forward single-shot Responses server-tool calls instead of 400 - #6574
Conversation
…anxianglei#6548) A single-shot Responses call with string input and only server-executed search tools (pi-web-access xAI web search) is not a conversation turn: it carries no history to fingerprint and creates no session state, so the ranxianglei#286 refusal's rationale does not apply to it, and the client cannot carry an identity here. Forward it verbatim instead of hard-400ing.
Reviewed the diff in context, ran the targeted suites locally, and checked both compression modes. Assessment below. Duplicate screening: Not a duplicate — only PR #6574 references #6548, and no other open PR fixes the same pi-web-access xAI-search 400. What I verified (independently of the PR description):
结构化八问(中文,供人工评审):
Verdict: Mergeable. Code review + targeted suites green; full CI pending (24 queued, 0 failed). |
Status update (review already posted above with the full 八问):
|
CI update: the mirror cache was stale — the full CI actually completed and the I'm now determining whether those 5 test-shard failures are inherited from master (master currently red → not this PR's problem) or introduced by the diff. The PR only touches the #286 refusal branch + a new predicate + its tests, so I need to confirm the failing test names don't overlap the changed paths. Will report the verdict shortly. |
(ai: vllm-qwen/qwen3.8-27b) Red CI verdict: 100% inherited master red — not this PR's code. No fix applied on the PR branch (policy: master-level fixes converge into ci-fixes, not onto individual PR branches). Live check state re-verified (mirror cache, head
This PR's own 5 new tests are all green in CI (verified line-by-line in the passing shard ubuntu-22-2):
Why no fix on the PR branch:
Action taken this run:
Resolution path: once the sentinel converges the visibleNotices hermetic fix into ci-fixes, 八问(中文):
判定:本 PR 的 CI 红 100% 继承性 master 红,非本 PR 代码问题;本分支不动,等哨兵在 ci-fixes 收敛 visibleNotices hermetic 修后 merge 重跑即绿。 |
[ework] auto-fix stalled: test (ubuntu-latest, 22, 1), test (windows-latest, 22, 1), test (ubuntu-latest, 24, 1), test (windows-latest, 22, 3), test (windows-latest, 22, 2) — stopping for human review |
1 similar comment
[ework] auto-fix stalled: test (ubuntu-latest, 22, 1), test (windows-latest, 22, 1), test (ubuntu-latest, 24, 1), test (windows-latest, 22, 3), test (windows-latest, 22, 2) — stopping for human review |
Resolve conflicts with master: the side-request.js import in src/server/handle.ts and the allowlist in tests/side-lane-invariants.test.ts both gained identifiers on both sides — take the union (upstream's hasSingleShotBudget / isStructuredOutputCall plus the PR's isResponsesServerToolSingleShot). All other files merged from disjoint upstream/PR changes.
The merge of master dropped the spaces inside the braces of the side-request.js import. Restore repo style; no semantic change.
…merge commit These files (issue-number lists recording the superseded closings of the previous four batches #6439/#6455/#6464/#6482) are present in neither parent of the #6574 merge commit yet appear in its result, and survive to the branch tip. They are not part of any source PR, are referenced nowhere, are not mentioned in the PR description, and the previous four batch merges never committed such files to master. Process scratch data does not belong at the repo root; the closing record already lives in GitHub history.
|
Closes pair #6548 was auto-closed by the batch merge. Superseded by #6765 (merged to master as 2f92132). Your commit 6190fb3 is in master verbatim — same content, same authorship, only the object ID changed (the batch used a real Thanks for the fix — it is live in master from 2f92132 onward. |
With bili installed as a pi package, the xAI web-search backend of pi-web-access stops working: every search gets a 400 from bili, "Missing stable conversation identity". The fetch patch claims the call because its URL ends in /v1/responses, and the proxy then refuses it because no conversation identity exists and there is no history to match.
That call is not a conversation turn. pi-web-access sends a minimal single-shot Responses body, string input plus web_search/x_search tools only, no history, and it has no knob for a session id, so the client cannot carry an identity. The #286 refusal exists to keep content-fingerprint sessions from orphaning state, and a call like this creates no session state at all.
What changed:
How verified:
Fixes #6548