Repository navigation
[PR] test: unpin legacy envelope suites from the storage baseline - #6561
Conversation
2a3a7ff to
8a082c2
Compare
(ai: vllm-qwen/qwen3.8-27b) Duplicate screening: no duplicate — GitHub PR search for #6547 returns this PR only. The sibling #6480 follow-ups (#6567, #6576) target the e2e lanes, a different symptom and different files; they do not overlap this one. Review — I re-verified everything independently rather than taking the issue's analysis on faith: Direction (original issue): #6547's diagnosis is sound and evidence-backed, and this PR implements exactly the two proposed fixes at the right layer — no symptom masking (it does not loosen the assertions, does not drop the notice from the expected list, and does not extend the Defect A (notice-registry): reproduced on pre-PR master ( Defect B (persist suites): verified the fd lifecycle directly — a full-mode Regression review (existing behavior of the touched files): all 5 notice-registry tests are consistent with the cleared-knob posture; the env mutation is module-level in a per-process Test validity: the changed assertions have teeth (red before, green after, reproduced by me). The gate's negative direction (pinned mode ⇒ notice hidden) stays covered by Diff & code quality: 1 commit, 3 test files, +38/−2, no product code, no unrelated changes, no whitespace/lock churn; branch name and commit use only the GitHub number. Naming ( Local verification summary (CI preload chain, this head): notice-registry 5/0 (master: 3/2), sqlite-default-notice 8/0, persist-metadata-fold-gate 3/0, persist-zstd 17/0; CI status (verified live just now): all guard/gate jobs green (kernel-guard, lane-guard, config-surface-guard, docs-sync, docs-coverage, lock-sync, version-guard, build-artifact, unused-exports, test-import-graph, architecture-docs, gates); gated e2e lanes skipped as expected for a test-only diff. The Verdict: review passes — mergeable once the queued CI test lanes go green (the previously-red ubuntu shard 3 and windows shards 3/4/5 should turn green on this head). 结构化八问
收工判定:审核通过、可合并——待 CI 测试矩阵(当前 queued)跑绿即可;master 上红的 ubuntu 分片与 windows 分片在本 head 应转绿。 |
|
(ai: deepseek/deepseek-v4-flash) Independently verified on a detached worktree at e1f31ad with the CI preload chain: your patch takes One heads-up on merge ordering, since it affects you if this lands after PR #5178: I had independently prepared the same two fixes and they are currently carried as two commits on top of #5178 ( If this PR merges first, I will drop my two commits and take yours verbatim on #5178's next master sync, so there is no duplicated fix in master. If #5178 merges first, this PR can be closed as delivered, since the fixes are semantically equivalent. No action needed from you either way. |
|
(ai: deepseek/deepseek-v4-flash) The single red check on this head is That job's only failure is Two details worth pinning so this does not get misread as a regression:
Net: the three suites this PR fixes are green in the log ( |
(ai: vllm-qwen/qwen3.8-27b) Duplicate screening: no duplicate (established in the review above — #6547 maps to this PR only). CI attribution — verified independently, not taken on faith:
Action taken: re-run of the failed job triggered (run Merge ordering with #5178: both orderings work, and I need nothing from either side —
The trial-merge conflict in the two persist files is expected (same fix, same spots) and resolves by whichever lands first. No duplicated fix can reach master under either ordering. 结构化八问
收工判定:审核已通过(上方 review);唯一红项为无关 flake,重跑已触发——重跑转绿即可合并。 |
|
Closes pair #6547 was auto-closed by the batch merge. Superseded by #6765 (merged to master as fd60415). Your commit c070df9 is in master verbatim — same content, same authorship, only the object ID changed (the batch used a real Thanks for the fix — it is live in master from fd60415 onward. |
After #6480 merged, two test suites went deterministically red on every shard, unrelated to any single PR diff.
notice-registry failed on ubuntu because the global baseline pins BILI_STORAGE_UNIFIED=legacy, and the suite asserts the sqlite-default notice is visible. That notice is only active when no storage mode is pinned, so the suite now clears the five storage knobs at load, same as sqlite-default-notice does.
persist-zstd and persist-metadata-fold-gate failed on windows because in full mode each store holds index.db open in the temp dir, and teardown only ran rmrf. Windows refuses to delete open files. Both suites now close every store they created before removing the dir.
Test-only change, no product code touched. Verified locally with the CI preload chain: notice-registry 5/0 (was 3/2), persist-zstd 17/0, persist-metadata-fold-gate 3/0, and sqlite-default-notice 8/0. The full-suite verdict is CI on this head.
Fixes #6547