Repository navigation
[PR] test(loop): pin faithful forwarding of model-emitted calls after acp_status continuation - #6544
Conversation
…status continuation A mock upstream replays the ranxianglei#5950 turn shape: round 1 carries reasoning plus the acp_status call, round 2 answers in text or emits the Read for the nonexistent path. Both directions asserted, per the gate discipline (ranxianglei#3617): a text-only round 2 reaches the client with no tool_call frame (the proxy fabricates nothing), and a model-emitted Read reaches the client byte-exact, once, with its id and arguments verbatim (the proxy suppresses and rewrites nothing). The round-2 request body is asserted too: the acp_status call/result pair replays with matching ids and the round-1 reasoning intact. Related to ranxianglei#5950. This test documents and locks in the correct behavior; it does not fix the model-side hallucination behind the report.
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Duplicate screening: Not a duplicate. This PR pins the faithful-forwarding contract for the Review verdict: A valid regression test with teeth. Verified:
CI status (important): The PR's CI is RED (5 test shards fail), but not because of this PR. All failures are in Verdict: The test is correct and has teeth. It's a valid regression test that fills a real gap. Hold for merge until the master red (notice-registry) is cleared — it's not this PR's fault, and merging now would just inherit the red. The author can rebase onto a green master once the notice-registry desync is fixed. 8问 (for the human reviewer):
CI 红说明: 5 个 test shard 红,全部来自 |
|
Superseded by #6765 (merged to master as a827683). Your commit 03c6915 is in master verbatim — same content, same authorship, only the object ID changed (the batch used a real Thanks for the fix — it is live in master from a827683 onward. |
Related to #5950.
The phantom Read in #5950 is model-emitted: the proxy forwards it byte-exact, and a text-only continuation carries no tool call at all. This PR pins that contract with a regression test so a future change cannot silently start filtering or fabricating calls in the continuation path.
What changed
How verified
This test documents the correct behavior; it does not fix the model-side hallucination behind #5950.