Repository navigation
Conversation
…ful relays (ranxianglei#2483 follow-up)
[bot] 🏷 (ai: opencode/qwen3.8-27b) 查重: 不重复 — 检索 open+closed 的 renderNone 相关 issue/PR:#6506 是本 PR 的来源 issue(该家族唯一 open 条目);#2485(closed)是本 PR 所基于的前置全局一致性修复;无其他 open PR 触碰 per-route render tags。 Review of PR #6507 — fetched head What I verified in code (not just the diff):
Findings:
Tests: 4 wire-byte tests pin the decision matrix (route on → untagged + no tags-only prompt section; route Regression audit (existing behaviors touched by this diff):
结构化八问
结论: 代码本身可合;合并前需补 PR 正文的 config surface 一节(第 1 条,或 owner 豁免)。 |
[bot] 🏷 (ai: opencode/qwen3.8-27b) PR #6507 review — complete. (Full review with code verification + 8问 posted in the comment above; this is a closing summary.) Verdict: code is solid and merge-ready from my side. Fetched head One required action before merge: the PR body is missing the mandatory "config surface" section (Configuration Surface Discipline) — suggested text is provided in the review comment above. Two optional nits (docs cross-ref, test header comment) are non-blocking. Merge path: 8问 (compact; full version in the review comment above):
结论: 代码可合;合并前补 config surface 一节(或 owner 豁免);按 §7.4 走人工合并。 |
Fixes #6506. Follow-up to #2483 / #2485.
What
Adds a route field
providers["<upstream url>"].renderNone:true: no ACP render tags in that route's history (and no tags-only prompt section)false: tags forced on, even whendiagnostics.renderNone=truediagnostics.renderNoneACP_RENDER_NONEstill wins over bothHow
src/knobs.ts:renderNone()reads a request-scoped override from anAsyncLocalStorage(withRouteRenderNone). Every existing reader (prepare-anthropic/openai/responses/google, inject, count_tokens, compress-loop rebuild) picks it up without signature changes.src/server/handle.ts: resolves the route once per request (findRoute(opts.routes, providerDestUrl)?.renderNone) and wrapsrunPrepareInnerwith it.src/config.ts:ProviderRoute.renderNone, parsed inparseRouteEntry, listed inNAMED_PROVIDER_ROUTING_FIELDS.src/cache-ledger.ts: the stateful-upstream hint now points at the route field.cr.rninwebsite/config-reference/providers.yaml, regenerated withtools/gen-config-docs.mjs generate.Tests
New
tests/issue2483-route-render-none.test.ts(wire bytes, same harness asissue2483-render-strategy): matching route untagged, routefalseoverrides globaltrue, non-matching route keeps tags, env wins over route.Pre-flight
npm run typecheck: cleannode --import tsx --teston the new test + issue2483-render-strategy, issue1881-acp-tags-decoupled, knobs-config-precedence, cache-seam-detector, cache-ledger suites: 129/129 passgen-config-docs check-coverageandscripts/config-surface-guard.mjs: OKkernel/**change, no version bump.