Repository navigation
[PR] fix: teach direct ACP calls for Codex exec namespaces - #6461
xiaozhu1337 wants to merge 2 commits into
Conversation
…egression tests Review fix (small, non-semantic): the new ranxianglei#5592 tests re-declared a substring of the note locally instead of importing the constant, unlike the file's existing PTC-note pattern. Export CODEX_EXEC_EXEMPT_NOTE and assert the full note — strictly stronger, no behavior change.
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) 查重: 不重复 — no other open PR targets the #5592 prompt-gap facet (checked the open [PR] list; this PR is the only one). Review verdict: code quality PASSES — mergeable once the Live state (verified just now): PR open, draft, mergeable, no labels; base Local verification (on the PR head):
Review-fix commit pushed to the PR branch ( What remains before merge (all outside the code):
Scope note: the PR deliberately does not close #5592 in full — the quiet-status observation and the host's missing ready MCP client are separate facets (the issue carries Code review highlights:
结构化八问(供人工 reviewer):
判定: 代码质量通过(方向正确、无回归、测试有牙、diff 干净);合入前需 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) CI update (verified just now): the review-fix head |
|
Landed via batch PR #6482 (merged) — closing as superseded. |
Codex requests declaring
functions.execreceived no direct-call guidance for proxy-owned ACP tools, so the model could try a nonexistenttools.*SDK binding. Responses injection now recognizes the qualified custom/function name and thefunctionsnamespace form, includingadditional_toolswrappers within the supplied tools array, and tells the model to call the injected ACP tool directly.Addresses the proxy prompt gap in #5592. Detection is separate from the omnibus reachability gate: bare
exec,functions, and unrelated namespaces do not enable compression. Native MCP declarations, plugin manifest binding instructions, client tool objects, and pack-owned descriptions are preserved. This does not repair Codex's missing ready MCP client or establish the cause of the separate quiet-status observation, so it deliberately does not close the whole issue.Validation on rebased head (base
259cd876):ptc-runcode-toolsandlane-decisions-matrix, with both storage/environment preloads.git diff --checkpass.Draft because the required real Codex four-phase E2E has not run: the configured default upstream at
127.0.0.1:8199is unavailable locally, and the PR's real-Codex workflow skipped the E2E job. The PR build-artifact check passed; main CI is still pending. Remote CI on the pushed commit remains the full-regression verdict; local targeted tests are not a substitute for either gate. This change only examines the existing injection wrapper's tools argument: declarations present only ininput[].additional_toolsare not newly inspected, and an unqualifiedexecalone intentionally does not trigger the hint.