Skip to content

[PR] EN | acp_status: stop recommending BLOCKED sentinel range endpoints (#6168) - #6305

Open
ranxianglei wants to merge 5 commits into
masterfrom
2026-11-11_blocked-status-range-endpoints
Open

ranxianglei wants to merge 5 commits into
masterfrom
2026-11-11_blocked-status-range-endpoints

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

What & why

Fixes #6168 (follow-up empirical report to #6167 — Windows / Codex CLI evidence).

acp_status's uncompressed range view rendered candidate rows whose endpoints were the BLOCKED sentinel (e.g. BLOCKED–m02518 ⚠ not foldable: refs unresolvable). Root cause: collectVisible() correctly includes policy-protected messages in the totals, but renderUncompressedRanges() used each segment group's first/last entry verbatim as candidate endpoints — while the recommend side already screens BLOCKED out at base-set level (buildCompressibleRanges). The report view violated the documented identical-segmentation contract. The apply path is unaffected, matching the reporter's observation that valid ranges compress fine.

Changes (display layer only)

Behavior changes (old → new, disclosed)

  1. Range rows can no longer start/end at BLOCKED — protected content now appears once in the stats line plus the per-message drilldown (was: bogus row + flat warning).
  2. A group whose visible members are all protected renders (no candidate ranges — every visible message is protected) instead of an unresolvable row.
  3. Genuinely failing projections print the underlying error truncated to 100 chars instead of "refs unresolvable".

Tests

New kernel/tests/blocked-status-ranges.test.ts — 9 tests over the issue's acceptance matrix: leading/trailing/mid-group/all-BLOCKED, non-monotonic refs, genuine resolution failure, sort=time+limit, per-message drilldown, normal-only regression guard. Targeted suites green locally (69/69 incl. the pre-existing report/ranges/reversed-ranges/status-surface suites); full-suite verdict = CI on this head.

Kernel boundary

kernel-change: missing guard against the BLOCKED sentinel in report-layer candidate construction — violates the documented identical-segmentation contract between recommend and report views (recommend already carries the contrasting implementation). Mechanical-bug exemption applied (owner policy 2026-11-06): reproducing regression test added, declaration present; the human-only review tier still gates merge. Kernel version 0.0.193 → 0.0.194 (CI-enforced version discipline).

Closes #6168

…nt (#6168)

kernel-change: acp_status' uncompressed range view used each segment group's first/last entry verbatim as candidate endpoints; policy-protected messages carry the BLOCKED sentinel ref, so groups containing them rendered rows like 'BLOCKED-m02518' that could never be submitted to compress and were uniformly flagged 'refs unresolvable'. The recommend side already screens BLOCKED out at base-set level (buildCompressibleRanges); the report view violated the documented identical-segmentation contract. Fix is display-layer only: every BLOCKED entry in a group moves to an aggregate protected stats line under the header (totals unchanged), candidates span the first..last normal members of the group positionally (no ref arithmetic, non-monotonic refs kept), all-BLOCKED groups emit no candidate row, and flagFor now shows the real projection error (cleaned, capped) instead of the flat misdiagnosis. No change to apply/recommend/segmentation semantics.

Behavior changes (disclosed): (1) acp_status uncompressed range rows can no longer start/end at BLOCKED; protected content now appears once in a 'protected: N msgs, T (BLOCKED refs - not submittable to compress)' line plus the per-message drilldown. (2) A group whose members are all protected renders '(no candidate ranges - every visible message is protected)' instead of an unresolvable row. (3) The foldability warning for genuinely failing projections prints the underlying boundary/projection error truncated to 100 chars instead of 'refs unresolvable'. Header totals and per-message counts are byte-identical to before for the same session state.

Fixes #6168
@ranxianglei ranxianglei changed the title EN | acp_status: stop recommending BLOCKED sentinel range endpoints (#6168) [PR] EN | acp_status: stop recommending BLOCKED sentinel range endpoints (#6168) Nov 11, 2026
@ranxianglei ranxianglei added bug Something isn't working codex p2 scope/kernel labels Nov 11, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-11-11_blocked-status-range-endpoints (ba00f79)

Latest build — install this exact version

npm install -g billion-context@0.0.11011-pr.6305.656721d

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
ba00f79 billion-context@0.0.11011-pr.6305.656721d build
03a2c5b billion-context@0.0.10109-pr.6305.a705aa9 build
4e39b71 billion-context@0.0.9302-pr.6305.d963165 build
0912a21 billion-context@0.0.9274-pr.6305.833ded9 build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr6305.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] (ai: vllm-qwen/qwen3.8-27b) 进度汇报(进程曾被强制重启,恢复后已完成冲突处理):

PR #6305 冲突已解决并推送,等待 CI。

@ranxianglei

Copy link
Copy Markdown
Owner Author

该PR已按根因归类纳入 [dsh-lane] 根因汇总 #6294,由汇总单统一跟踪处理;本单不再单独跟进,故关闭。如认为归类有误或问题仍未解决,请直接回复,会重新打开。

@ranxianglei

Copy link
Copy Markdown
Owner Author

状态更正(自动化脚本误操作): 本单此前被「纳入根因聚合」流程误关闭, 现重新打开。机器人工作已停, 本单由根因聚合线程统一跟踪, 根因修复落地后请手动关闭或在本单回复「close」。
[automated: re-open after bot-stop-only policy]

@ranxianglei ranxianglei reopened this Nov 12, 2026
@ranxianglei

Copy link
Copy Markdown
Owner Author

重新打开:此前被归类聚合脚本误关。按 owner 口径,纳入根因聚合的 issue 只停机器人、不关闭,由根因聚合线程统一跟踪,根因修复落地后统一关闭。
(reopened: absorbed issues must not be closed, only bot work stopped — owner policy 2026-11-12)

@ranxianglei

Copy link
Copy Markdown
Owner Author

(更正)此前按"清理"口径误关闭;按 owner 口径纠正:被根因聚合纳入的 issue 只停机器人、不关闭。本 issue 重新打开,机器人工作已停。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] (ai: vllm-qwen/qwen3.8-27b) 收工汇报(本会话曾被强制重启两次——原因是在会话内长时间等待 CI;已改为「推送后立即汇报、不再会话内守候」,CI 若红会由系统再次唤醒):

PR #6305 冲突已清除,当前 head 4e39b7197f,mergeable=True(blocked = 等新 CI/审批,属正常等待态)。

八问:

  1. 是什么问题:上游 PR(修 [Codex CLI] Follow-up to #6167: Empirical Verification of Local BLOCKED Scope and Proposed Fix for Reserved Protection S | [Codex CLI] 补充 #6167:本机 BLOCKED 范围实证与保留保护语义的修复建议 #6168 的 acp_status BLOCKED 端点显示问题)与 master 冲突(dirty),CI 因此完全没跑,PR 无法合并。
  2. 什么原因导致的:PR 从旧基线切出,master 期间合入 Request two capabilities: compressed block "retirement" and summary "external rewrite". | 请求两个能力:压缩块「退役」与摘要「外部重写」 #5765(retire 功能,kernel 版本 0.0.193→0.0.195),与 PR 自身的 0.0.194 在 kernel/package.json、package-lock.json 上撞车。
  3. 影响范围与严重程度:仅该 PR 的可合并性被卡住;不涉及任何已发布版本的行为。
  4. 怎么修复的:master 合入 PR 分支,版本冲突取 0.0.196(master 的 0.0.195 + 本 PR 的 kernel 变更增量),三处同步:kernel/package.json、根 package-lock.json、kernel/package-lock.json。顺带修掉原 PR 的既有不一致:它漏同步 kernel/package-lock.json(停在 0.0.193,与其自身 package.json 不符)。之后 master 又前进([PR] fix: persist ledger rows before the model call (durability-before-render) #6326,纯 host 持久化侧),二次合入,零冲突。
  5. 是否有回归问题:无。PR 侧(kernel/report.ts + 新测试 + 版本号)与 master 两批新提交(Request two capabilities: compressed block "retirement" and summary "external rewrite". | 请求两个能力:压缩块「退役」与摘要「外部重写」 #5765 kernel、[PR] fix: persist ledger rows before the model call (durability-before-render) #6326 host)零文件重叠,无语义交叉;report.ts 自动合并正确叠加两侧功能(retired-blocks 段 + BLOCKED 端点修复)。本地验证:typecheck + build 绿;定向 kernel 套件 116/116 绿(新套件 + 12 个既有 report/range/status-surface 套件 + master 新增 issue5765-retire-rewrite)。CI 实证:上一 head 0912a21831 30 项检查 0 红(27 项 success/skipped,3 个 test 分片末次读取时仍在跑)。
  6. 是否破坏缓存:不涉及——未触碰缓存/重试/游标/去重逻辑。
  7. 是否改了设计方向:无。
  8. 是否引入了新的配置:无。

透明披露:第二次推送(4e39b7197f)时本地 node_modules 已被重启清空、typecheck 未及跑完推送就发出;推送后已重装依赖并补跑 typecheck 通过。该次合入零冲突且与 #6326 零文件重叠,风险面为零,但流程上应先验证后推送,记下。

判定:CI 工程师部分收工——冲突已清、无红项遗留,等新 head 的 CI 全绿 + owner 审批即可合并。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

查重: 不重复——镜像 [PR] 行已查,无针对本线程的并行修复 PR。分支上已含另一位 worker 推上去的 master 同步(4e39b71),我独立复核而非另开 PR;本地独立重做的合并结果与远端 head 逐字节相同(git diff 为空),故本轮没有新推送。

代码审核结论:修法正确,纯展示层。 根因在源码层面证实:base 的 renderUncompressedRanges 直接拿每个 segment group 的首/末条目当候选端点,BLOCKED 哨兵(策略保护消息)因此泄漏成 BLOCKED–m02518 ⚠ not foldable: refs unresolvable 这类假行;而 recommend 侧(buildCompressibleRanges)早在 base-set 层就筛掉了 BLOCKED——report 视图违反了文档承诺的 identical-segmentation 契约。修法:BLOCKED 条目全部收进 header 下一行聚合统计;候选行按位置跨 group 内首..末正常成员(无 ref 算术,非单调 ref 保留);全保护 group 渲染 (no candidate ranges — every visible message is protected);flagFor 打印真实投影错误(空白折叠、100 字符截断)替代一刀切的 "refs unresolvable"。apply/recommend/segmentation 语义零改动;宿主侧消费者(src/marker/status-body.ts、src/acp-panel.ts)只匹配稳定 header 串,不受影响。

验证证据(均在远端 head 4e39b71 的同一棵树上):

  • 顺带修掉的原 head 隐患:原 head 的 kernel/package-lock.json 停在 0.0.193 而 kernel/package.json 是 0.0.194,CI lock-sync 门禁(ci.yml,[PR] kernel: sync package-lock.json to 0.0.136 (lock left at 0.0.133 by the bump chain) #3782 检查)会红;当前 head 三个版本文件一致(0.0.196),lock 幂等性按 CI 原样流程(npm install --package-lock-only + git diff --exit-code,root 与 kernel 各一遍)验证干净。
  • 9 个定向 kernel 套件 48/48 通过(blocked-status-ranges、report-accounting、ranges-consistency、reversed-ranges、status-surface-meta、range-coverage、recommend-range-integrity、report-truncation、report-tool-accounting);9 个新测试与 issue 验收矩阵一一对应。

CI: 当前 head 4e39b71 上 30 项 check 运行中,0 失败、14 pending(镜像 09:02Z 抓取)。原 head 9c73677 上零 check 的异常已随新推送自行消解,无需在 #4599 记录。

线程状态: PR OPEN,mergeable_state=blocked(checks 进行中 + kernel 变更属 human-only 审核档,等人工 review/merge)。本单已纳入根因聚合 #6294,按 owner 口径(2026-11-12)聚合单只停机器人、不关闭——我不关闭,也不再推送,等人工合并。


八问

  1. 是什么问题:acp_status 未压缩区间视图把策略保护消息的 BLOCKED 哨兵渲染成候选行端点,产出 BLOCKED–m02518 ⚠ not foldable: refs unresolvable 这类假行加误导性警告。
  2. 什么原因导致的:report 层 renderUncompressedRanges 直接取 group 首/末条目当候选端点,缺 BLOCKED 守卫;recommend 层早已在 base-set 级筛掉 BLOCKED,两视图违反 identical-segmentation 契约。纯 report 层守卫缺失,apply 路径不受影响(与 reporter「有效区间压缩正常」的观察一致)。
  3. 影响范围与严重程度:仅 acp_status 展示层——用户看到假候选行和错误诊断;实际压缩行为不受影响。体验/诊断瑕疵级(p2)。
  4. 怎么修复的:展示层守卫——BLOCKED 收进聚合统计行;候选行按位置跨正常成员;全保护 group 给显式说明;flagFor 打真实投影错误(截断 100 字符)。不动 apply/recommend/segmentation。
  5. 是否有回归问题:无。既有行为逐项过:header 总量与逐消息计数不变;宿主消费者只匹配稳定 header 串;recommend/apply 路径未触碰;9 个既有 report/ranges 套件在合并树上全绿。
  6. 是否破坏缓存:不涉及——无缓存/重试/游标/去重逻辑变更。
  7. 是否改了设计方向:不涉及——仅展示层守卫,无架构变更。
  8. 是否引入了新的配置:不涉及。

收工判定:代码正确、分支状态正确(已验证)、CI 运行中无失败;待人工 review/merge(kernel 变更 human-only 档),机器人侧无待办。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

状态确认(已实时核验):PR 仍 OPEN,head 4e39b71 未合并;CI 30 项 check 已全部完成、0 失败(镜像 09:48Z 抓取,head 自推送后未变);分支现为 behind——master 已前进,属正常漂移,非 CI 问题。机器人侧无新动作:按聚合线程口径等人工 review/merge,根因修复落地后由你手动关闭或在本单回复「close」。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

此条与上一条自动化通知(05:25Z)同一状态,刚已实时核验过:PR OPEN、head 4e39b71、CI 30/30 全绿、分支 behind(master 漂移)。无新动作,继续等人工 review/merge。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

本批 5 条(06:15Z–06:32Z)均为同一自动化更正通知的重复投递,内容一致,合并确认一次:已实时核验,PR OPEN、head 4e39b71、CI 30/30 全绿、分支 behind(master 漂移)。机器人工作保持停止,等人工 review/merge;此后同类重复通知不再逐条回复。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

本轮收尾说明:本次唤醒收到的是一条重复投递的自动化更正通知(与 06:15Z–06:32Z 批次同文)。已实时核验状态无变化——PR OPEN、head 4e39b71、CI 30/30 全绿、分支 behind(master 漂移,非 CI 问题)。无新工作、无新推送;机器人工作保持停止,待人工 review/merge,根因修复落地后由你手动关闭或回复「close」。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

两条均为已确认批次的重复投递(06:26Z/06:29Z),无新信息、无状态变化,不重复核验;结论以本线程最近两条 bot 确认为准,继续等人工 review/merge。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

06:32Z 一条,为该重复系列(06:15Z–06:32Z)最后一项,无新信息;结论不变,等人工 review/merge。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

重复投递仍在继续(新时间戳 06:38Z/06:42Z,内容同前),无新信息、无状态变化。若持续出现,建议查一下上游同步侧的转发动作;本线程结论不变,等人工 review/merge。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

同文重复投递(06:42Z),无新信息;结论以本线程 bot 确认为准,等人工 review/merge。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

这条与前面数条是同一条自动化更正通知的重复投递(带 upstream-sync 标记,内容逐字相同,仅时间戳递增)。刚又实时核验:PR OPEN、head 4e39b71、CI 30/30 全绿、分支 behind,状态无变化。

真正需要处理的是同步侧重复转发这一条——它每转一次就唤醒我一次,我只能逐条回确认,等于在本线程持续刷噪音。我无法修平台同步逻辑,请你在同步侧停掉这条的循环转发(或确认要我继续逐条确认)。PR 本身结论不变,等人工 review/merge。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷
(ai: vllm-qwen/qwen3.8-27b)

同文重复投递仍在继续,无新信息;已请你在同步侧停掉循环转发,结论不变,等人工 review/merge。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] (ai: vllm-qwen/qwen3.8-27b) 冲突已再次清除并推送。本轮做的事:master 在 11-12 之后又前进了 300 个提交(含 batch4 kernel 修复与 #6709),PR 分支与基线再次失步(系统报 dirty;本次 live 核验时镜像态为 behind,两种状态同一处置——合入基线)。

八问:

  1. 是什么问题:PR [PR] EN | acp_status: stop recommending BLOCKED sentinel range endpoints (#6168) #6305 与 master 再次失步,版本字段冲突使 PR 无法合并。
  2. 什么原因导致的:master 期间合入多批 kernel 变更,kernel 版本从 PR 分支的 0.0.196 推进到 0.0.198;kernel/package.json、kernel/package-lock.json、根 package-lock.json 三处版本字段与 PR 分支撞车。
  3. 影响范围与严重程度:仅该 PR 的可合并性;不涉及任何已发布版本行为。
  4. 怎么修复的:最新 master(1ee510c528)合入 PR 分支;版本冲突取 0.0.199(master 的 0.0.198 + 本 PR 未合入的 kernel 变更增量),三处同步。report.ts 自动合并干净——master 的 Version 0.214: compression issues still persist. The problem of old blocks failing to compress remains unresolved. | 0.214版本,压缩依旧存在问题,旧块无法压缩问题依旧存在 #6709(content-free BLOCKED partners)与本 PR 的 BLOCKED 端点显示修复不在同一区域,无交叉。
  5. 是否有回归问题:无。合并树与 master 的 diff 恰好只剩 PR 自己的 5 个文件(report.ts + 新测试 + 3 个版本文件),零无关改动;已确认 master 没有独立修掉 [Codex CLI] Follow-up to #6167: Empirical Verification of Local BLOCKED Scope and Proposed Fix for Reserved Protection S | [Codex CLI] 补充 #6167:本机 BLOCKED 范围实证与保留保护语义的修复建议 #6168(master 的 report.ts 无 cleanProjectionError / protected 统计行,也无对应测试文件),PR 仍然必要。本地验证:typecheck + build 绿;定向 kernel 套件 116/116 绿(新套件 + 12 个 report/range/status-surface 套件)+ BLOCKED latch 套件 13/13 绿。上一 head 4e39b7197f 的 CI 按镜像缓存为 30/30 全绿、0 红。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:无。
  8. 是否引入了新的配置:无。

判定:新 head 03a2c5bde5 已推送,mergeable=True(blocked = 等新 CI 跑完 + 审批)。本次未做会话内守候——CI 若红由系统再次唤醒。

@ranxianglei ranxianglei left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ai: vllm-qwen/qwen3.8-27b)

Findings-only review — no approval (kernel gate). No blocking findings; the fix is verified correct.

This PR touches kernel/ and carries a kernel-change: declaration → human-only review tier; I post findings only, and the merge decision waits on the owner (see the 🔶 需要决策 thread comment).

Direction (issue #6168): confirmed. The repro (BLOCKED–m02518 ⚠ not foldable: refs unresolvable) is real and the root cause is verified at source: renderUncompressedRanges (kernel/src/report.ts) took each segmentGroups group's first/last entry verbatim as candidate endpoints, while collectVisible correctly keeps BLOCKED entries in visible for the totals; parseBoundary (kernel/src/boundaries.ts) returns null for "BLOCKED", so resolveBoundaries threw and the old catch flattened it to "refs unresolvable". The recommend side already screens BLOCKED out at base-set level (kernel/src/recommend.ts:333) — the report view violated the documented identical-segmentation contract. Fixing the display layer (not the apply path) is the right layer: apply was never affected, matching the reporter's observation that valid ranges compress fine.

Correctness (verified against the head tree, not just the diff):

  • Candidates now span the first..last NORMAL member positionally (no ref arithmetic; non-monotonic refs preserved via orderedRefPair); all-BLOCKED groups emit no candidate row; every BLOCKED entry lands exactly once in the protected: aggregate (invariant: candidate counts + protected = visible total).
  • Header totals and the per-message drilldown are byte-identical for the same state; sort/limit semantics untouched (the protected line is header-adjacent and limit-immune).
  • flagFor endpoints are now always resolvable numeric refs, so a throw is a genuine boundary/projection failure; cleanProjectionError (whitespace-collapsed, 100-char cap, empty → "projection failed") surfaces the real reason — strictly more informative, no new failure mode.
  • Host-side report parsers are safe: the two new lines are 2-space-indented and match the existing continuation grammar in src/marker/status-body.ts (/^ {2,}\S/) and src/acp-panel.ts (/^\s/); no new column-0 section start, so no parser list needs updating.
  • Regression sweep of existing behaviors on the touched path: header totals unchanged, compressed scope unchanged, recommend/apply/segmentation unchanged, startIndex (size-sort tie-break only) now references the first normal member — no ordering change for distinct token counts. One pre-existing nuance, unchanged by this PR and out of scope: a BLOCKED user message still splits a group in the report view (it stays a segment item) while recommend's base set excludes it (coarser grouping) — both resulting candidates are submittable and the PR strictly improves the previously broken row.
  • Kernel boundary: kernel-change: declaration present; version discipline satisfied — kernel 0.0.198 → 0.0.199 consistent across kernel/package.json, kernel/package-lock.json, and root package-lock.json in the final tree (the PR body's "0.0.193 → 0.0.194" wording predates the final rebase); mechanical-bug exemption properly invoked (reproducing regression test + declaration).

Tests: 9 new tests in kernel/tests/blocked-status-ranges.test.ts map 1:1 to the issue's acceptance matrix (leading/trailing/mid-group/all-BLOCKED, non-monotonic refs, genuine resolution failure, sort=time+limit, drilldown, normal-only regression guard); they assert on real rendered output with teeth (line formats, the count invariant, the "refs unresolvable" negation). Local targeted runs on this head: new suite 9/9, related kernel suites (ranges-consistency, recommend-range-integrity, reversed-ranges, status-surface-meta, range-coverage) 34/34, host tests/acp-status.test.ts 9/9, kernel typecheck + build clean. Full-suite verdict = CI (mirror: 0 failed at last fetch; test shards in flight).

Behavior changes — all three disclosed in the PR body, all verified in code: (1) no BLOCKED endpoints — protected content moves to the aggregate line; (2) an all-protected group renders the explicit "no candidate ranges" note; (3) genuinely failing projections print the real error (100-char cap) instead of "refs unresolvable".

Verdict: no blocking findings. Merge is gated on the owner's human-tier approval for the kernel change (kernel boundary rule 3).

八问

  1. 是什么问题:acp_status 未压缩区间视图把策略保护消息的 BLOCKED 哨兵渲染成候选行端点(BLOCKED–m02518),并配一刀切的 refs unresolvable 误诊——模型拿到的是永远提交不了的假候选。
  2. 什么原因导致的:report 层 renderUncompressedRanges 直接取 segment group 首/末条目当候选端点,缺 BLOCKED 守卫;recommend 层早在 base-set 级就筛掉 BLOCKED(recommend.ts:333),两视图违反 identical-segmentation 契约。纯 report 层守卫缺失,apply 路径不受影响。
  3. 影响范围与严重程度:仅 acp_status 展示层——用户/模型看到假候选行与错误诊断;实际压缩行为不受影响。体验/诊断瑕疵级(p2 档)。
  4. 怎么修复的:展示层守卫——BLOCKED 条目收进 header 下聚合统计行(总量口径不变);候选行按位置跨 group 内首..末正常成员(无 ref 算术);全保护 group 渲染显式说明;flagFor 打印真实投影错误(空白折叠、100 字符截断)。不动 apply/recommend/segmentation。
  5. 是否有回归问题:无。逐项过:header 总量与逐消息计数不变;drilldown 不变;sort/limit 语义不变;宿主两个报告解析器(status-body.ts / acp-panel.ts)的既有续行文法覆盖新行;recommend/apply 未触碰;既有 report/ranges 套件全绿。
  6. 是否破坏缓存:不涉及——无缓存/重试/游标/去重逻辑变更。
  7. 是否改了设计方向:不涉及——仅展示层守卫,无架构变更。
  8. 是否引入了新的配置:不涉及。

判定:代码正确、测试有牙、披露完整;因 kernel 变更属 human-only 审核档,本 review 仅作 findings 记录,不 approve——等 owner 人工批准。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策
(ai: vllm-qwen/qwen3.8-27b)

PR #6305(kernel 变更,human-only 审核档)——审核完成,等 owner 授权合并。

  • 门禁 diff:kernel/src/report.ts(BLOCKED 哨兵不再渲染为候选端点 + flagFor 真实错误显示,纯展示层)、kernel/tests/blocked-status-ranges.test.ts(新回归测试 9 例)、kernel 版本 0.0.198 → 0.0.199(三处版本文件一致)。
  • 审核结论:findings-only review 已提交(GitHub review,无阻塞发现)。修法为展示层守卫,apply/recommend/segmentation 语义零改动;三处行为变更均已在 PR 正文披露并经代码核验。本地验证:新套件 9/9 + 相关 kernel 套件 34/34 + 宿主 acp-status 套件 9/9 + kernel typecheck/build 绿;CI 镜像 0 失败。
  • 请 owner 批准(或指出需修改之处)。按 kernel boundary 规则 3,kernel 变更一律 human-only 合并,agent 不 approve、不 merge。

备注:needs-decision 标签未能打上——本工作区 tools/ 下没有 add-label.sh,镜像 API shim 也未实现 labels 端点(按 Problem Reporting 如实上报)。

review lane 一行汇报:PR #6305(head 03a2c5b)审核完成——findings-only、无阻塞发现、无顺手修、无新 issue;等 owner kernel 档批准。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] (ai: vllm-qwen/qwen3.8-27b) 冲突已第三次清除并推送。本轮:master 自 11-20 后又前进 286 个提交(kernel 版本 0.0.199→0.0.200,其中 #7252 的版本 bump 与本 PR 的 0.0.199 撞车、master 侧已自行 bump 到 0.0.200 解掉那次碰撞),PR 分支与基线再次失步。

八问:

  1. 是什么问题:PR [PR] EN | acp_status: stop recommending BLOCKED sentinel range endpoints (#6168) #6305 与 master 再次失步,三处 kernel 版本字段冲突,PR 无法合并。
  2. 什么原因导致的:master 期间合入多批 kernel 变更;本 PR 的 kernel 变更(report.ts + 测试)仍未合入,版本必须继续递增。
  3. 影响范围与严重程度:仅该 PR 的可合并性;不涉及任何已发布版本行为。
  4. 怎么修复的:最新 master(6453feeeb84)合入 PR 分支;版本冲突取 0.0.201(master 的 0.0.200 + 本 PR 增量),三处同步(kernel/package.json、kernel/package-lock.json、根 package-lock.json)。report.ts 自上次合并后 master 侧零改动,自动合并干净,PR 修复原样保留。
  5. 是否有回归问题:无。合并树与 master 的 diff 恰好只剩 PR 自己的 5 个文件,零无关改动。本地验证:typecheck + build 绿;定向 kernel 套件 120/120 绿(新套件 blocked-status-ranges + 12 个 report/range/status-surface 套件 + BLOCKED latch 套件)。上一 head 03a2c5bde5 的 CI 按镜像缓存为 30/30 全绿、0 红。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:无。
  8. 是否引入了新的配置:无。

流程说明:唤醒时已检查旧 head 提交信息,无 [ework:ci-held] 标记(无上一轮中途死亡残留);本次推送为本地验证完成后的最终 head,不带 CI-hold 标记,即本分支本轮唯一一次全量 CI。

判定:新 head ba00f797d04 已推送,mergeable=True(blocked = 等新 CI 跑完 + 审批)。不做会话内守候,CI 若红由系统再次唤醒。

@ranxianglei ranxianglei left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ai: vllm-qwen/qwen3.8-27b)

Re-review of new head ba00f79 — master sync only, substantive diff unchanged. Findings-only, no approval (kernel gate). No blocking findings.

The new head is a pure master sync (merge commit ba00f79; the PR's own commit remains 9c73677, unchanged). Verified on this head:

  • kernel/src/report.ts and kernel/tests/blocked-status-ranges.test.ts are byte-identical to the previously reviewed head (03a2c5b); the 3-dot diff vs master is the same 5 files with the same stats.
  • Master has not touched any affected path since the previous sync (kernel/src/report.ts, recommend.ts, segment.ts, boundaries.ts, src/marker/status-body.ts, src/acp-panel.ts, src/acp-status.ts).
  • Kernel version: 0.0.199 → 0.0.201 (collision with master's 0.0.200 resolved in the merge commit), consistent across kernel/package.json, kernel/package-lock.json, and root package-lock.json — version discipline satisfied.
  • Targeted suites re-run on this head: new suite + related kernel suites 34/34, host tests/acp-status.test.ts 9/9, kernel build clean. CI mirror: 0 failed (test shards in flight).

All conclusions of the previous review (id 5909661389) carry over: the fix is a display-layer guard, apply/recommend/segmentation untouched, all three behavior changes disclosed in the PR body, tests assert on real rendered output with teeth.

八问

  1. 是什么问题:同前一轮——acp_status 未压缩区间视图把 BLOCKED 哨兵渲染成候选端点并配 "refs unresolvable" 误诊。
  2. 什么原因导致的:同前一轮——report 层直接取 group 首/末条目当候选端点、缺 BLOCKED 守卫;recommend 层早在 base-set 级就筛掉 BLOCKED。
  3. 影响范围与严重程度:同前一轮——仅展示层,压缩行为不受影响,体验/诊断瑕疵级。
  4. 怎么修复的:同前一轮——展示层守卫(BLOCKED 收进聚合统计行 + 候选行按位置跨正常成员 + 全保护 group 显式说明 + flagFor 打印真实错误)。
  5. 是否有回归问题:无。本轮额外核验:新 head 为纯 master 同步、PR 文件逐字节不变、master 未触碰受影响路径、版本冲突已解为 0.0.201(三处一致)、受影响套件全绿。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及。
  8. 是否引入了新的配置:不涉及。

判定:新 head 仅 master 同步,实质内容不变,重验全绿;结论与前一轮相同——findings-only、不 approve,等 owner kernel 档人工批准。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

复审核完成(新 head ba00f79):新 head 为纯 master 同步(PR 自身 commit 仍只有 9c73677),实质 diff 与上一 head 逐字节一致,master 未触碰任何受影响路径;kernel 版本冲突已解为 0.0.201(三处版本文件一致)。新 head 上重跑定向套件:kernel 34/34 + 宿主 acp-status 9/9 + build 绿;CI 镜像 0 失败(shards 运行中)。

结论不变:findings-only、无阻塞发现、无顺手修、无新 issue——等 owner kernel 档人工批准(见前一条 🔶 需要决策 评论 + GitHub review id 5979784640)。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codex p2 scope/kernel

Projects

None yet

1 participant