Repository navigation
[PR] DSH top bar tab default name changed to billion-context (no longer conflicts with the "context" label used by plugins su | DSH 顶栏标签页默认名改为 billion-context(不再与 dsh-context 等插件的「上下文」重名) - #6272
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.9590-pr.6272.0862a55This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr6272.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 结论:docs-sync 已修好、CI 全绿,PR 可合并(等人工 merge)这个 PR 是 agent 之前开的,CI 工程师接手修了 docs-sync 红项后卡死重启了几轮(floor 5–14)。我重新核对了当前 live 状态,没有凭旧记忆作答: 当前状态(已 live 核实)
docs-sync 为什么红、怎么绿的:PR 第一笔 八问
判定可合并,等人工 merge(按规则我不能合 PR)。改动面 9 文件(7 文件 ±26 行 + 2 个 YAML 种子),纯展示层默认值 + 文档同步,无行为分支变化。 一个可选项:分支目前落后 master 90 提交(无冲突、核心文件无重叠,GitHub 合并时会自动带上 master 现状)。如果你希望我把分支 merge 到当前 master 再让 CI 对「PR 改动 × 最新 master」复验一遍,说一声我就做;不说的话就按现状交给你合并。 |
(ai: vllm-qwen/qwen3.8-27b) 进程被强制重启了,但任务在重启前已经完成——完整结论见上一条(八问版),这里只补一句状态确认,不重复全文:
无新增工作、无阻塞。一个可选项:分支落后 master 90 提交(无冲突、核心文件无重叠),如果你希望我把它 merge 到当前 master 再让 CI 对「PR 改动 × 最新 master」复验一遍,说一声就做;不说的话就按现状交给你合并。 |
(ai: vllm-qwen/qwen3.8-27b) Status: docs-sync already fixed on the current head — no push needed from this run. The reported
That commit moves the wording into the YAML seeds ( I re-verified live and locally:
So the failing check is already resolved by the existing branch content; there is nothing for me to fix or push. The new CI run is in progress (docs-sync queued, 11 checks pending). 结构化八问
判定:docs-sync 失败已由分支上的既有 commit 修复且本地验证通过;新 CI run(43301613445)进行中(docs-sync queued、11 项 pending、0 失败)。本轮无需 push,等待 CI 转绿即可。 |
334d86b to
a800cc8
Compare
(ai: vllm-qwen/qwen3.8-27b) Merge conflict resolved — PR #6272 is no longer What I did this run:
Live state now: 八问
判定:冲突已解决,PR 现为 |
(ai: vllm-qwen/qwen3.8-27b) No action needed — this event is stale. The merge conflict was already resolved in my previous run (a few minutes ago). Verified live just now:
The conflict fix (rebase + union-of-intent resolution of the |
Previously the conversation.view slot fell back to a localized built-in
("上下文"/"Context") when dsh.contextTabLabel was unset — the same name
dsh-context and friends use on co-installed machines, which is exactly
the collision #4237's rename knob exists for. The default display name
is now the product name "billion-context" (a name, not a word, so it
is deliberately not localized); a configured non-empty
dsh.contextTabLabel still wins. The default lives in the display layer
only (slot registration) — snapshot/config semantics are unchanged:
unset means the key is simply not carried.
…ync is seed-generated)
The docs-sync lane regenerates docs/configuration{,.zh-CN}.md,
website/main.js and website/docs/index.html from
website/config-reference/*.yaml and fails on drift — the previous
commit hand-edited the generated block. Move the wording into the
seeds (dsh.contextTab, dsh.contextTabLabel incl. default_zh,
BILI_DSH_CONTEXT_TAB) so the generator output is byte-identical.
(ai: vllm-qwen/qwen3.8-27b) 审核结论:APPROVE ✅改动正确、测试到位、文档一致。DSH 顶栏会话标签页的默认显示名从本地化「上下文」/「Context」改为产品名 (注:GitHub 禁止对自己账号的 PR 投 APPROVE review event,故以评论形式给出 APPROVE 判定。) 已顺手修: 八问
判定:可合(APPROVE)。改动小、正确,测试钉住了新默认名与「非空优先 / 留空回退 / 垃圾值回退」三条路径,文档三语一致。唯一的小不一致(label help 标题)已顺手修掉(commit 2d3ef5a)。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) PR #6272 审核收工 — APPROVE ✅(完整八问见上一条评论)
|
…nversation tab, not Context tab) The PR updated the cfg.q_dsh_ctxtab toggle heading to "conversation tab (default name billion-context)" but left the sibling cfg.q_dsh_ctxtab_label heading on the old "Context tab" / 「上下文」标签页 wording. Align the label heading so the two help strings describe the same tab consistently.
2d3ef5a to
d1f869a
Compare
(ai: vllm-qwen/qwen3.8-27b) Merge conflict resolved again — PR #6272 is no longer What I did this run:
Live state now: 八问
判定:冲突已解决且并发工作已并入,PR 现为 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) PR #6272 审核已完成(进程卡死重启后补报状态,不重复全文)。
收工判定:审核完成、APPROVE、无阻塞,等人工 merge。无新增工作。 |
这是啥问题?
DSH 会话页顶部我们注册的标签页,在没配置
dsh.contextTabLabel时显示的是内置名「上下文」/「Context」——而同机装了 dsh-context 等其他插件时,它们的标签页也恰好叫「上下文」,两个标签页撞名,用户分不清哪个是哪个。#4237 的改名开关(dsh.contextTabLabel)本来就为了解决这个冲突,但只有手动改名的机器才受益,默认机器照撞。根本原因
src/agent/dsh-native-client.ts槽位注册点:label: () => ctxGate.label ?? t("tab_ctx")——没配置时回退到本地化内置词条「上下文」/「Context」,而这个名字正是最容易和其他插件重名的通用词。怎么解决的
默认显示名直接改成产品名 "billion-context"(产品名不是词条,刻意不做本地化)。配置了非空的
dsh.contextTabLabel仍然生效(比如改成「压缩账本」)。默认只放在展示层(槽位注册点),配置/快照语义完全不变:没配置就是不携带contextTabLabel,knobs 与 Web 配置页「留空 = 未设置」的行为保持原样。同步面:
src/agent/dsh-native-client.ts:注册点改默认值,删掉 zh/en 两个tab_ctx词典键,注释更新src/knobs.ts/src/web/i18n.ts:dsh.contextTabLabel与dsh.contextTab的帮助文案(中英)docs/configuration.md+docs/configuration.zh-CN.md:dsh.contextTab/dsh.contextTabLabel/BILI_DSH_CONTEXT_TAB各行(中英)tests/dsh-settings-ui.test.ts:默认名断言与 [Feature] DSH: The top "Context" tab shares its name with another plugin. Could it be merged into the "Memory System" pa | [Feature] DSH:顶部「上下文」标签页与另一插件重名,能否并入「记忆系统」页 #4237 留空/非字符串回退断言改钉 "billion-context"CHANGELOG.md:[Unreleased] Changed能否合并?
能。 回归:
tests/dsh-settings-ui.test.ts(27 用例,含 #4237 命名覆盖/留空/非字符串三臂)+tests/dsh-native.test.ts共 103/103 全绿;tsc --noEmit干净;npm run build成功(dist-import-annotations / dist-external 零依赖守卫均 OK)。改动面 7 文件 ±26 行,纯展示层默认值,无行为分支变化,未配置机器刷新页面后标签页从「上下文」变成「billion-context」,配置过dsh.contextTabLabel的机器完全不受影响。CI 待跑。