Repository navigation
[PR] feat: POC — carry fold summaries as CCR placeholders (default-off) - #6125
ranxianglei wants to merge 4 commits into
Conversation
Proxy-mode weak models misread the user-voiced inline fold summary as the current question (#6025). This experimental, default-off path carries each rendered summary out as a deterministic `[acp-stored …]` placeholder and hands retrieval back to the model via acp_retrieve, so the summary can no longer be mistaken for live input. Host-only; no kernel change — every primitive already ships in acp-kernel. Gated by rollout feature `foldSummaryCcr` (percent:0 = off); force on with config `rollout.features.foldSummaryCcr:true` or env `BILI_ROLLOUT_FOLD_SUMMARY_CCR=1`. - src/server/fold-summary-ccr.ts: egress-view transform (never mutates state) - server/prepare-openai.ts: apply at egress + advertise acp_retrieve under flag - loop/core.ts, stream.ts, absorb.ts: service acp_retrieve when the flag is on - rollout.ts: register the default-off feature - tests/fold-summary-ccr.test.ts: on/off/idempotent assertions Experimental POC for #6111 — non-merging until owner reviews the data.
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.9166-pr.6125.192b618This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr6125.tgz
npm install -g packageInstall instructions are refreshed on each push. |
FoldSummaryCcrResult is referenced only inside its own file; the unused-exports gate flags it INTERNAL_ONLY and reds the PR (#6125). Drop the leading export per the gate's fix hint — no external consumer names the type.
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复,但存在同题并行 PR——GitHub #6120( This round: fixed the CI red, completed the review.
结构化八问
判定:CI 修复完成、PR 全绿,代码审查通过(POC 档)。按 PR 声明保持 hold——等 owner 审阅 A/B/C 实验数据后再谈合并;在那之前建议把 #6120 关掉收敛到本 PR 一条线。 |
|
POC反馈了一些问题,该方案还不成熟,需要在#6111 中继续讨论设计方案 |
(ai: vllm-qwen/qwen3.8-27b) 收到反馈:方案尚不成熟,设计讨论转到 #6111。已做的动作:
本线程我不再动代码——等 #6111 的设计结论。 |
…d (PR #6125 architecture-docs red)
…7-ci-engineer-r1 # Conflicts: # src/absorb.ts # src/server/prepare-openai.ts
(ai: vllm-qwen/qwen3.8-27b) Live state verified this run (mirror cache + single GH fetch): head What was done across these wakes (no earlier reply had been posted, so this covers all of it): Run 1 — red CI (
Run 2 — merge conflict (merge state dirty)
No design decisions were required, so nothing was parked for owner decision. 结构化八问(中文)
结论:两类阻塞均已解除(head |
(ai: vllm-qwen/qwen3.8-27b) Re-verified live this run — the reported "dirty" merge state is stale; nothing to fix:
No action taken this run (no push, no edits). The PR is merge-ready from CI's side; the remaining "behind" state is informational and will re-compute on the next base refresh — not something this lane chases. |
(ai: vllm-qwen/qwen3.8-27b) Re-verified live this run — the "dirty" report is stale again; nothing to fix:
No action taken this run (no push, no edits). This is the third identical stale event; the conflict was already resolved and CI is fully green at the current head. Process note: my previous session was force-restarted by the watchdog after 34 minutes of no output (it had gone idle after posting the last confirmation). No work was in flight, nothing lost — this run re-verified from live sources as above. |
What & why
POC for #6111 (root cause tracked in #6025): in proxy mode a weak model misreads the user-voiced inline fold summary as the current question → 答非所问. This experimental path carries each rendered summary out as a deterministic
[acp-stored …]CCR placeholder and hands retrieval back to the model viaacp_retrieve, so the summary can no longer be mistaken for live input.Host-only — no kernel change. Every primitive already ships in acp-kernel (
storeOriginal,buildStoredPlaceholder,applyRetrieve,refForRaw, …).Closes #6111
Config surface (owner-gated — declared per Configuration Surface Discipline)
Adds ONE rollout feature key, default OFF:
rollout.features.foldSummaryCcr={ percent: 0 }insrc/rollout.ts.rollout.features.foldSummaryCcr: trueor envBILI_ROLLOUT_FOLD_SUMMARY_CCR=1.ROLLOUT_FEATURESmap +featureEnabled()gate — no new top-level section.Wire / message-shape note (human review required)
Flag ON => proxy-mode egress replaces each rendered-summary message text with the placeholder (egress-view only; session state untouched) and advertises + services
acp_retrieveunder the flag even whenccr.enabledis false. Flag OFF => byte-identical to today (zero behavior change).Why this shape
storeCoveredOriginalsonly covers folded-away originals, not the surviving summary.Status
Experimental POC — non-merging until owner reviews the data. Targeted test
tests/fold-summary-ccr.test.ts(on/off/idempotent); full regression rides remote CI.