Skip to content

[PR] ci: master-CI convergence branch (sentinel-maintained, per #4599) - #6073

Merged
ranxianglei merged 1 commit into
masterfrom
ci-fixes
Nov 10, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
ci-fixes

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Persistent convergence point for all master-CI fixes, maintained by the #4599 sentinel per owner policy 2026-10-24. This PR stays open across incidents; master inherits fixes when merged.

Pending on this branch (vs master)

Coordination

All CI issues are tracked on #4599 — do not open new issues.

…him-dir semantics

The fixture probes a deterministic 2.x host (fakeOpencodeBin prints 2.4.0),
so since 09bda56 (#3976 via #6002) 'plugin install opencode' writes the
machine-local shim dir and migrates the seeded legacy bare entry; the old
bare-name expectation now fails on both OS runners. Assert the migrated
shim entry, its re-export content pointing at the installed dist root, and
the migration note. Fixes master-red on 541cf26 (hermetic registry e2e,
ubuntu+windows); coordinated on #4599.
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: ci-fixes (1f049c6)

Latest build — install this exact version

npm install -g billion-context@0.0.8868-pr.6073.62b2e19

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
1f049c6 billion-context@0.0.8868-pr.6073.62b2e19 build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr6073.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei ranxianglei changed the title ci: master-CI convergence branch (sentinel-maintained, per #4599) [PR] ci: master-CI convergence branch (sentinel-maintained, per #4599) Nov 10, 2026

@ranxianglei ranxianglei left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ai: vllm-qwen/qwen3.8-27b)

Review verdict: APPROVE(建议合并) — test-only assertion alignment, verified end-to-end including a negative control that reproduces the claimed master red.
(Submitted as a comment because GitHub forbids the author account from approving its own PR; the approve/merge click stays with you.)

Independent verification (not taken from the PR description):

  1. Mechanism trace. Since #6002 (#3976), applyOpencodePluginEntry (src/plugin-install.ts:1415) writes the machine-local shim dir for every 2.x host (useShim = !npmForm || key === "plugins", src/plugin-install.ts:1421), migrates any seeded legacy bare entry, and emits plugins -> <shimDir> (replaced billion-context) to stdout via console.log(pluginInstall(...)) (src/cli.ts:705). The fixture probes a deterministic 2.x host (fakeOpencodeBin prints 2.4.0; detectOpencodeMajor honors BILI_CLIENT_BIN, src/plugin-install.ts:1201), so key = "plugins" and the pre-PR assertions (["billion-context"] + /plugins present/) can never hold against current master. The red is assertion lag after a shipped semantic change — not a product defect.
  2. Negative control. Ran the BASE version of the test file against a build of this PR head (product code identical between base and head): fails exactly as claimed — deepEqual expected 'billion-context', actual <work>/config/opencode/plugins/billion-context. The master red reproduced locally at the base assertion line.
  3. Positive run. PR-head test file against the same build: hermetic registry e2e lane green (12 pass / 0 fail / 1 skip — the skip is the real-baseline phase gated by BILI_E2E_REAL_BASELINE, which CI sets). Pinned unit suite tests/plugin-install-opencode.test.ts: 20/20 green.
  4. Test validity (would it catch regressions?). Each facet is independently pinned: entry form (deepEqual on the exact shim path), compaction.auto (unchanged), shim byte content (exact re-export of the installed dist root, trailing newline included), stdout migration note (regex). A regression to bare-name-on-2.x, a stale shim root, or a missing legacy migration each trips a different assertion. Strictly stronger than the pre-PR assertions.
  5. CI state at head 1f049c6: fully green — 50 check runs, 37 success + 13 skipped, 0 failed. The hermetic registry e2e job is skipped on this PR head by three-layer CI design (#3295: the lane requires the ci:full label on PR events); it first executes on master via the 30-min cron after merge — which is exactly when the fix takes effect. The local runs above cover that gap pre-merge.
  6. Regression surface walked. Diff touches only tests/e2e/e2e-registry.test.ts (+13/−4): self-update chain assertions, npm -g install e2e, #1628 unwritable-dir/no-op phases, doctor-lane phase — all untouched. No product code, no kernel/, no config surface, no wire changes, no new env vars. Branch state matches the PR body (single commit vs master). No small findings to fix on the spot.

八问(中文,供人工复核):

  1. 是什么问题:master CI 的 hermetic registry e2e 自 #6002(#3976 opencode 2.x shim 入口)合入后常红——e2e 断言仍钉在 #3976 之前的裸包名入口,而产品已有意改为 2.x 宿主写机器本地 shim 目录。
  2. 什么原因导致的:断言滞后,不是产品缺陷——#6002 改了产品语义(2.x → shim 目录 + 旧裸条目迁移),该 e2e 断言未同步更新。
  3. 影响范围与严重程度:仅 CI 车道(测试文件),零用户面、零产品行为影响;严重度 = master CI 红(阻塞哨兵收敛流程、污染继承红判定)。
  4. 怎么修复的:把三条断言对齐 #3976 语义——plugins 入口 = shim 目录路径;shim index.js 字节级等于指向安装 dist 根的 re-export;stdout 匹配 plugins -> …(replaced billion-context)。纯测试改动,不动产品代码。
  5. 是否有回归问题:无。既有行为逐项清点:self-update 链断言、compaction.auto、npm -g install e2e、#1628 不可写目录/no-op 相位、doctor 车道相位全部原样保留;唯一变化是测试期望值本身,且新期望与产品当前有意语义一致(单测钉死 + 本地负向/正向双向实测)。
  6. 是否破坏缓存:不涉及(不触碰缓存/重试/增量游标/去重键)。
  7. 是否改了设计方向:不涉及——正是向已定型的 #3976 方向对齐测试。
  8. 是否引入了新的配置:不涉及。

判定:可合并。 本 PR 头 CI 全绿;被修车道按三层 CI 设计在合并后由 master 30 分钟 cron 首跑验证(已有本地实测兜底)。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 Review complete for this PR (upstream PR #6073, head 1f049c6) — verdict: APPROVE, mergeable.

What I did:

  • Read the PR body and the full diff (single commit, test-only: tests/e2e/e2e-registry.test.ts, +13/−4) and traced every new assertion line-by-line against the current implementation (applyOpencodePluginEntry / detectOpencodeMajor / pickPluginKey / opencodePluginDir in src/plugin-install.ts, stdout channel at src/cli.ts:705). All three new assertions match the shipped [Bug] Plugin fails to load under OpenCode 2.1.0: bare package name entry dist/index.js lacks a default export (Plugin mu | [Bug] OpenCode 2.1.0 下插件加载失败:裸包名入口 dist/index.js 没有默认导出(Plugin must export a default definition) #3976 semantics exactly.
  • Reproduced the claimed master red with a negative control: the pre-PR assertions fail against a build of this head exactly as described (expected the bare package name, got the machine-local shim dir). The red is assertion lag behind the shipped 2.x shim-dir behavior — not a product defect.
  • Ran the fixed lane locally at the PR head: hermetic registry e2e green (12 pass / 0 fail / 1 env-gated skip), pinned unit suite tests/plugin-install-opencode.test.ts 20/20.
  • Confirmed CI at head is fully green (37 success + 13 skipped, 0 failed). The hermetic-registry-e2e job is skipped on this PR head by the three-layer CI design (it requires the ci:full label on PR events) and will first execute on master via the 30-min cron after merge — the gap is covered pre-merge by the local runs above.
  • No kernel/ involvement, no behavior/config/wire changes, no small findings to fix on the spot, nothing left parked.

Where it's posted: the full review with the 8-question checklist is on the PR itself — #6073 (submitted as a comment: GitHub forbids the author account from approving its own PR, so the formal approve click stays with you). One-line status also reported on coordination issue #4599.

@ranxianglei
ranxianglei merged commit 4dea18e into master Nov 10, 2026
50 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.1161-master.4dea18e (rolling master tag).

npm install -g billion-context@0.0.1161-master.4dea18e  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant