Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/prefix-affinity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1213,18 +1213,18 @@ export class PrefixAffinityResolver {
// malformed list degrades the entry to exact-hash resolution.
let sketches: string[] | undefined;
if (hv === 2 && Array.isArray(e.sketches)) {
const valid = (e.sketches as unknown[]).filter(
(s): s is string => typeof s === "string" && /^[0-9a-f]{16}$/.test(s),
);
if (valid.length >= ALIGN_MIN_DEPTH) sketches = valid.slice(0, SKETCH_MAX_DEPTH);
const slots: unknown[] = Array.from(e.sketches);
if (slots.every((s): s is string => typeof s === "string" && /^[0-9a-f]{16}$/.test(s)) &&
slots.length >= ALIGN_MIN_DEPTH) sketches = slots.slice(0, SKETCH_MAX_DEPTH);
}
// #2265: user-role flags for the ownership-anchor gate — optional,
// malformed lists simply degrade the entry (no user anchor → the
// simhash rung skips it, exact-hash resolution still works).
let userFlags: boolean[] | undefined;
if (sketches !== undefined && Array.isArray(e.userFlags)) {
const validU = (e.userFlags as unknown[]).filter((u): u is boolean => typeof u === "boolean");
if (validU.length > 0) userFlags = validU.slice(-MAX_STORED_ITEMS);
const flags: unknown[] = Array.from(e.userFlags);
if (flags.every((u): u is boolean => typeof u === "boolean") &&
flags.length > 0) userFlags = flags.slice(-MAX_STORED_ITEMS);
}
const entry: ChainEntry = {
sessionId: e.sessionId,
Expand All @@ -1241,9 +1241,13 @@ export class PrefixAffinityResolver {
// #2807: optional tail-turn fragments for the append-continuation
// rung — hv2 only (a v1 entry's fragments were never noted),
// malformed lists degrade the entry to exact-ladder behavior.
// Whole-carrier validation like sketches/userFlags above: a
// filtered middle slot would shift later fragments onto the
// wrong source message.
if (hv === 2 && Array.isArray(e.tailFrags)) {
const validF = (e.tailFrags as unknown[]).filter((f): f is string => typeof f === "string" && /^[0-9a-f]{64}$/.test(f));
if (validF.length > 0) entry.tailFrags = validF.slice(0, MAX_TURN_FRAGS);
const frags: unknown[] = Array.from(e.tailFrags);
if (frags.every((f): f is string => typeof f === "string" && /^[0-9a-f]{64}$/.test(f)) &&
frags.length > 0) entry.tailFrags = frags.slice(0, MAX_TURN_FRAGS);
}
this.trackedChains.delete(entry.sessionId);
this.trackedChains.set(entry.sessionId, entry);
Expand Down
104 changes: 104 additions & 0 deletions tests/affinity-snapshot-position.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
import assert from "node:assert/strict";
import test from "node:test";
import { PrefixAffinityResolver } from "../src/prefix-affinity.ts";

function seed() {
const messages = Array.from({ length: 16 }, (_, i) => ({
role: i % 2 === 0 ? "user" : "assistant",
content: `message ${i}: deployment analysis includes the latency profile and retry budget of service ${i}`,
}));
const resolver = new PrefixAffinityResolver();
const affinity = resolver.resolve(messages);
assert.ok(affinity);
resolver.note(affinity.sessionId, affinity.incomingDepth, affinity.tailHash, affinity.itemHashes, false, affinity.sketches, affinity.userFlags);
const snapshot = resolver.exportSnapshot()[0]!;
assert.equal(snapshot.sketches?.length, 16);
assert.equal(snapshot.userFlags?.length, 16);
return { messages, snapshot };
}

test("a malformed middle sketch degrades the carrier without shifting positions", () => {
const { messages, snapshot } = seed();
const sketches: unknown[] = [...snapshot.sketches!];
sketches[4] = null;
const restored = new PrefixAffinityResolver();
assert.equal(restored.importSnapshot([{ ...snapshot, sketches }]), 1);
assert.equal(restored.exportSnapshot()[0]!.sketches, undefined);
assert.equal(restored.exportSnapshot()[0]!.userFlags, undefined);
const replay = restored.resolve(messages);
assert.ok(replay);
assert.equal(replay.sessionId, snapshot.sessionId);
assert.equal(replay.via, "prefix");
});

test("a malformed middle role flag drops flags instead of moving later anchors", () => {
const { snapshot } = seed();
const userFlags: unknown[] = [...snapshot.userFlags!];
userFlags[3] = "invalid";
const restored = new PrefixAffinityResolver();
assert.equal(restored.importSnapshot([{ ...snapshot, userFlags }]), 1);
const actual = restored.exportSnapshot()[0]!;
assert.deepEqual(actual.sketches, snapshot.sketches);
assert.equal(actual.userFlags, undefined);
});

test("valid positional carriers round-trip unchanged", () => {
const { snapshot } = seed();
const restored = new PrefixAffinityResolver();
assert.equal(restored.importSnapshot([snapshot]), 1);
assert.deepEqual(restored.exportSnapshot(), [snapshot]);
});

test("sparse positional carriers are rejected without skipping their holes", () => {
const { snapshot } = seed();
const sketches = [...snapshot.sketches!];
delete sketches[4];
const restored = new PrefixAffinityResolver();
restored.importSnapshot([{ ...snapshot, sketches }]);
assert.equal(restored.exportSnapshot()[0]!.sketches, undefined);

const userFlags = [...snapshot.userFlags!];
delete userFlags[3];
restored.importSnapshot([{ ...snapshot, userFlags }]);
assert.deepEqual(restored.exportSnapshot()[0]!.sketches, snapshot.sketches);
assert.equal(restored.exportSnapshot()[0]!.userFlags, undefined);
});

function seedWithTailFrags() {
const messages = [
...Array.from({ length: 16 }, (_, i) => ({
role: i % 2 === 0 ? "user" : "assistant",
content: `message ${i}: deployment analysis includes the latency profile and retry budget of service ${i}`,
})),
{ role: "assistant", content: "follow-up note on the retry budget for service 9" },
];
const resolver = new PrefixAffinityResolver();
const affinity = resolver.resolve(messages);
assert.ok(affinity);
const fp = resolver.chainFingerprint(messages);
assert.ok(fp && fp.tailFrags && fp.tailFrags.length >= 2);
resolver.note(affinity.sessionId, affinity.incomingDepth, affinity.tailHash, affinity.itemHashes, false, affinity.sketches, affinity.userFlags, undefined, fp.tailFrags);
const snapshot = resolver.exportSnapshot()[0]!;
assert.ok(snapshot.tailFrags && snapshot.tailFrags.length >= 2);
return { messages, snapshot };
}

test("a malformed middle tail fragment degrades the carrier without shifting positions", () => {
const { messages, snapshot } = seedWithTailFrags();
const tailFrags: unknown[] = [...snapshot.tailFrags!];
tailFrags[1] = null;
const restored = new PrefixAffinityResolver();
assert.equal(restored.importSnapshot([{ ...snapshot, tailFrags }]), 1);
assert.equal(restored.exportSnapshot()[0]!.tailFrags, undefined);
const replay = restored.resolve(messages);
assert.ok(replay);
assert.equal(replay.sessionId, snapshot.sessionId);
assert.equal(replay.via, "prefix");
});

test("valid tail fragments round-trip unchanged", () => {
const { snapshot } = seedWithTailFrags();
const restored = new PrefixAffinityResolver();
assert.equal(restored.importSnapshot([snapshot]), 1);
assert.deepEqual(restored.exportSnapshot(), [snapshot]);
});
Loading