Repository navigation
[PR] fix: preserve position fingerprints when reaping damaged folds - #5954
mariopasquali wants to merge 1 commit into
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重 (duplicate screen): 不重复。 Searched all open PRs — #5954 is the only one targeting this mechanism (reap desyncing the Verdict: MERGEABLE. Clean root-cause fix, a regression test with real teeth (verified fails pre-fix / passes post-fix), no regressions in the affected area, CI green. Recommend approval + human merge (external contributor PR touching an identity-adjacent store ⇒ human-review tier regardless). What I verifiedThe bug is real and self-perpetuating. Traced the mechanism end-to-end:
The fix is correct. It splices The regression test has teeth (both directions verified). In an isolated checkout I ran the new
No regressions in the affected area. Ran the targeted fold-reconcile / positional / drift / order-centric / reap suites (120 tests) with the fix: all pass. Typecheck: clean. (Full-suite verdict left to CI per local-testing discipline.) CI on pushed head Scope/hygiene: 2 files only ( Known limitation (agreed with author, non-blocking)"This prevents new corruption; it does not repair existing historical metadata." Correct and honest. For sessions already desynced pre-fix: the structural misalignment self-heals on the first post-fix pass (the store is rewritten in lockstep at 结构化八问(PR 审核结论)
判定:可合入。 建议 approve + 人工合并(外部贡献者 PR 且触及身份相邻存储,本就落在人工评审档)。已知限制(历史已污染元数据不回填)作者已诚实披露、影响有界,不阻塞;如需回填另立后续,不塞进本 PR。 |
|
Landed via batch PR #6482 (merged) — closing as superseded. |
Removing a damaged fold shortened the saved position IDs without removing
their paired fingerprints. The following replay could then cache a fingerprint
under the wrong message ID.
This keeps both arrays aligned during removal. The regression checks actual
fold removal, each remaining fingerprint association, and the following replay.
It fails before the fix. After rebasing onto current master, all 73 reconciliation
tests, build and typecheck pass with an independent dependency install.
This prevents new corruption; it does not repair existing historical metadata.
Related architecture: #2480.
Fixes #5953.