Repository navigation
[PR] Review follow-ups: 429 throttle saturation/scope guardrails, media-refs carry-forward filter, oversize-refusal messages that say what to do, doc typo - #5905
Conversation
…d, media-refs carry-forward filter & cloud prefix families, oversize refusal messages that name the real fix, dsh durable lines with readable numbers, website streamKeepAliveMs typo, 5755 ord-crossing guard kept with regression tests - upstream-throttle: a saturated hold map (64/64 account-wide, no model-scoped hold to evict) silently dropped the next model-scoped 429 — now it warns once and the send is documented as ungoverned (#5199/#5889) - knobs: network.throttle429Scope matches its value EXACTLY; a typo now warns once and falls back to credential instead of silently doing so (#5199) - kernel media-refs: block summaries written by older builds can carry refs looksEphemeralSignedUrl would reject today; the carry-forward into merged blocks now applies the same filter so a dead signed URL cannot survive forever (#5865 review). EPHEMERAL_QUERY_PARAM also gains the Huawei OBS x-obs-*, Tencent COS x-cos-* and Baidu BCE x-bce-* prefix families. - native-intercept/dsh-native oversize refusals now say what to DO (restart host / fix the model window declaration), and dsh durable lines format numbers with thousands separators (#2924/#4068) - website: streamKeepaliveMs → streamKeepAliveMs (the real knob name) across main.js, docs/index.html, config-reference/process.yaml - CONFIGURATION.md/.zh-CN.md: throttle429Scope exact-match + model-string aliasing caveat documented - store/persist: #5755 refs ord-crossing guard (touching rows stay in the old-refs set until the new-refs commit lands) kept as defense-in-depth with a regression test kernel-change: 0.0.186 → 0.0.187 (media-refs carry-forward filter + cloud prefix families; compress.ts starvation-bound comment corrected)
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.8580-pr.5905.5456a28This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5905.tgz
npm install -g packageInstall instructions are refreshed on each push. |
…ss.yaml seed (CONFIGURATION.* are generated), kernel lockfile 0.0.187
[bot] 🏷 接单:PR #5905( 查重: 不重复——镜像 open [PR] 行里只有本条针对该主题(#5898 review follow-up 批次);无并列的第二个修复 PR。 开始按 PR Review 规范审(方向关 → 回归审查 → 代码 → 测试有效性 → diff 整洁度),含 kernel 部分(media-refs carry-forward filter)按 Kernel Boundary 人工级对待。结论稍后以结构化八问给出。 |
(ai: qwen/qwen3.8-27b) PR #5905 审核完成。分支 结构化八问
本地定向验证(全量矩阵归 CI):issue5199-throttle429-scope + issue5755-ord-crossing 9/9 · dsh-native 75/75 · kernel media-payload 25/25 · issue4204-governor + knobs-precedence + native-intercept + persist-active-pack 四文件合计 125/125 · native-intercept-selfheal 22/22。docs 同步: review 中顺手修的一处(已推 PR 分支,commit 补充说明两点:
CI 现状(镜像缓存实时读):30 项检查,0 失败,12 条 lane 在跑(含我推送触发的重跑),mergeable_state=blocked 仅因 checks 未完。目前零失败,全矩阵绿即收工。 判定:建议合并(kernel 部分待人工评审确认)。 |
(ai: qwen/qwen3.8-27b) CI 收工确认:全矩阵在推送头 |
…write, print evidence map on red Four hardening fixes from the #5904 forensics (gate red runs traced to environment degradation, but the tool itself hid that): 1. Preflight now sends ONE tiny real completion (8 tokens) after the /v1/models liveness check. Liveness 200s while the scheduler drowns; a probe miss now aborts with 'environment degraded, NOT a product red'. Budget: GATE_PREFLIGHT_BUDGET_MS (default 30000). 2. --base-dir pointing at a NON-EMPTY dir now refuses without --reuse-base-dir (a rerun used to silently overwrite the previous run's bili.log / dsh-*.jsonl — this destroyed the 16:36 green run's evidence). 3. On any red check the summary prints an evidence map (bili.log, proxy.log, dsh-t*.jsonl, bili.json) next to SCRATCH KEPT. 4. Turn 1 without a single cache report now WARNs 'upstream may be degraded — results may measure the environment, not the product' (the degraded 19:39 run showed exactly this signature).
|
追加一项 gate 工具加固( |
Resolve the single textual conflict in src/storage/store.ts, where both sides independently replaced the O(B^2) Array.some() stale-block sweep with an O(1) Set lookup (master via #5744, this branch via #5755). Kept master's incomingBlockIds form: behaviorally byte-identical, already shipped and reviewed on master, so the merged hunk matches what v0.1.213 already carries. All other files auto-merged cleanly.
(ai: vllm-qwen/qwen3.8-27b) 冲突已解决并推送。 上游 PR #5905( 这次做了什么(CI 工程师车道):
实时核验(非记忆): 你追加的 gate 加固( 结构化八问
收工判定:冲突已解决并推送,PR 现处可合并待评审/CI 状态(mergeable=true)。等 CI 全绿 + 人工批准(kernel 部分按 Kernel Boundary 留人工评审层,见 floor 4 审核结论)即可合入。CI 若有红我再跟进。 |
(ai: vllm-qwen/qwen3.8-27b) 本轮为重复触发——冲突上一轮已解决,本轮仅做实时核验,未做任何改动。 实时核验(非记忆,均为本轮实测):
为何本轮不动手:无冲突、无红项、master 未变。此时再跑 merge/rebase 只会得到 "Already up to date" 或制造一个空合并提交,属重复劳动/抢分支——按 push 纪律停手,只报状态。 归属与后续:等 CI 全绿(现 0 失败仍在跑)+ 人工批准(kernel 部分按 Kernel Boundary 留人工评审层)。若稍后 CI 出红,我来修;若再次收到同类「dirty」触发而实时仍为 blocked,一律以实时为准,不重做。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.1081-master.6df7ae1 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Follow-up batch from the v0.1.212..cda6e73 review (#5898) — every item below came out of that review or its verification probes. No behavior change beyond the two marked fix; the rest is guardrails, messages, docs and tests.
Fixes
x-obs-*, Tencent COSx-cos-*and Baidu BCEx-bce-*prefix families. Regression test: tests/media-payload.test.ts (carried-forward ephemeral drop).streamKeepaliveMs→streamKeepAliveMs, the actual knob name documented in CONFIGURATION.md.Guardrails & docs
network.throttle429Scopematches its value EXACTLY (credential/model, case-sensitive); an unrecognized value now warns once per distinct misspelling instead of silently falling back to credential (src/knobs.ts, 429 governor hold is keyed by origin+credential with no model dimension — one model's quota exhaustion freezes the whole lane (healthy models get local 429/424) #5199). CONFIGURATION.md / CONFIGURATION.zh-CN.md document both the exact-match rule and the model-string aliasing caveat (glm-5.2≠GLM-5.2).kernel-change: 0.0.186 → 0.0.187 (media-refs carry-forward filter + cloud prefix families)
Test evidence