Repository navigation
[PR] docs(kernel-boundary): add mechanical-bug exemption to Kernel Boundary rule 1 - #5822
ranxianglei wants to merge 2 commits into
Conversation
…y rule 1 At-a-glance mechanical kernel defects (wrong literal, typo, falsifiable guard predicate) may now be fixed directly without the pre-implementation dedicated-issue approval, provided the fixing PR (i) adds a regression test that fails on the buggy code and passes on the fix, (ii) names the bug in its kernel-change declaration, and (iii) reports in-thread what changed, why it is safe, and which test pins it. The human-only review tier still gates the merge; that approval is the required report. All other kernel rules unchanged. Refs #5819
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.8386-pr.5822.e3ae4c5This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5822.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 按主题(kernel-boundary 豁免 / mechanical-bug / kernel-change 审批)检索 open+closed issues 与 PRs(近 7 天为主):命中的只有本 PR(GitHub #5822)与其来源 issue #5819,无并行工作项。查重声明:无。 标签: scope/docs + p3(仓库规范/流程文档变更,不涉及任何客户端车道,最低严重度档) 独立审核进行中(不复读 issue 结论)。已核对的事实:
八问结论稍后给出。 |
…ng summary Review-side consistency fix for PR #5822: the §6 pre-change checklist still listed 'owner approval' unconditionally for kernel changes, which now contradicts rule 1's mechanical-bug exemption. Adds the parenthetical pointer so the summary matches the rule text.
(ai: vllm-qwen/qwen3.8-27b) 审核完成(独立审核,未复读 issue 结论)。判定:可合(待新 head CI 绿)。 独立核验过的事实:
结构化八问
收工判定:可合——等 984e68f 的 CI 全绿即可由 owner 合并(合并权在人,我不代合)。 |
ranxianglei
left a comment
There was a problem hiding this comment.
(ai: vllm-qwen/qwen3.8-27b)
结论:APPROVE(docs-only,可合) —— 以下为独立审核,非转述线程内既有评论。
独立核验(本轮重做的证据):
- diff 只动
AGENTS.md(+2/-2),basec3dfbe6b2== origin/master(fresh); .github/workflows/ci.yml:436-475(本 head 上逐行读):kernel-guard Rule 1 仅在 kernel/ 有变更(排除kernel/package-lock.json)时 grep PR body 的kernel-change:;Rule 2 是版本纪律。CI 不检查「事前审批 issue」是否存在 → 豁免条款无需任何 CI 改动,PR 正文 "No CI change" 声明属实;- 全仓
*.md一致性 grep(BEFORE implementation|dedicated issue|owner approval):旧版「一切 kernel 变更先批后做」表述无残留(剩余命中均为无关域:Configuration Surface 签核、release 批准、reference/external-summary.md); - #5819 存在且 open,标题与豁免语义一致(机械性 bug 直接修+线程内上报、合并仍人审),引用正确;
- 行为披露(Deliverables §4):PR 正文已给 Old→New(事前审批范围从全部 kernel 变更收窄到非机械性变更;机械性 bug 类免事前 issue,human-only review tier 仍 gate 合并)——披露合规。
八问:
- 是什么问题:流程粒度——Kernel Boundary rule 1 原要求任何 kernel/ 变更实现前都走 dedicated issue + owner 批准,一眼可证的机械性 bug(错字面量/typo/测试可证伪的守卫谓词)也被迫走全流程。
- 什么原因导致:政策颗粒度与缺陷严重度不匹配(流程设计问题,非代码缺陷)。
- 影响范围与严重程度:仅影响未来 kernel 修复的 agent 工作流(流程层);零运行时/用户面影响;属流程优化,无外部可见变化。
- 怎么修复的:rule 1 加「Mechanical-bug exemption (#5819)」条款,三条件钉死——(i) 回归测试在坏代码上红、修上绿;(ii)
kernel-change:声明里点名该 bug;(iii) 线程内报告改了什么/为何安全/哪个测试钉住;并显式重申 human-only review tier(rule 3)仍 gate 合并("that approval IS the required report, no separate sign-off");§6 Contributing 第 5 条加交叉引用。 - 是否有回归问题:审过——declaration 要求不变(kernel-guard CI 继续强制)、rule 2/3/4/5/6 未动、§7.4「any kernel/ change 保持人工」未动;除预期豁免外无语义漂移。
- 是否破坏缓存:不涉及。
- 是否改了设计方向:不涉及(无架构/数据流变化;与 owner policy 2026-11-06 对齐)。
- 是否引入新配置:无。
Check 状态:mirror cache 对 head 984e68f00 无缓存条目;单次 GitHub API 读取:46 runs = 21 success / 11 skipped / 14 queued,零失败(派发通知里的 head 8e0116949 已过时,当前 head 含上一轮 worker 补的 §6 交叉引用 commit)。
硬规则核对:PR 未触及 kernel/ 文件、body 无 kernel-change 声明 → 不触发授权门禁,可 approve。
(ai: vllm-qwen/qwen3.8-27b) 审查完成(review-worker-r1):APPROVE(可合) —— docs-only(AGENTS.md +2/-2,base fresh)。独立核验:kernel-guard CI 只 grep |
|
(ai: sglang-gpu0/qwen3.8-27b) |
…checklist (PR ranxianglei#5822, complements merged ranxianglei#5819)
Closes #5819
What
Adds a mechanical-bug exemption to Kernel Boundary rule 1 (
AGENTS.md). An at-a-glance kernel defect — a wrong literal, a typo, or a falsifiable guard predicate whose failure a test demonstrates — may now be fixed directly, without the pre-implementation dedicated-issue approval.Conditions (all required)
The fixing PR must:
kernel-change:declaration (CIkernel-guardstill enforces the declaration);What does NOT change
kernel-change:declaration requirement (CI-enforced) stays for every kernel PR.kernel-guardonly checks thekernel-change:string, which the exemption keeps.Process-behavior note (Deliverables §4)
Docs-only change — a single line in
AGENTS.md; no code, no config surface, no wire/persistence/kernel impact.