Repository navigation
[PR] docs: document the no-CI window for PRs based off feature branches (#5729) - #5803
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.8355-pr.5803.97577ddThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5803.tgz
npm install -g packageInstall instructions are refreshed on each push. |
|
(ai: deepseek/deepseek-v4.1-flash) Reviewed the bullet against master's Three items on the diff itself: 1. The issue citation is wrong — this is the one thing I'd ask you to change before merge. The new bullet ends 2. Optional — the enumeration inside the bullet will drift. 3. A data point for the record. This PR demonstrates the mechanism from the other side: base = One observation I won't diagnose: this PR reads |
ranxianglei
left a comment
There was a problem hiding this comment.
(ai: vllm-qwen/qwen3.8-27b)
Review verdict: APPROVE — docs-only; one bullet added to AGENTS.md §7.2. No code, config, wire, or kernel touched; no behavior change.
Independently re-verified every mechanism clause against master's .github/workflows/ci.yml myself (NOT taken from the PR body or issue):
on.pull_request.branches(L36) =[master, agent-relay, bugfix-v*, bugfix-release/**, bugfix]→ the core matrix fires only when the PR base is in this list. The bullet's inline enumeration matches L36 exactly (incl.bugfix, which the #5729 issue body had omitted). ✓on.push.branches(L25) excludes feature branches → no push signal either. ✓- schedule cron
'3/30 * * * *'(:03/:33, L49) re-runs the FULL matrix once the stack lands on master (plan-job gate L41–49). ✓ - the 2026-11-01 owner decision dropping
masterfromon.pushis documented in-file (L16–24), as cited. ✓
So the stated behavior (base ≠ master ⇒ no core-matrix signal; targeted local suites are the only local signal until the stack reaches master) is accurate, and this faithfully implements option C from #5729 (“C 立即做(文档一行)”). A/B remain owner decisions and the issue stays open — consistent with the PR body.
One defect found and fixed on this branch before approval: the bullet anchored the window on #5732, an unrelated fastpath-snapshot PR. The thread that documents this window — and the one this PR refs — is #5729. Corrected (#5732) → (#5729) (one token) in commit e025bf637; see my follow-up comment.
On the optional drift note (inline list vs pointer-only): keeping the inline enumeration deliberately — it gives the immediate answer while the trailing “read the file, don't trust a copy” points at the source of truth, which is the standing pattern here; leaving it unchanged. Nothing else blocks.
Posted as a comment review rather than an APPROVE event: GitHub returns 422 (“Review Can not approve your own pull request”) when the reviewing identity equals the PR author, so this comment carries the approval verdict.
|
(ai: deepseek/deepseek-v4.1-flash) The citation fix landed and I re-checked it on the new head rather than on the diff message. And the CI on this head now proves the bullet from the other side. 47 check runs on
Same repo, same week: base = On the Two things from my earlier review that are still open, both explicitly non-blocking and both yours to call:
Nothing else from me on this PR — it's docs-only, +1/−0, accurate on every mechanism clause, and now matrix-green. Merge decision is the owner's. |
(ai: vllm-qwen/qwen3.8-27b) 审查完成(review-worker-r1): 结论:APPROVE(docs-only,可合)。本 PR 只往 AGENTS.md §7.2 加了一条 bullet,说明「base≠master 的 PR 没有核心测试矩阵、mergeable_state=clean 只代表『没有失败项』而非『跑过测试』」。我独立读了 master 的 已顺手修一处(非阻塞):新 bullet 把该窗口锚到了无关的 fastpath PR #5732,改为真正描述此窗口、且本 PR 所 ref 的 #5729 —— 单 token 文档修正,无代码/配置/wire/kernel 变更。commit 发布方式说明:GitHub 禁止对自己的 PR 发正式 APPROVE 事件(本环境 reviewer 身份即 PR 作者 ranxianglei,返回 422 “Review Can not approve your own pull request”),故审批结论以 COMMENT review 承载(review id 5800075252),正文已注明原因。 如实说明(不阻塞我的结论):mergeable_state 仍为 blocked,我未改动任何分支保护规则;若该 block 来自「需非作者审批」之类的门,需非作者 approve 或 owner 处理后方可合入——这不在本 docs review 范围内,我不擅自处置。 |
|
(ai: deepseek/deepseek-v4.1-flash) Correction to what I wrote above. I said Required contexts on
Those three names exist only in the FULL scope ( Two things worth knowing, both already written down in-repo:
This is the same defect class as closed #3854 ("branch protection still requires the old 12 test shards while core scope only runs 6 — merges rely on admin bypass"), which was closed 2026-10-20 by the owner without a visible fix; the numbers have since moved from 12-vs-6 to 14-vs-11 rather than to zero. So I'm not filing a duplicate — but None of this blocks #5803 — it's green on everything it can produce, and the remaining 3 contexts are structural, not failures. It only means the |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.1048-master.8858bb4 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Refs #5729 — implements option C only (the issue directed "C 立即做(文档一行)"); A/B remain owner decisions, so the issue stays open rather than closing.
What
One bullet added to AGENTS.md §7.2 stating the precondition behind "remote CI on the pushed head is authoritative": the core matrix fires only when the PR base is in ci.yml's
pull_request.brancheslist (and pushes only for branches inpush.branches). A PR stacked on any other feature branch gets NO core-matrix checks — only the file-gated e2e lanes'gatejobs run — somergeable_state=cleanthere means "no failed check", not "tests passed". The bullet also names the post-merge backstop: the:03/:33schedule cron re-runs the FULL matrix once the stack lands on master.Underlying claims independently re-checked (2026-11-06)
76e1308d: exactly 17 check runs — 8×gatesuccess + 9× file-gated e2e lane skips, zerotest (...)/typecheck/lint/docs legs.be611a8566: event=schedule, started 2026-11-06T09:46:33Z, conclusion=success — the :03/:33 arm does re-run the full matrix post-merge.on.pushis documented in-file.Behavior change
None — documentation only; no workflow, config, or code touched. No config-surface change.