Repository navigation
[PR] EN | docs(#5630): correct the dsh subagent session-id claim — children mint fresh ids - #5633
ranxianglei wants to merge 1 commit into
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.8924-pr.5633.59ee64bThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5633.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复。按主题+失败签名(「dsh 子代理共享主会话 id」这一错误文档表述)检索了 open+closed 的 issue/PR,同主题的仅此 PR;相邻项机制与范围均不同:#5240(|sub: 命名空间不是 Claude 专属的文档)、#5473(dsh user-role 注入抢 last-user anchor)、#4774(claude code 无头子代理车道拆分)。 标签:dsh、scope/docs、p3(纯文档勘误——修正 dsh 车道的既有错误陈述,零代码变更,影响面极小)。 审核进行中,已独立完成的核查:
CI 状态与完整八问结论随后补报。 |
(ai: vllm-qwen/qwen3.8-27b) 审核结论:可合(待 CI 全绿,预计分钟级)纯文档勘误。我独立复核了源码证据、残留扫描、与当前 master 的交互、CI 状态,均无问题。单 commit / 4 文件 / 7 行,每一行都服务于本 PR 目的,diff 干净。 独立验证(不依赖 issue 结论):拉取 deepseek-harness @ 结构化八问
master 漂移核查:分支基点后 master 前进了若干 commit(notice surface、kiro lane、magpie 修复等,其中两个 README 有无关新增),但 4 处被修正句子在 master 上逐字未变,GitHub mergeable=true 无冲突,无需 rebase。 CI(镜像缓存读取):30 项 check——docs-coverage / kernel-guard / pi-subagents-guard / lock-sync / version-guard / mysql-contract 已绿,real-client e2e 各道按惯例 skip;13 个 test 分片 queued/in-progress,目前 0 失败。零代码变更,预期平凡转绿;若 CI 异常我再跟进。 收工判定:可合。 |
3a750b8 to
8fdb040
Compare
(ai: vllm-qwen/qwen3.8-27b) Merge conflict resolved and pushed. This run I rebased the PR branch onto current master, resolved all four conflicting files, and force-pushed (lease-guarded) to Why it was dirty: master moved How I resolved it — kept the PR's intent (correcting the "dsh mints a fresh session id per subagent spawn" claim) but landed it where the content actually lives now:
Final diff is a single commit, 4 files, +7/-5 — identical scale to the original PR, original commit message preserved. CI will re-run on the new head; I have not yet observed those fresh results this run, so I'm not asserting green/red. 结构化八问(中文):
判定:merge conflict 已解决并推送,PR 现在干净地落在当前 master 之上,可进入正常 CI → 人工合并流程。 |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Done — merge conflict resolved and pushed. Full structured verdict (English + 中文八问) is the comment directly above this one; short recap here so the thread ends clean:
判定:冲突已解决并推送,PR 干净地落在当前 master 之上,可进入正常 CI → 人工合并。无遗留决策项。 |
[ework] CI fix verified green ✓ |
(ai: vllm-qwen/qwen3.8-27b) Re-review of current head
Why it's still "awaiting review": a formal 结构化八问(中文)
判定: 当前 head |
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Review-worker-r1 complete — PR #5633 (head Done & verified (independent, not adopted from prior floors):
One blocker (out of agent control): GitHub rejects approving one's own PR — the only available credential is the author's ( 结构化八问(中文)
判定: 当前 head |
Refs #5630
What and why
#5630 independently verified the deepseek-harness source (@ tag
dsh-v0.2.2-alpha.3, master HEAD8bd073392e) and confirmed that every real dsh subagent spawn mints its own fresh session id:packages/subagent/subagent-dsh-sdk/src/run.ts:296—childSessionId = \session-${randomUUID().replaceAll('-','')}``packages/subagent/subagent-codex/src/run.ts:432,subagent-acp/src/run.ts:341,subagent-claude-code/src/run.ts:572— barerandomUUID()Four doc passages still said the opposite for dsh ("claude/codex/dsh … share one session id across subagents or have no child-session concept at all"). The corrected statement keeps the original CONCLUSION (these lanes need no derivedFrom lineage signal here) but fixes dsh's REASON: claude/codex stamp the main id on child requests (separated by other proxy signals), while dsh children are already isolated by their own fresh ids.
Files:
README.md,README.zh-CN.md,SESSION-IDENTITY.md,SESSION-IDENTITY.zh-CN.md(one sentence each).Behavior change disclosure
None — documentation only, zero code change.
Tests
Docs-only PR; no test surface touched.