Skip to content

[PR] feat: unified announcement surface — built-in registry + single renderer (lane A, #5548 P1) - #5557

Closed
ranxianglei wants to merge 2 commits into
masterfrom
2026-11-02_notices-registry-p1
Closed

ranxianglei wants to merge 2 commits into
masterfrom
2026-11-02_notices-registry-p1

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

(ai: vllm-qwen/qwen3.8-27b)

Part of #5548(已批准的统一公告面设计,四期中的第一期;P2/P3/P4 各自后续 PR,本 PR 不关闭该 issue)。

是什么

面板上现有两条通知(pck-default-off #5079、wm-fastpath-intro #5469)各自手写五处:后端字段、i18n 中英文、HTML 模板函数、渲染绑定、页面 div。加一条通知要复制五份文件改动,文案与行为散在两层。本期把内置通知收敛成一张注册表 + 一套渲染循环,为「内置 / 本地 JSON / 远程 raw」三来源统一渲染器打地基。

修法

  • 新增 src/notices.ts:公告记录 schema(id/kind/tone/title/desc/hint/cta/dismiss/priority/publishedAt,多语言文案对象或纯字符串)、内置声明表 BUILTIN_NOTICES(两条既有横幅原样迁入,active 谓词与显示条件逐字保留)、kind→priority 默认表(incident 90 > upgrade-advisory 80 > warning 70 > deprecation 60 > suggestion 50 > new-feature 40 > other 30)、tone 派生规则(可被记录显式覆盖)、dismiss 三模式(persistent / instance / always)、稳定排序(priority 降序 → publishedAt 降序)。
  • src/server/admin.ts:overview payload 的 pckNotice/wmNotice 两个专用字段合并为统一的 notices 数组;新增 GET /__bili/notices 独立端点(同一构建器)。
  • src/web/client.ts:删除两个手抄的模板函数与两段渲染绑定,换成单一 renderAnnouncementBanners()——createElement 树 + textContent 注入(外部数据零 innerHTML),头部最多 5 条横幅,超出进页面底部「公告列表」卡片;always 模式不渲染关闭按钮;cta 按钮仅在 label+url 同时存在时渲染。
  • src/pck-notice.ts 瘦身:只保留 dismiss 存储读写(路径、文件格式、POST 端点语义全部不变)+ pckNoticeActive()(acp-status 与启动日志仍在用);id 常量改从 notices.ts 再导出;允许名单从写死两 id 扩为注册表(P2 本地 JSON 的 id 届时经 registerDynamicNoticeIds 自动纳入)。
  • i18n:banner 正文文案随记录走(不再占目录),目录只留三个动作词键 notices.dismiss_btn/dismissed/list_title(zh/en)。

行为变更披露(旧 → 新 + 原因)

  1. /__bili/overview payload:移除 pckNotice: {id, active} 与 wmNotice: {id, active} 两个对象,新增 notices: [记录…] 数组。原因:统一公告面的核心结构变更;同仓客户端已同步更新。该 payload 是 bili 自家面板 API,无已知第三方消费者;若有外部脚本解析旧字段需适配新数组。
  2. 新增端点 GET /__bili/notices(纯增量)。
  3. 前端按钮 class pck-notice-dismiss/wm-notice-dismiss → 统一 notice-dismiss(grep 确认无 CSS/测试依赖旧名)。
  4. i18n 目录:删 pckoff.*/wmfast.* 共 20 个键,增 notices.* 3 个动作词键;横幅正文从目录迁至 src/notices.ts 记录内(中英逐字核对过原文)。
  5. 用户可见行为零变化:两条横幅的显示条件、文案、色调(.warn/.ok)、关闭语义与存储文件全部保持。

八问

  1. 是什么问题:面板通知没有注册表层——每条通知靠五处复制粘贴落地,加一条改五个文件,文案与判定逻辑散落两层,无法承载三来源统一渲染的设计目标。
  2. 什么原因导致的:第一条通知([PR] fix(dsh): carry the thrown error's bounded stack into the gate refusal logs (#5067 option A) #5079)以最小改动直接落位(后端字段+i18n+模板各一处),第二条([PR] fix(dsh): plugin lane no longer re-parses and re-sends full history every round — watermark fast path only parses the ne | fix(dsh): 插件车道不再每轮全文重解析重发历史 — 水位快路径只解析新增尾巴(#5403 OOM 生产者) #5469)复制了同一模式;抽象层始终没补上。
  3. 影响范围与严重程度:内部实现重构;对外仅 overview payload 形状变化(见上披露)。用户体验无变化——横幅外观/文案/交互逐字节保持。
  4. 怎么修复的:单一注册表(schema + 谓词 + 排序纯函数)+ 服务端一个构建器出口 + 客户端一套 createElement/textContent 渲染循环;显示条件原样搬进 active 谓词,dismiss 存储契约不动。
  5. 是否有回归问题:逐项审过——① 两条横幅显示条件(routing=="disabled" / 无显式 rollout 覆盖)由谓词矩阵测试钉住;② dismiss 存储(文件路径、JSON 格式、幂等、未知 id 拒绝)由 issue5079/wm-fastpath-intro 两个既有回归套件钉住且全绿;③ i18n 目录双向 parity 测试全绿(删 20 增 3,引用齐平);④ acp-status 行与启动日志仍走 pckNoticeActive(),签名未动;⑤ 无 fail-fast 变吞错、无阈值/时序/输出格式漂移(横幅 DOM 结构与 class 保持)。
  6. 是否破坏缓存:不涉及(无缓存/重试/游标/去重键参与)。
  7. 是否改了设计方向:没有转向——这是已批准设计(Unified Announcement Panel Design (Approved): Built-in declarations + local JSON + remote GitHub raw — a single renderer | 公告面统一设计(已批准):内置声明 + 本地 JSON + 远程 GitHub raw,三来源一套渲染器 #5548 §4/§七)的执行第一步,建立三来源共用的记录 schema 与单渲染器;本地 JSON(P2)、远程 raw + CI 门禁(P3)、文档(P4)按既定方案跟进。
  8. 是否引入了新的配置:无(BILI_ANNOUNCEMENTS_URL 属 P3,届时按 env-var discipline 补 CONFIGURATION.md 中英)。

验收证据(P1 退出标准)

  • 「第 4 条内置横幅 = 10 行 diff」:向 BUILTIN_NOTICES 追加一条记录即可(~10 行),其余文件零改动——本期两条记录本身就是示范。
  • 定向测试全绿:tests/notices-registry.test.ts(7 例:表完整性/谓词矩阵/dismiss 三模式/priority 表/tone 派生/排序稳定性/允许名单+可见集 wire 形状)、tests/web-notices-banner.test.ts(8 例:真实 WEB_CLIENT vm 驱动——基础渲染/always 无按钮/cta 双向/5+2 溢出/空列表/locale 回退/XSS 惰性文本/dismiss POST+重取);回归守护 tests/issue5079-pck-default-off.test.ts(9 例)、tests/wm-fastpath-intro-notice.test.ts(4 例)、tests/web-i18n.test.ts(11 例)全绿。typecheck + build 通过;全量回归交 CI。
  • 无 kernel 改动、无 wire 改动、无配置面改动。

…rer (lane A, #5548 P1)

Part of #5548 (approved unified announcement panel design, phase 1 of 4).

Converge the hand-copied panel banners (pck-default-off #5079, wm-fastpath-intro #5469) into one registry (src/notices.ts) with a shared record schema, kind-priority/tone/dismiss-mode pure functions, and one client render loop (textContent only, max 5 header banners + overflow list card). Overview payload now carries a unified notices array; new GET /__bili/notices endpoint. Dismissal store, endpoint and allowlist semantics preserved (allowlist widened to registered dynamic ids for lanes B/C). No config surface change.
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-11-02_notices-registry-p1 (1dda83e)

Latest build — install this exact version

npm install -g billion-context@0.0.7913-pr.5557.7e960a9

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
1dda83e billion-context@0.0.7913-pr.5557.7e960a9 build
3166877 billion-context@0.0.7906-pr.5557.69a77c9 build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr5557.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei ranxianglei changed the title feat: unified announcement surface — built-in registry + single renderer (lane A, #5548 P1) [PR] feat: unified announcement surface — built-in registry + single renderer (lane A, #5548 P1) Nov 2, 2026
Review fix for PR #5557: the unused-exports gate flagged 7 type-only
declarations (NoticeKind/NoticeTone/NoticeDismiss/NoticeText/BuiltInContext/
BuiltinNotice/VisibleNoticesOptions) that are referenced only inside
src/notices.ts. Per the gate's own guidance they get the leading 'export'
dropped (INTERNAL_ONLY), not a waiver — no other module imports them today,
and P2/P3 can re-export whichever types the dynamic lanes actually consume.

Zero behavior change: type-level surface only. Verified locally:
check-unused-exports.mjs clean, tsc --noEmit clean, targeted suites
(notices-registry, web-notices-banner, issue5079-pck-default-off,
wm-fastpath-intro-notice, web-i18n) 38/38 green.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策
(ai: vllm-qwen/qwen3.8-27b)

背景一句话:审核 #5557 时发现存在平行 PR #5554(早 24 分钟开出)——同一已批准设计阶段(#5548 P1 内置公告注册表 + 单一渲染器)的另一份实现,两者互斥,只能留一个。

待决问题:留 #5557 还是留 #5554?两者同文件集、同 overview payload 形状变更(pckNotice/wmNotice → notices[])、同新增端点 GET /__bili/notices,但都新建 src/notices.ts 且 schema 不同——先合的生效,后合的必然冲突作废。

选项(各带代价):

查重结论:重复——与 #5554 同范围平行实现(机制对比见上;因差异是真实的有意设计分歧而非误判,置信度不足 100%,按政策不关闭任何一个,交叉链接评论已发在 #5554 下)。
标签:pr(既有)+ scope/ui(面板/UI 面)+ p3(功能类,无缺陷)+ needs-decision(平行 PR 冲突待拍板)。


#5557 本 PR 的独立审核结论(已完成,不依赖作者自述)

八问

  1. 是什么问题:面板通知没有注册表层——每条通知靠五处复制粘贴落地(后端字段 / i18n 中英 / 模板函数 / 渲染绑定 / 页面 div),加一条改五个文件,文案与判定逻辑散落两层,无法承载三来源统一渲染的设计目标。
  2. 什么原因导致的:[PR] fix(dsh): carry the thrown error's bounded stack into the gate refusal logs (#5067 option A) #5079 第一条通知以最小改动直接落位,[PR] fix(dsh): plugin lane no longer re-parses and re-sends full history every round — watermark fast path only parses the ne | fix(dsh): 插件车道不再每轮全文重解析重发历史 — 水位快路径只解析新增尾巴(#5403 OOM 生产者) #5469 第二条复制了同一模式,抽象层一直没补。
  3. 影响范围与严重程度:内部重构,用户可见行为零变化。对外仅 overview payload 形状变化(移除两个对象、新增 notices 数组)——该 API 是 bili 自家面板接口,全仓 grep 确认消费者只有 src/web/client.ts 自身,无已知第三方消费者。
  4. 怎么修复的:单一纯函数注册表(schema + active 谓词 + kind→priority 表 + tone 派生 + 稳定排序)+ 服务端单一构建器出口(overview payload 与 GET /__bili/notices 共用)+ 客户端一套 createElement/textContent 渲染循环(零 innerHTML,头部 ≤5 条横幅,溢出进底部公告列表卡片);显示条件逐字搬进谓词,dismiss 存储契约不动。
  5. 是否有回归问题:逐项审过——① 两条横幅显示条件由谓词矩阵测试钉住(routing disabled/auto/enabled × override 有无);② dismiss 存储(路径/JSON 格式/幂等/未知 id 拒绝)由 issue5079 + wm-fastpath-intro 既有套件钉住且全绿;③ i18n parity 测试全绿(删 20 增 3,引用齐平);④ acp-status 行与启动日志仍走 pckNoticeActive(),签名语义未动;⑤ 新端点继承 handleAdminRoute 的 loopback+trusted-origin+anti-tunnel 门禁(已在派发点核实);⑥ 无 fail-fast 变吞错、无阈值/时序漂移,横幅 DOM 结构与 class 保持。遗留一项记入 P2 清单:ctaUrl 在 P1 无协议白名单校验——今天不可达(内置记录不带 cta 字段、无外部来源),但动态来源落地前 P2/P3 校验器必须强制 http(s)(设计 §4.2 已列)。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:没有——已批准设计 Unified Announcement Panel Design (Approved): Built-in declarations + local JSON + remote GitHub raw — a single renderer | 公告面统一设计(已批准):内置声明 + 本地 JSON + 远程 GitHub raw,三来源一套渲染器 #5548 的执行第一步,建立三来源共用的记录 schema 与单渲染器。
  8. 是否引入新配置:无(BILI_ANNOUNCEMENTS_URL 属 P3,届时按 env-var discipline 补 CONFIGURATION.md 中英)。

独立验证证据

  • 定向 5 套 38/38 绿(node --import tsx --test 顶层计数:notices-registry、web-notices-banner、issue5079-pck-default-off、wm-fastpath-intro-notice、web-i18n);
  • tsc --noEmit clean;
  • 我另写脚本从 master 提取被删的 20 个 i18n 字符串与新记录逐字段比对:12 个文案字段全部字节一致(「中英逐字核对过原文」独立确认);
  • 全仓零残留旧名引用(pckNotice/wmNotice/pck-notice-banner/wm-notice-banner/两个旧 dismiss class,覆盖 src/tests/website);
  • 测试有效性:两套新测试都是真行为测试——banner 套件在 vm 沙箱驱动真实 WEB_CLIENT 字符串,断言 class/text/DOM 结构/XSS 惰性(敌意文本零元素子节点)/dismiss POST body;registry 套件含双向负例(cross-set dismiss 不误伤)与 wire 形状断言(active 函数不泄漏进 payload)。无恒真断言。

CI 状态与已做修复

收工判定

代码面通过审核:方向正确、实现与批准设计一致、回归面钉住、测试有牙。合并前提:① 你对平行 PR 的拍板(推荐 A);② 新 head 重跑全绿。 feat 类 PR 无论结果如何都走人工合并(§7.4 auto-merge 排除 feat)。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

📌 CI 重跑更新(新 head 1dda83eb6):

  • 原唯一红项 unused-exports 已转绿 —— 分支内修复(去掉 src/notices.ts 中 7 个 INTERNAL_ONLY 类型导出,commit 1dda83eb6)经真实门禁验证生效;
  • 全量:30 项 failed 0;静态门禁全部通过(kernel-guard / lock-sync / config-surface-guard / version-guard / docs-sync / docs-coverage / lane-guard / lifecycle-ledger-guard / pi-subagents-guard / plan / gate×3 / unused-exports);14 条 e2e lane 按路径过滤照常 skip;
  • 仅剩 test-import-graph 一项最后一次读取时仍在运行(本 diff 未触碰任何 import,与该检查无关;若转红我会补报)。

代码侧已就绪。合并仍等你对 #5557 vs #5554 留哪个的拍板(见上一条评论的 🔶 需要决策)。

1 similar comment
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

📌 CI 重跑更新(新 head 1dda83eb6):

  • 原唯一红项 unused-exports 已转绿 —— 分支内修复(去掉 src/notices.ts 中 7 个 INTERNAL_ONLY 类型导出,commit 1dda83eb6)经真实门禁验证生效;
  • 全量:30 项 failed 0;静态门禁全部通过(kernel-guard / lock-sync / config-surface-guard / version-guard / docs-sync / docs-coverage / lane-guard / lifecycle-ledger-guard / pi-subagents-guard / plan / gate×3 / unused-exports);14 条 e2e lane 按路径过滤照常 skip;
  • 仅剩 test-import-graph 一项最后一次读取时仍在运行(本 diff 未触碰任何 import,与该检查无关;若转红我会补报)。

代码侧已就绪。合并仍等你对 #5557 vs #5554 留哪个的拍板(见上一条评论的 🔶 需要决策)。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策

Finding: this PR is fully superseded by master — the conflict is not mechanically resolvable into a meaningful mergeable result.

I rebased 2026-11-02_notices-registry-p1 onto current master to clear the dirty merge state. The conflict is not an ordinary "two sides edited the same lines" — it is two mutually-exclusive implementations of the same feature (#5548 P1) living in the same file, and master's side has since won and been built on top of.

Evidence:

  • Both sides added src/notices.ts with incompatible APIs. The PR exposes BUILTIN_NOTICES / visibleBuiltInNotices() / NoticeRecord; master exposes NOTICES / visibleNotices() / NoticeEntry. They cannot coexist in one file.
  • Master already ships the complete unified announcement surface, beyond what this PR targets:
    • #5548 P1 built-in registry → src/notices.ts
    • #5548 P2 local JSON announcements → src/announcements.ts
    • #5548 P3 remote GitHub-raw source → src/remote-notices.ts
    • unified dismissal storage (owner ruling 2026-11-03) → src/notice-store.ts
    • newer iot-thinking incompatibility warning (2026-11-09) → src/notices.ts + tests/iot-incompat-notice.test.ts
  • Master's surrounding code depends on master's API: src/announcements.ts:18 imports visibleNotices from ./notices.js; src/pck-notice.ts routes dismissal through ./notice-store.js. Taking the PR's notices.ts would break those imports.
  • Timeline: PR commit 31668771bd dated 2026-11-03 00:27; master's implementation merged 2026-11-03 10:09 (same day, ~10h later) and actively maintained through 2026-11-09. The PR lost the race.
  • Every "design v2" concept in the PR already exists on master — identical KIND_PRIORITY table, publishedAt sort tiebreak, versions/percent/since/until targeting, dismiss modes — all present in src/announcements.ts. Nothing unique remains.
  • The PR's test files import an API that does not exist on master (BUILTIN_NOTICES, sortNotices, toneOf, visibleBuiltInNotices); master covers the same ground with tests/notice-registry.test.ts, local-announcements.test.ts, remote-announcements.test.ts, etc.

Because resolving means choosing which of two incompatible designs wins for an already-shipped feature — and the natural outcome (close as redundant) is owner-only — I stopped rather than force a resolution. I pushed nothing; I aborted the rebase, so the branch is left clean at its original head (1dda83eb) for the next attempt.

Options:

  • A (recommended, default-if-undecided): Close [PR] feat: unified announcement surface — built-in registry + single renderer (lane A, #5548 P1) #5557 as superseded. Master already ships the complete feature plus newer work; nothing unique remains. (Agents can't close — needs you.)
  • B: Re-scope/rework the PR to add only genuinely-new value on top of master's design. I found no such gap today; would need a concrete new objective before any work.
  • C: Force the PR's pure-module "design v2" over master's registry. Not recommended — regresses master (loses iot-thinking warning, P2/P3 lanes, unified dismissal store) and breaks src/announcements.ts.

Default if undecided: A.


结构化八问(中文)

  1. 是什么问题:PR [PR] feat: unified announcement surface — built-in registry + single renderer (lane A, #5548 P1) #5557 想做的「统一公告面(Unified Announcement Panel Design (Approved): Built-in declarations + local JSON + remote GitHub raw — a single renderer | 公告面统一设计(已批准):内置声明 + 本地 JSON + 远程 GitHub raw,三来源一套渲染器 #5548 P1)」master 已经用另一套更完整的实现合入并持续维护,两边在同一文件里是互斥的两套设计,冲突无法机械消解成有意义的可合并结果。
  2. 什么原因导致的:同一 issue(Unified Announcement Panel Design (Approved): Built-in declarations + local JSON + remote GitHub raw — a single renderer | 公告面统一设计(已批准):内置声明 + 本地 JSON + 远程 GitHub raw,三来源一套渲染器 #5548 P1)被并行实现两次——PR 于 2026-11-03 00:27 提交,master 侧实现在同日 10:09 合入且更新(含 2026-11-09 的 iot-thinking 提示),PR 输掉竞争、已过期。
  3. 影响范围与严重程度:仅影响本 PR 本身,不影响线上/master;若强行合并会破坏 src/announcements.ts 等对 master API 的依赖,或使 PR 变成空操作。严重度=调度浪费(一个已被取代的 PR 占着 CI)。
  4. 怎么修复的:本轮未改代码——核实 master 已覆盖 PR 全部内容后判定属「需要决策」,按自动修车道规则停手;未 push、已 abort rebase,分支保持干净。
  5. 是否有回归问题:不涉及(未改动任何代码、未 push)。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及(未改动);待 owner 在 A/B/C 中拍板。
  8. 是否引入了新的配置:不涉及。

建议:A(关闭为已取代)。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

1 similar comment
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策

重复触发 · 本轮无新变化。 Same unresolved blocker re-fired. I re-verified live this run — nothing changed since my previous 需要决策 (floor 11):

  • PR head still 1dda83eb (no push since); mergeable_state still dirty; base master at 58a8796.
  • needs-decision label still applied (alongside pr / p3 / scope/ui).
  • No owner response yet to the pending decision.

There is still no mechanical fix: the conflict is two mutually-exclusive implementations of #5548 P1 inside src/notices.ts, and master already ships the complete feature (P1 built-in registry + P2 local JSON + P3 remote raw + iot-thinking warning). Resolving means choosing which incompatible design wins an already-shipped feature — an owner-only call, not a CI fix.

⚠️ Loop note: this PR keeps re-firing the CI-engineer lane (floors 9 / 10 / 15) purely because it stays dirty while waiting — every pass is a no-op that burns a scheduling slot. The single action that unblocks it and stops the loop is your call below.

Options (full evidence in floor 11):

No code changed, nothing pushed this run.


结构化八问(中文 · 本轮)

  1. 是什么问题:同一未决阻塞的重复触发——[PR] feat: unified announcement surface — built-in registry + single renderer (lane A, #5548 P1) #5557 与 master 冲突(dirty),且其目标功能已被 master 更完整的实现取代。
  2. 什么原因导致的:Unified Announcement Panel Design (Approved): Built-in declarations + local JSON + remote GitHub raw — a single renderer | 公告面统一设计(已批准):内置声明 + 本地 JSON + 远程 GitHub raw,三来源一套渲染器 #5548 P1 被并行实现,master 侧已合入并持续维护;本 PR 过期后仍挂着,等拍板期间反复触发 CI 车道。
  3. 影响范围与严重程度:仅本 PR;每次触发都是一次空跑(调度浪费),不影响线上/master。
  4. 怎么修复的:本轮仅做活体核验(未改代码、未 push),确认状态未变,维持停手待决策。
  5. 是否有回归问题:不涉及(未改动任何代码)。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及;待 owner 在 A/B/C 中拍板。
  8. 是否引入了新的配置:不涉及。

建议:A(关闭为已取代),可同时止住重复触发循环。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策

第三次重复触发 · 状态仍未变。 Live re-check this run:

  • PR head still 1dda83eb (no push since floor 11); mergeable_state still dirty.
  • Master has moved on further (33104b1) — the PR is now even further behind the branch that already ships the complete feature.
  • needs-decision label still applied. No owner response to any of the pending decisions (floors 4 / 11 / 16).

There is still no mechanical fix: the conflict is two mutually-exclusive implementations of #5548 P1 in src/notices.ts, and master already ships the complete feature. Full evidence + A/B/C options are in floor 11 (restated in floor 16) — not repeating them here. Nothing changed, nothing pushed this run.

Your call — A (close #5557 as superseded) — is the only action that clears the block and stops these repeated no-op triggers.


结构化八问(中文 · 本轮,均无变化)

  1. 是什么问题:被 master 取代的 dirty PR 再次触发 CI 车道。
  2. 什么原因导致的:Unified Announcement Panel Design (Approved): Built-in declarations + local JSON + remote GitHub raw — a single renderer | 公告面统一设计(已批准):内置声明 + 本地 JSON + 远程 GitHub raw,三来源一套渲染器 #5548 P1 已被 master 更完整实现取代,本 PR 过期仍挂着等拍板。
  3. 影响范围与严重程度:仅本 PR;每次触发是空跑(调度浪费),不影响线上/master。
  4. 怎么修复的:本轮仅活体核验(head/状态/标签/master 位置),未改代码、未 push。
  5. 是否有回归问题:不涉及(未改动任何代码)。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及;待 owner 在 A/B/C 中拍板。
  8. 是否引入了新的配置:不涉及。

建议:A(关闭为已取代)。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

1 similar comment
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策

第四次重复触发 · 状态仍未变,且 PR 越来越旧。 Live re-check:

  • PR head still 1dda83eb (no push ever); mergeable_state still dirty.
  • Master advanced again (259cd87) — the superseding branch keeps moving while this PR waits.
  • needs-decision label still applied. No owner response to any pending decision (floors 4 / 11 / 16 / 23).

No mechanical fix exists (superseded by master — evidence + A/B/C in floor 11). Nothing changed, nothing pushed this run. The lane now re-fires on every poll as a no-op; only your call — A (close #5557 as superseded) — clears the block and stops the loop. Until then I will keep each pass to a verify-and-report tick.


结构化八问(中文 · 本轮,均无变化)

  1. 是什么问题:被 master 取代的 dirty PR 第四次触发 CI 车道。
  2. 什么原因导致的:Unified Announcement Panel Design (Approved): Built-in declarations + local JSON + remote GitHub raw — a single renderer | 公告面统一设计(已批准):内置声明 + 本地 JSON + 远程 GitHub raw,三来源一套渲染器 #5548 P1 已被 master 取代,本 PR 过期仍挂着等拍板。
  3. 影响范围与严重程度:仅本 PR;每次触发是空跑(调度浪费),不影响线上/master。
  4. 怎么修复的:本轮仅活体核验(head/状态/标签/master 位置),未改代码、未 push。
  5. 是否有回归问题:不涉及。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及;待 owner 在 A/B/C 中拍板。
  8. 是否引入了新的配置:不涉及。

建议:A(关闭为已取代)。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策

第五次触发 · 状态无变化。 head 仍 1dda83eb(从未 push)、仍 dirty、needs-decision 标签在、owner 仍未回复(floors 4/11/16/23/30)。无机械可修项——已被 master 取代,证据与 A/B/C 选项见 floor 11,不再重复。本轮未改代码、未 push。

唯一解法仍是 owner 关闭(A)。此后每次触发我只发一行核验简报,不再重复分析。

八问(本轮无变化,详见 floor 11):1 被取代的 dirty PR 再触发;2 已被 master 取代待拍板;3 仅本 PR,空跑浪费调度;4 仅活体核验,未改未 push;5 不涉及;6 不涉及;7 不涉及,待 A/B/C;8 不涉及。建议 A。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策

第六次触发 · 活体核验,状态无变化。 head 仍 1dda83eb(从未 push)、仍 dirty、needs-decision 标签在、owner 仍未回复。无机械可修项——已被 master 取代,A/B/C 选项与证据见 floor 11,不再重复。本轮未改代码、未 push。

唯一解法仍是 owner 关闭(A)。

八问:本轮 1–8 全部无变化/不涉及(详见 floor 11)。建议 A。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

2 similar comments
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

@ranxianglei

Copy link
Copy Markdown
Owner Author

Closing: the unified announcement surface is already on master — src/notices.ts ("Unified built-in notice registry (#5548 P1)"), notice-store.ts, and the c0f09bf/bbbf857ff/656de819e notice commits. Issue #5548 is closed; this branch is the superseded implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant