Repository navigation
[PR] docs: align dshTimeContextPath comment with code fact (#5352 finding 2) - #5353
ranxianglei wants to merge 1 commit into
Conversation
The doc comment claimed the dsh time-context carrier 'stays OUT of dshDurableToolPath / kernel protection'. That is wrong: dshDurableToolPath DOES route it (?? dshTimeContextPath(msg)), so its virtual path is assigned for Rule 3 last-user-anchor refusal and one-shot accounting. What keeps it foldable (never pinned) is that its returned path is oneshot/*, which misses the durable/* latest-per-identity protection withDurableProtection applies to the four durable carriers. Reworded to say classified-but-never-pinned. Comment-only; no behavior change.
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.7525-pr.5353.311879eThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr5353.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复。本分支 这是一条带 我独立核对了新注释的每一条事实断言(读真实代码,不只读 diff):
旧注释「stays OUT of 回归面:纯注释改动。 CI(head 判定:代码正确、零回归、无红项。 另:issue 正文提到的 Finding 1( |
ranxianglei
left a comment
There was a problem hiding this comment.
(ai: vllm-qwen/qwen3.8-27b)
Verdict: APPROVE (posted as a comment review — GitHub refuses the approve event on a PR by the same account; treat this as the approval record). Comment-only fix; every factual claim independently re-verified against the code at head 73ff0e1c3; CI fully green (30 checks: 18 success / 12 skipped by design / 0 failed, mirror cache @ 12:40Z).
Independent verification (re-read the code myself, did not copy the issue-side analysis):
- Old text "stays OUT of
dshDurableToolPath/ kernel protection" was wrong on both counts:dshDurableToolPathDOES route it (?? dshTimeContextPath(msg), src/durable-message-guards.ts:249-257), and its virtual path reaches the kernel viamessagePathOf(wired at src/session.ts:798-799 & 810-811, src/server/handle.ts:2442-2443), wherelastUserAnchorskips any virtual-path message (kernel/src/protected.ts:329-343, Rule 3 at kernel/src/recommend.ts:137-152). - New text "classified, never pinned" is accurate on both axes: the returned path is
oneshot/time-context(src/durable-message-guards.ts:190), which deliberately misses thedurable/*latest-per-identity patternwithDurableProtectionadds toprotectedLatestTools(src/durable-message-guards.ts:284-291). - Non-blocking wording note: the parenthetical "...assigned for Rule 3 last-user-anchor refusal and one-shot accounting" bundles two consumers — one-shot accounting actually rides the sibling classifier
oneShotCarrierPaths(src/fold-reconcile.ts:1786), notdshDurableToolPathitself. Both return the same path string and the very next sentences of the same comment attribute each consumer precisely ("oneShotCarrierPaths accounts that retirement as EXPECTED"; "The path still matters beyond accounting: kernel Rule 3 refuses..."), so the comment as a whole reads correctly. Not worth rewording churn on a p3 docs fix.
Regression audit (existing behaviors carried by the touched path):
- Touched surface: exactly one doc-comment block in src/durable-message-guards.ts (
git show --stat: 1 file, +6/-3, all inside the/** */block). Single commit, no version/lockfile/test/wire changes. - Preserved individually: carrier classification outputs,
durable/*pinning policy, Rule 3 anchor scan, fold-reconcile expected-rebase accounting, persistence format, config surface — zero code lines touched. - High-risk patterns (semantic drift while fixing, fail-fast→swallow, threshold/timing/output-format drift): none present in a comment-only diff.
- Finding 1 (statusLine A/B) is correctly NOT in this PR — matches the PR body's scoping statement.
八问:
- 是什么问题:
dshTimeContextPath的注释声称该载体"不进 dshDurableToolPath / 内核保护",与代码事实相反——代码确实把它路由进了分类器。 - 什么原因导致的: 注释停留在早期设计阶段,后续把它纳入分类器时(#5109/#5142 演进)没有同步更新。
- 影响范围与严重程度: 仅文档误导,无外部行为影响;风险是读者误以为该载体完全不受内核分类(Rule 3 锚点拒绝被误读为不适用)。
- 怎么修复的: 注释改为与代码一致的一句话定性——"classified, never pinned":虚拟路径被分配(服务 Rule 3 锚点拒绝与一次性退役记账),但其
oneshot/*路径故意不命中durable/*latest-per-identity pin。 - 是否有回归: 不涉及——纯注释、零逻辑行;该文件承担的既有行为已逐项清点(见上),全部保持。
- 是否破坏缓存: 不涉及。
- 是否改了设计方向: 不涉及。
- 是否引入新配置: 不涉及。
可合并判定:干净、零行为变更、CI 全绿,可以合并(合并操作留给人工)。
|
(ai: sglang-gpu0/qwen3.8-27b) |
What
Corrects the
dshTimeContextPathdoc comment insrc/durable-message-guards.ts, which contradicted the code (discovered during the v0.1.209→master full-window regression review behind #5352).dshDurableToolPath/ kernel protection."dshDurableToolPathDOES route it (?? dshTimeContextPath(msg)), so its virtual path IS assigned — required for kernel Rule 3 last-user-anchor refusal and one-shot retirement accounting. What keeps it foldable / never-pinned is that its returned path isoneshot/*, which deliberately misses thedurable/*latest-per-identity protection thatwithDurableProtectionapplies to the four durable carriers.Scope
Comment-only. Zero behavior change — no logic, wire shape, config, persistence, or test touched.
Issue linkage
Part of #5352 (Finding 2 — the p3 one-line comment fix). Finding 1 (the
statusLineplugin-mode disposition, options A/B) is a pending owner decision; once settled, that change lands on this same branch/PR.