Repository navigation
[PR] fix(fork): restore cold parents from verified unified raw tails (#5140) - #5141
Closed
abworks-dev wants to merge 1 commit into
Closed
abworks-dev wants to merge 1 commit into
abworks-dev wants to merge 1 commit into
Conversation
This was referenced Oct 29, 2026
ranxianglei
pushed a commit
that referenced
this pull request
Oct 29, 2026
…ments cite #5139, not #5141 Owner correction on #5144: the Codex separator-endpoint bug report is GitHub issue #5139 (kuviki), not #5141 (an unrelated in-flight external PR). Renames tests/issue5141-turn-separator-ranges.test.ts -> tests/issue5139-turn-separator-ranges.test.ts and re-points every in-code citation. No behavior change: comments, test names/session-id prefix only.
Owner
|
(ai: sglang-gpu0/qwen3.8-27b) 你最新一轮 CI(run 40870271809,head 220af4e)的 4 个红 shard(ubuntu-latest 22/2、24/2;windows-latest 22/1、22/2)我在本地按 CI 同款 preload 链复现了,根因不在你的修复代码,而是分支树里 —— 批量 triage agent,只做了复现与诊断,没有改你的任何提交。 |
ranxianglei
pushed a commit
to Louie0806/billion-context
that referenced
this pull request
Oct 29, 2026
ranxianglei#5141) repairResponsesAssistantOrdering inserts acp_turn_sep_* user markers into the Responses SEND view only; they never exist in the original history (the apply view). liveCompressionRanges / uncoveredHistoryRuns / the post-compress recovery path re-run processTurn on the send view while screening candidates against the apply view, so any candidate unit that endpoints on a marker ref throws BoundaryNotFoundError in projectUnit and screenRecommendedUnits demotes it to a gap silently — large amounts of offerrable history vanish from the acp_status offer ("little left to fold" while ~180K was recoverable). Analysis entry points now strip outbound-only markers before processTurn (withoutTurnSeparators, zero-copy when absent). Real-message refs are id-stable across views, so every offered endpoint resolves in the apply view again. Ordering repair, tool pairing and turn-integrity protection are untouched — only the analyzed array class changes. Behavior change: ranges previously dropped behind separator endpoints reappear in acp_status / compress-receipt offers; the "little left to fold" pressure note stops firing while a large pending mass is actually offerrable.
Owner
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5140
Scope and provenance
This is the narrow persisted cold-source execution for #4266 item 4. It complements #3024, rather than replacing it or reproducing its native retryable-409, resident warm-tail selection, divergent-head replacement, or compaction-reset work. Those changes remain with the existing author PR. It does not include the separate HTTP200 error work tracked in #4979 or the preflight receipt work in #5100.
Version inspected: 0.1.209. This branch starts from current master
1fad21deand leaves the version unchanged.Remaining defect
A parent without a prior public fork contract intentionally has no retained raw snapshot after restart. In shadow mode its JSON envelope can be folded even though unified storage still has the complete independently stored raw tail. Repeated snapshot requests cannot recover that source through
pluginSnapshotalone. PR #3024's resident-tail fallback deliberately does not treat a folded cold restore as raw.Fix
lastPassIdsmatch, and equal compression state, block contents and CCR. Ignore only the non-contentrefLedgerAlignedstamp on copied states; changed mappings still fail.Coexistence / review
The three snapshot source-selection call sites overlap textually with open #3024; merging both needs union-of-intent sequencing: retained source first, #3024's valid warm-tail policy, then this strict persisted cold fallback only when no usable source exists. The broader #3011/#4266 work remains separate; #3024 retains its original scope and authorship. Human review is requested because this is a fork-source fallback/identity boundary.
Validation
All local tests use isolated temporary HOME/DSH/XDG/application-data directories and loopback mocks, never a private user database or a real model. Full suite was not run locally; full-suite authority remains remote CI.
Honest limits