Repository navigation
Conversation
…anxianglei#5116) The native plugin set only HTTPS_PROXY, so a plain-http base_url (a LAN llama.cpp, vLLM or ollama server) bypassed the proxy and its sessions were never compressed. apply_env now sets the HTTP pair too and defaults NO_PROXY to loopback, matching the launcher's own plain-http routes. All of them sit in _ENV_ROUTED_KEYS, so the ranxianglei#4644 watchdog unroutes and restores them along with the HTTPS pair. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MMUmTHLFoNYr4iAsprTFfk
(ai: vllm-qwen/qwen3.8-27b) 查重结论:不重复(本 PR 是首个修复),但审出撞车——同一 bug 有两个在途 PR。
标签:bug / hermes / scope/wiring / p2(能用但静默零压缩,有绕行——https provider 或手动 /bili/ 前缀;镜像 labels API 未实现,无法经 API 打标,在此声明判定)。 验证证据(本地,当前 master 5594c13 上应用本 PR diff,两文件自 base 885b948 以来无变动、干净套用):
结构化八问(针对本 PR 现状):
处置请求(需 owner 拍板)——一个 bug 收敛为一个合入 PR:
判定:本 PR 本身正确、最小、测试有牙、CI 全绿,技术上可合;但建议先做上述收敛再合,避免同 bug 两个 PR 各自合入造成 diff 重叠与关闭引用混乱。我未向任何分支推送提交(验证全部通过本地套用 diff + 定向测试完成)。 |
…5116) Companion to PR #5117 (reporter's fork PR), which fixes the same mechanism in the native plugin lane and stays there untouched — this branch is a fork, so this PR covers only the complementary part: the 'bili hermes' LAUNCHER lane + docs + launcher test. hermes' httpx stack resolves proxy envs per scheme (field-verified on Hermes v0.22.5): https upstreams read HTTPS_PROXY, plain-http upstreams read HTTP_PROXY. The launcher exported only the HTTPS pair, so plain-http providers went straight out and bili never saw them (#5116). Same defect class as the plugin lane; same fix shape as the dsh/kimi/mcode/jcode/zed/ qwen house pattern (HTTP_PROXY = origin + loopback NO_PROXY). The child env is stripped of inherited proxy vars first, so the static loopback constant is the whole NO_PROXY value here. Behavior changes (disclosed per policy): - plain-http provider traffic: direct to server -> routed through bili (absolute-form forward-proxy requests) — the intended fix. - child env gains HTTP_PROXY/http_proxy=<origin> and NO_PROXY/no_proxy=localhost,127.0.0.1,::1. - loopback https providers now go DIRECT instead of CONNECT-MITM'd through bili — consistent with the loopback-direct contract every other env-routing lane already keeps for its own proxy origin. - non-model http egress of the spawned hermes process rides bili instead of going direct. Together with #5117 this completes #5116; the two PRs touch disjoint files and merge cleanly in either order.
|
(ai: vllm-qwen/qwen3.8-27b) @elight thanks for the PR — triaged and kept as-is (first-filed, it owns the plugin-lane fix). Two notes from reviewing the full surface:
CI verdict on this head comes from remote CI; no changes needed from you unless review asks for something. |
|
@ranxianglei SGTM! I'm glad either way so long as it's fixed! |
|
So shall we close this one in favor of yours? |
(ai: vllm-qwen/qwen3.8-27b) @elight Short answer: nothing needs closing — per @ranxianglei's review above, this PR is kept as-is: it owns the plugin-lane fix, and companion PR #5121 covers only the launcher lane + docs (disjoint files); the two together close bug #5116. Which PRs stay open / get merged is the repo owner's call, so there's no action for you here. One status note on this thread's open item: CI is now fully green on head |
…hips it (#5116) Review fix on this branch: the plugin-lane sentence claimed HTTP_PROXY / NO_PROXY routing that this PR does not ship for the native plugin. The plugin's apply_env still sets only the HTTPS pair + CA bundles; the plain-http half lives in open PR #5117 (adds the HTTP pair + NO_PROXY setdefault to apply_env). Reword so each claim matches code on master: the launcher lane (this PR) routes both schemes; the plugin lane gets them via #5117.
|
Landed via batch PR #6482 (merged) — closing as superseded. |
(ai: vllm-qwen/qwen3.8-27b) Confirmed against current master ( |
Fixes #5116.
The native Hermes plugin set only
HTTPS_PROXY/https_proxy, so a providerbase_urlover plain http (a LAN llama.cpp, vLLM or ollama server) went straight to the server. bili never saw those turns and nothing was compressed.apply_envnow also setsHTTP_PROXY/http_proxyto the origin and defaultsNO_PROXY/no_proxyto loopback (127.0.0.1,localhost,::1). That is the same split the launcher uses for its own plain-http routes. ANO_PROXYthe user has already set is left alone.All four keys are added to
_ENV_ROUTED_KEYS, so the #4644 watchdog unroutes and restores them along with the HTTPS pair when the origin dies. Without that, a dead proxy would strand plain-http traffic exactly as #2714 described for https.Tests:
tests/hermes-native.test.tsattach: the HTTP pair equals the origin andNO_PROXYis the loopback default.origin-death:HTTP_PROXYleaves the dead origin during the gap and comes back with the recovered one.With the change, 51/51 pass. With only the plugin change reverted, both new assertions fail (49 pass, 2 fail).
Field note: we have run the equivalent change on a Hermes v0.22.5 host since 2026-10-25, with a plain-http LAN gateway as the main provider, and bili forwards the absolute-form requests correctly.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MMUmTHLFoNYr4iAsprTFfk