Repository navigation
[PR] fix(plugin): name the qualifying signals on the double-degenerate fatal log line (#4913) - #4918
ranxianglei wants to merge 14 commits into
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.10522-pr.4918.af3cba3This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4918.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: qwen/qwen3.8-27b) 查重: 不重复。 GitHub 侧检索 open/closed issue 与 PR:触碰这条 fatal 日志行的只有本 PR(#4918)自己;GitHub #4919(decision request: passthrough toggle design)是 #4913 的配置面开关半边——机制不同(配置面 vs 日志可观测性),且本 PR 明确把它排除在外,不算重复。 审核方式:拉取分支 结构化八问:
测试有效性:新测试驱动真实入口 CI:de17ad3 全绿(test ubuntu/windows × node 22/24 全部 shard + kernel-guard / config-surface-guard / version-guard / lane-guard / static-gates 等守卫),mergeable=true,base=master 无冲突。 判定:可合并。 日志-only、零行为变更、测试钉住语义、CI 全绿。配置面开关半边继续等 #4913 线程的 owner 决策,与本 PR 正交。 |
(ai: qwen/qwen3.8-27b) 标签: |
…te-retry-fatal-log
…log: sync to newest master
…l-log: converge 5 red guard lanes
…nerate-retry-fatal-log
…rate-retry-fatal-log
…-sync # Conflicts: # src/plugin.ts
6c51654 to
75fbb1b
Compare
[bot] 🏷 APPROVE — log-line-only change, no behavior/wire/config impact. Verified on the rebased head (75fbb1b):
8问(中文):
判定:可合入(APPROVE)。 Note: the formal GitHub APPROVE review was rejected by GitHub (self-approval — the review bot shares the PR author identity). The verdict is APPROVE; owner can approve and merge. |
…te-retry-fatal-log
The probe anchor PROXY_TOOL_AT=6 was calibrated on 2026-10-31 for #4521 (schedule {4,6,8,9}). The nudge scheduling has shifted again — nudge now lands at {3,5,11,14}. Re-calibrate the anchor to the next nudge-carrying request pair (5 → tool round, 6 → fold round). The fold/proxy-tool-round mechanics under test are unchanged. Closes: master-red on test (windows-latest, 22, 3) and (ubuntu-latest, 22, 1).
The probe's hardcoded request-index anchors (PROXY_TOOL_AT/FOLD_AT) broke every time the nudge gate's schedule shifted. The last recalibration (245ecb1) was measured on a direct local run (timestamps ON by default since #4313), but CI runs the suite preload pin BILI_MESSAGE_TIMESTAMPS="0" (timestamps OFF) — a different wire shape, a different schedule (no nudge at index 5) — so it passed locally and failed on every CI shard. Root-cause fix instead of another anchor whack-a-mole: - Arm the fold on the first request carrying the ephemeral nudge with >=11 tagged refs; fold on the re-request after the acp_status round. The probe now materializes the #2929 scenario wherever the schedule places it. - Pin compress.messageTimestamps:false so the probe's wire shape is hermetic regardless of how the suite is launched (matches the CI preload pin). Supersedes the 245ecb1 recalibration. Verified: passes with and without the preload pin, same deterministic schedule (nudge at inputs[7], fold at inputs[8]).
Brings in the ci-fixes sentinel fixes for the two inherited master reds that are not caused by this PR: - test(#2929): schedule-independent fold probe + hermetic wire shape (7247410, supersedes 245ecb1) — fixes the #2929 probe failing on every CI shard (win22/4, ubu22/3, ubu24/3) - docs(architecture): register src/responses-system-sections.ts in the module map (8ed56be) — fixes the architecture-docs guard
[bot] 🏷 APPROVE — log-line-only change, no behavior/wire/config impact. Re-reviewed on the new head (ccb5615) after the ci-fixes merge + the stalled-tail signal addition (commit 53813d6). Verified:
8问(中文):
判定:可合入(APPROVE)。 Note: the formal GitHub APPROVE review is rejected by GitHub (self-approval — the review bot shares the PR author identity). The verdict is APPROVE; owner can approve and merge. |
|
(ai: vllm-qwen/qwen3.8-27b) Superseded by #6993 — its commit df673be carries the same observability fix (the fatal log now names the qualifying signals, with the same field set plus |
[bot] 🏷 Confirmed — this PR is superseded by #6993. Verified: commit df673be (on master, from #6993) carries both the behavioral fix (bare-exemption gate moved before the fatal branch + per-attempt counter reset) and the observability fix (the fatal log now names the qualifying signals). Its fatal log line:
This PR's log line (head ccb5615) names a different field set (adds No further work planned here. Awaiting owner closure. |
…l log (#4913) The PR body promises the fatal log carries the qualifying signals + finish reason, but both terminal log lines (the #870 fatal and the new compat.degenerateTurn=passthrough branch) named the signals without the finish reason. That also drops the finishReason field the superseded observability PR #4918 carried. Add finishReason=${reason} to both lines. Log-only; no behavior change.
Part of #4913 — the observability half (issue change #3: log which signal qualified on the "again after the retry" line). The config-surface switch for the rest is pending owner decision in the issue thread; this PR changes no behavior and needs none.
What
The chat-pipe's #870 fatal in-band stream error fires when the one-shot continuation retry (#732/#821) also ends with zero usable output. The log line was an opaque verdict:
It now names exactly which of the bare-exemption inputs carried the turn, plus the retry's own finish reason:
That lets a user attribute their failures without hand-aligning log pairs (e.g. #4913's FP4 thinking-only model: every hard fail is expected to show sawThinking=true + zero visible prose).
Behavior changes
None. Log-line content only — wire bytes, the retry gate, and the #870 error frame are unchanged. The pre-existing #870-path test (tests/issue2303-draft-tail.test.ts "a draft-tail RETRY degenerates into the in-band error") stays green.
Tests
New tests/issue4913-retry-fatal-log.test.ts pins both directions: a thinking-only double-degenerate names sawThinking=true + its finish reason; a released-markup first pass rides a non-zero releasedMarkupChars counter onto the fatal line (documenting that the counter is cumulative across passes — the reset half of issue change #2 belongs to the pending decision).
Local on rebased head: targeted suites green (issue4913/issue2756/issue2303/fix-1760/cache-proof = 48 tests), typecheck clean. Full suite = CI.