Repository navigation
[PR] chore: fold thinking forms single-source + drop inert fold-reconcile import - #4866
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.6318-pr.4866.5821dd5This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4866.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复——这是 #4801 评审发现的两个死代码/易漂移点的修复,检索 open/closed issue 与近期 PR 无同症状条目(失败签名:thinking forms 双份维护 + server.ts 死 import)。 这是 [PR] 条目,分支 |
…import The demoted-thinking form list existed twice (kernel/src/wire/demoted-thinking.ts FORMS and src/fold-reconcile.ts THINKING_MERGE_FORMS) with only a comment tying them — a silent drift bug waiting to happen. fold-reconcile now imports the kernel list directly (deep-import convention already used by src/storage/ingest.ts). Also drops src/server.ts's import of reconcileFoldCoverage/noteSystemPromptFingerprint/ resolveFoldReconcileMode — all three were unused in that module (the prepare-* files import their own copies).
d128daf to
16ebc28
Compare
Review fix on PR #4866 branch: the local THINKING_MERGE_FORMS deletion left two blank lines between the doc comment and the export (src/fold-reconcile.ts). No behavior change.
Version discipline (Kernel Boundary rule 2): this PR touches kernel/src/wire/demoted-thinking.ts (FORMS becomes an exported single source), which requires a kernel version bump. Lockfile regenerated with npm install --package-lock-only (mirrors the lock-sync CI check).
(ai: vllm-qwen/qwen3.8-27b) 审核结论:代码本身正确且已验证,但卡在 kernel 授权门禁 —— 已按 owner policy 2026-10-26 立项 #4877(kernel authorization request,p1)等拍板。 标签: 结构化八问
审核方动作(已推到 PR 分支,head
|
(ai: vllm-qwen/qwen3.8-27b) 收工确认(完整八问结论见上一条回复):本条 PR 的审核与可执行修复已全部完成——
我这边无其他待办,停等裁决。 |
The 0.0.167->0.0.168 bump commit regenerated kernel/package-lock.json but left the root lockfile's packages["kernel"].version at 0.0.167, which the lock-sync job (#2704) rejects. Regenerated with the exact lock-sync recipe (npm install --package-lock-only --ignore-scripts --no-fund --no-audit, node 22 / npm 10); diff is the single version line only.
(ai: vllm-qwen/qwen3.8-27b) kernel 授权闭环 + 最后一处 CI 红已修,全绿可合。
等你合并。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.868-master.02bcdc4 # this exact build
npm install -g billion-context@master # always the newest merged build
|
…lset-tripwire
Conflicts resolved:
- tests/golden/storage-render/{anthropic,chat,google,responses}.json: digest-only conflict (both sides legitimately moved the snapshots). Regenerated from the merged tree via scripts/update-storage-render-goldens.ts and verified against both parents (vs master: only this branch's metadata/stateDigest delta; vs previous head: byte-identical, since no new master commit touched these conversations' wire).
- kernel/package.json + kernel/package-lock.json: master's version bump to 0.0.168 (this branch makes no kernel changes); took master's side.
- package-lock.json: vendored kernel entry version line -> 0.0.168 to match.
- src/server/codex-catalog-cache.ts: master's off-spec-304 handling (#4866); this branch has no own change here, took master's side.
- src/server/prepare-responses.ts: import hunk unioned - this branch's noteBiliToolSurface/outboundBiliSurface plus master's anchored-view snapshot-render imports.
这是啥问题
两个死代码/易漂移点(增量压缩深入分析的副产物,见 #4801 评审):
改动
验证
kernel-change: export FORMS as the single source of truth for the demoted-thinking merge forms; bili fold-reconcile now imports it instead of keeping a byte-identical copy (dedup, #3301). No behavior change on the kernel side.