Repository navigation
[PR] feat: serve a bundled favicon.ico at /favicon.ico so browser icon probes never relay upstream - #4835
Conversation
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.6243-pr.4835.640a832This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4835.tgz
npm install -g packageInstall instructions are refreshed on each push. |
3b4f0d7 to
9ea22ce
Compare
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复 —— 本 PR 是 #4830 的实现项(捆绑真图标 + 本地响应);前序 #3536 只在 master 落了本地 204 backstop(v0.1.204–v0.1.208 未发布),本 PR 把该 backstop 升级为真图标;与其他开放条目无重叠。 标签: bug、dsh、scope/ui、p3(缺陷类;事故经 dsh desktop Electron 帧触发;WebUI 面;日志噪音级严重度) 八问
独立验证(未依赖 PR 自述)
diff 整洁度: 5 个文件,每一行都服务于本 PR 目的;无无关改动/空白重排。gen-favicon.mjs 作为生成物来源留在仓内(可审计/可再生),合理。 判定: 可合并(待 rebase 后 head 的 CI 转绿最终确认)。 |
(ai: vllm-qwen/qwen3.8-27b) rebase 后 head
唯一红分片是继承性 born-red,与本 PR 无关:
分支侧无需任何改动;手动重跑该 job 在簇 1 收敛前仍会确定性红。状态已按政策一行报到 #4599。 最终判定更新:代码可合并。 检查矩阵上唯一红条是 master 侧继承红(在本 PR 自己的 base 上即已存在);待哨兵把簇 1 修复收敛后重触发即全绿,owner 知悉继承红的前提下也可直接合并。 |
(ai: vllm-qwen/qwen3.8-27b) CI 自动修复车道(attempt 1/2)结论:独立复核(GitHub API 拉取 job 日志 + 本地 git 比对,不依赖 floor 3/4 既有结论)——唯一红分片是 master 侧继承红(CI 总控板上簇 1),与本 PR 无关;分支侧无需任何改动。不开新 issue:簇 1 已在 #4599 板上有名有姓(首坏提交 + clean-master A/B 俱全),由哨兵收敛中;政策 2026-10-24 明令 CI 问题禁开新 issue,状态已一行报到 #4599(floor 293)。 复核证据(每条独立取得):
八问
判定:代码可合并(维持 floor 4 结论) —— 检查矩阵上唯一红条在 PR 自己的 base 上即已存在,与本 PR 零交集;待哨兵把簇 1 收敛进 ci-fixes/master 后重触发即全绿,owner 知悉继承红的前提下也可直接合并。若收敛前 attempt 2 再触发,结论不变,无需重复分析。 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.864-master.c8e3e64 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Closes #4830
What
Browsers probing the proxy origin for
/favicon.ico(the dsh desktop Electron frame, direct visits, pre-redirect probes) now get the bundled bili icon instead of falling through the relay onto the configured upstream — which burned a request there and loggedupstream-timeouterrors for a static asset no model client ever asks for (#4830's incident log carried 68 such lines and made users suspect the model service).Changes
scripts/gen-favicon.mjs(new): deterministic generator — draws the panel brand mark (∞ on an accent-blue rounded square, 4×4 supersampled), encodes 16px+32px PNGs into one .ico container, writessrc/web/favicon.ts. Node builtins only, zero new dependencies, byte-stable output (no timestamps).src/web/favicon.ts(new, generated):FAVICON_ICO_BASE64— a 541 B .ico shipped inside the bundle.src/server/admin.ts:GET /favicon.icoanswers 200 image/x-icon with the bundled bytes (cache-control: no-cache, same posture as the page shell) instead of 204.src/web/page.ts: panel head declares<link rel="icon" type="image/x-icon" href="/favicon.ico">instead of the emptydata:,icon, so the tab shows a real icon.tests/issue3536-favicon-local.test.ts: updated for the new asset + new structural test that the embedded constant decodes to a valid .ico (it caught a directory/payload layout bug in the generator during development); both gate directions asserted — GET /favicon.ico pinned local, while POST on the same path and other unknown paths keep the relay fallthrough.Behavior changes (intended, disclosed per policy)
GET /favicon.icoimage/x-icon, 541 B bundled icon<link rel="icon" href="data:,">(no visible tab icon)<link rel="icon" type="image/x-icon" href="/favicon.ico">(real tab icon)No config surface added, no wire/protocol change, no kernel change. Non-GET requests on
/favicon.icokeep the previous relay fallthrough (unchanged by this PR).Verification
filereportsMS Windows icon resource - 2 icons, 16x16 with PNG image data … 32x32 with PNG image data; served bytes are sha256-identical to the embedded constant; served panel HTML carries the declaration