Skip to content

[PR] fix: fork cut uses highest live row seq, not live-row COUNT (#4730) - #4754

Closed
ranxianglei wants to merge 14 commits into
masterfrom
2026-10-25_fix-fork-lastliveseq-cut
Closed

ranxianglei wants to merge 14 commits into
masterfrom
2026-10-25_fix-fork-lastliveseq-cut

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Closes #4730

What & why

Forking a plugin-lane session clones the parent's unified-store rows as the child's starting history. The clone boundary was computed from the parent's live-row COUNT (unifiedLiveRowCount - 1), but message seq is append-only (remap/delta anchor at MAX(seq)+1). As soon as any row is retired — which every fold does — the count falls below the newest live row's seq, and cloneSessionRows(parent, child, count-1) cut the prefix before the tail: the child silently lost its newest messages, one per retired row.

With snapshot render on, the loss became visible online: the child appends at MAX(seq)+1, and that new row's ledgerSeq can land inside a cloned active block's ledger interval, so the prune pass drops it.

Fix

Cut at the parent's highest live row seq instead of its live-row count:

  • New lastLiveSeq(sessionId) = MAX(seq) WHERE session_id=? AND retired_at IS NULL, returning -1 when there are no live rows (kernel-only fork sentinel). Implemented across all storage layers: store.ts (SQLite), mysql.ts, backend.ts (interface + SqliteBackend), shadow.ts.
  • Renamed the now-obsolete liveRowCount / unifiedLiveRowCount to lastLiveSeq / unifiedLastLiveSeq (single caller; no dead code left behind).
  • The fork endpoint in src/plugin.ts passes unifiedLastLiveSeq(parent.id) directly as the inclusive throughSeq (dropped the -1; sentinel becomes >= 0).

Behavior change (old -> new)

  • Fork clone boundary: COUNT(live)-1 -> MAX(live seq). Identical when nothing is retired (MAX == count-1); differs only once a row is retired, where the old value undershot and dropped the tail. When cloning happens is unchanged (both trigger on "at least one live row").
  • Pure data-loss fix: no config surface, wire shape, persistence format/version, or kernel change.

Tests

New tests/issue4730-fork-lastliveseq.test.ts: pins the retired-row scenario (parent folds b,d -> child retains the full live prefix incl. tail e,f; append continues at max+1), plus the no-retired edge (boundary unchanged) and the all-retired edge (-1). Targeted run green; adjacent seq-ledger-pr3 and storage-review-p2s suites green; typecheck green. Full-suite verdict = remote CI.

Touches the fork/session-binding path, so flagged for human review/merge per section 7.4.

ci-check and others added 4 commits October 25, 2026 23:02
…ment

#4316 PR3/3 (restampRefsToLedger) re-homes citation numbers once on every
full-mode cold load; goldens pinning exact ref numbers are born-red. Re-pin
the 7 storage-lane tests (engine-proofs x6 + orphan-recovery x1) modulo that
renumbering — zero production code touched.

- golden-storage-drive.ts: per-turn citation-normalized digest (shaCiteNorm)
  and state digest modulo stripOneTimeAlignment (stateDigestAligned); the
  deep-sort helper is hoisted into golden-canonical.ts for sharing.
- corrupt-index-child.ts: new stripOneTimeAlignment normalizer — strips the
  refLedgerAligned stamp and re-homes refs onto canonical raw-id order so a
  clean full-mode read and the legacy fallback load compare equal.
- storage-engine-proofs.test.ts: wire legs assert shaCiteNorm equality vs
  the legacy restart leg and the committed goldens; state legs assert
  stateDigestAligned; rollback leg now spells BILI_STORAGE_UNIFIED=legacy
  explicitly (#3818 flip: absent resolves to full, deleting the env would
  vacate the legacy path).
- storage-orphan-recovery.test.ts: pins the content-addressable
  byRaw->byRef round-trip instead of a counter-era m00003 literal.
- golden/storage-render/*.json regenerated with shaCiteNorm/stateDigestAligned.

Converges the master-red storage-lane family (#4599 plan A, owner directive).
…dger parity masks

The #4316 one-time renumbering restamped messageRefs but left
state.tokenSnapshot keyed by the OLD refs, so post-restart bodies
carried stale per-message token counts (1.3K vs 1.4K) and the
full-mode-restart wire drifted off the legacy baseline (#4599).

persist.ts: two-pass remap (stage moves, delete old keys, then write
new keys) so entries whose new ref collides with another move's old
ref survive; fires only when superseded refs exist.

Aligned normalizer (corrupt-index-child.ts): the cacheLedger's
segment bookkeeping (be/bl/bs, unfinalized tail line), the derived
agg block, and per-line miss-attribution (prov/seam) are restart
experience, not content — no-restart and restart legs legitimately
differ there. Masked in the aligned view only; raw digests keep
full accounting. Goldens regenerated (stateDigest + aligned).

storage-engine-proofs 12/12, golden-storage-render 5/5 locally.
The unified store's message seq is append-only (remap/delta anchor at
MAX(seq)+1). The fork endpoint cut the cloned prefix at the parent's live-row
COUNT minus one, so once any row was retired (a fold tombstones covered rows)
the count undershot the newest position and the child silently lost tail
messages — one per retired row. With snapshot render live, the child's first
append at MAX+1 then fell inside a cloned active block's ledger interval and
was pruned.

Cut at MAX(seq) WHERE retired_at IS NULL instead (lastLiveSeq, -1 when no live
rows -> kernel-only fork). Renamed liveRowCount -> lastLiveSeq across all
storage layers (store/mysql/backend/shadow/persist); the fork endpoint now
passes it directly as the inclusive throughSeq. No behavior change when nothing
is retired (MAX == count-1). Regression test pins the retired-row scenario plus
the no-retired and all-retired edges.
@ranxianglei ranxianglei changed the title fix: fork cut uses highest live row seq, not live-row COUNT (#4730) [PR] fix: fork cut uses highest live row seq, not live-row COUNT (#4730) Oct 25, 2026
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-25_fix-fork-lastliveseq-cut (d884b77)

Latest build — install this exact version

npm install -g billion-context@0.0.5954-pr.4754.41accb7

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
d884b77 billion-context@0.0.5954-pr.4754.41accb7 build
7c0b6d0 billion-context@0.0.5899-pr.4754.534b3fc build
8610db5 billion-context@0.0.5781-pr.4754.70ccb0d build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr4754.tgz
npm install -g package

Install instructions are refreshed on each push.

ranxianglei and others added 6 commits October 26, 2026 01:03
…persisted state (#4599)

The fork-survival test asserted immediately after the compress tool
response, but the fold lands in the live session state asynchronously
(#3573 replay semantics). Slow CI runners persisted the pre-fold state
('0 block(s) (compressions=0)' cold load) and the deepEqual diverged.
Bounded 5s wait on the in-memory fold; fast machines exit on the first
iteration. Product semantics unchanged.
The #4316 cold-load alignment reads the unified sidecar; its ingest of
just-flushed records completes asynchronously. Slow runners compared
the pre-ingest state and saw refLedgerAligned missing while the fold
itself had landed. Poll (bounded 5s) until the loaded state carries
the flag; fast machines exit on the first probe.
Git-for-Windows autocrlf checks the bundled .md posts out with CRLF;
the exact-match '---' fences then failed to parse and every post lost
its title/excerpt/date frontmatter (Windows CI: 'bundled meet-bili post
found' assertion). Normalize CRLF to LF inside parseFrontmatter when
the fence is CRLF-shaped; LF content is byte-identical as before.
Regression test with a CRLF fixture.
… storage mode (#4599)

The #4316 cold-load alignment sets refLedgerAligned only when the
unified store is available; config-clean machines (CI runners) run
legacy mode where it is an honest skip. The test asserted the flag
unconditionally, so every shard carrying this file was born-red on CI
while unified-config machines passed. Expectation now mirrors
store.replicasAvailable(); verified 49/49 in BOTH modes locally.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重: 不重复 —— fork 克隆边界这一机制在 open+closed issue/PR 中无其他条目;本 PR 即 #4730 的唯一修复载体(Closes #4730)。

独立审核(重读 diff、独立复现推理,不复用 issue 侧结论)

方向判定:#4730 的根因分析成立且修在了决策点上。fork 克隆边界把两个不同的量混为一谈——「活行有多少条」(COUNT)与「最新活行在第几号」(MAX seq)。seq 是 append-only(新行永远 MAX(seq)+1),两者只在「从未 retire 过」时相等;任何一次 fold 都会 retire 行、留下空洞,COUNT(live)-1 从此系统性低于尾行位置。修边界计算本身 = 疏(消除产生缺陷的机制),不是在下游堵症状。✔

逐层核对(5 层存储 + 唯一调用点):

  • lastLiveSeq 五处实现语义一致:MAX(seq) WHERE session_id=? AND retired_at IS NULL,无活行返回 -1。mysql.ts 的判空写法(typeof m === "number" && Number.isFinite(m) ? m : -1)与该文件既有 num() helper(mysql.ts:219-221)逐字同语义 ✔
  • 改名彻底:全仓 grep 零残留 liveRowCount|unifiedLiveRowCount,无死代码 ✔
  • 触发条件等价性(我独立推过):旧 count > 0 ⟺ 新 lastLiveSeq >= 0 ⟺ 「至少一行活」,克隆时机不变 ✔
  • 取值等价性分类:① 无 retire → MAX == count-1,边界逐字节相同;② 顶行被 retire(如 0-5 号行、5 已退)→ 旧切 4、新切 4,相同;③ 仅当 retire 行位于最新活行之下时不同——恰是 bug 场景,新值严格多含(只可能多切、不会少切),且永不超过父会话整体 max seq ✔
  • cloneSessionRows 本体未被本 PR 触碰:含 retired 行的整段克隆、幂等 replay 守卫(child 已有行即跳过)、fork_point_seq 落账、refcount CAS 全部保持原样 ✔

测试有效性:3 个用例有牙——retired-row 主场景在旧逻辑下断言必挂(count-1=3 会丢掉 e,f);no-retired 边钉住「不变」、all-retired 边钉住 -1 哨兵;幂等 replay 与追加续接(seq 6)也覆盖到了。缺口备注:MySQL/shadow/backend 三个 twin 未直接单测——与仓库对存储 twin 的既有惯例一致(seqByRaw/cloneSessionRows 同样只有 SQLite 侧单测,mysql-contract CI 门禁兜 schema),可接受。一处非阻塞观察:mysql.ts:907 可用文件惯用的 num(m, -1) 收拢;现写法显式表达哨兵语义,审后接受不改。

结构化八问

  1. 是什么问题:fork 一个 plugin-lane 会话时,子会话的起始历史按「父活行数-1」截断;而 seq 是 append-only,父会话只要 fold 过一次(必然 retire 行),这个截点就落在最新活行之前的某个空洞里,子会话静默丢掉尾部消息——每个 retired 行丢一条。snapshotRender 开启时损失在线显形:子会话从 MAX+1 追加的新行 ledgerSeq 可能落进克隆来的活跃块账本区间,被 prune 掉。
  2. 什么原因导致的:边界计算把 COUNT(活行数)当成了 MAX(最新活行 seq)——append-only seq 空间中 retire 制造空洞后二者不等,前者系统性低估尾位。
  3. 影响范围与严重程度:所有「父会话 fold 过 ≥1 次后再 fork」的 plugin-lane 会话,子会话起始历史缺尾(数据丢失类,p1);legacy 模式下表现为子会话从一个更旧的静默前缀开始,snapshotRender 下升级为在线 prune 新行。无 retire 的 fork 不受影响(边界值相同)。
  4. 怎么修复的:截点改为父会话最高活行 seq(MAX(live seq)),新增 lastLiveSeq() 贯穿全部存储层并原地替换废弃的 count 族(单一调用点,>= 0 哨兵替代 > 0);克隆逻辑、幂等守卫、触发条件一律不动。
  5. 是否有回归问题:逐项审过既有行为——触发条件等价(见上)、无-retire 与顶行-retire 两类取值逐字节相同、仅 bug 场景取更大的正确值;cloneSessionRows 内部行为未触碰;rename 全仓闭环。高危模式逐项:无语义漂移、无 fail-fast 变吞错、无阈值/时序/输出格式变化。行为变更披露(旧→新):fork 克隆边界 COUNT(live)-1 → MAX(live seq);无 retire 时恒等,有 retire 时新值修正性地包含更多行——这是本 PR 的唯一行为变化,即修复本身。
  6. 是否破坏缓存:不涉及——未触碰任何缓存/重试/增量游标/去重键失效策略。
  7. 是否改了设计方向:没有;同一机制、修正边界量的选取。
  8. 是否引入新配置:没有——无 env/config/CLI 面变化。

CI 状态与处置

原 head 8610db5 上 5 个 test 分片红(u22s3/u24s3/w22s3/w22s4/w22s5)。逐分片拉 job log 核对:失败签名全部是 #4599 在册继承簇(storage-render golden ×4、engine-proofs ×6、orphan-freeze、plugin-fork「HTTP fork revision」——该条虽在本 PR 子系统域内,但报错与在册签名逐字一致:重启后 state 缺 refLedgerAligned: true,机制同源 restamp,与本 diff 零交集)、opencode-inline、blogfeed probing。静态门禁/契约门禁全绿。已按 CI 协调政策 merge origin/ci-fixes(1fa9373)进分支,新 head 7c0b6d0,本地 typecheck 绿 + 定向 62/62 绿(含 ci-fixes 更新后的 plugin-fork 套件);全量判定以远程 CI 重跑为准(已在 #4599 留一行记录)。

判定

代码审查通过,无阻塞项;触碰 fork/session-binding 路径,按 §7.4 属 human-only 合并层——等 CI 重跑绿后请 owner 人工合并。我不自行合并。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

进度更新(接上一条审核结论):

审核结论维持不变:代码审查通过、无阻塞项,等 CI。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

CI 重跑分账(run 40230235074,head 7c0b6d0,进行中):

结论不变:代码审查通过;待剩余分片跑完出最终判定。若最终只剩这条在册 flaky,按 #4599 归口处理即可,不阻塞本 PR 的合并判定(该测试与本 diff 无关且 master 面同签名)。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

收工小结(本 issue 全部动作已完成):

  1. 独立审核通过(八问体例见上):fork 克隆边界 COUNT(live)-1 → MAX(live seq) 修在决策点上;触发条件等价、无-retire/顶行-retire 场景取值逐字节相同、仅 bug 场景取更正确的值;cloneSessionRows 本体未触碰;rename 全仓闭环零残留;测试有牙(旧逻辑下断言必挂)。行为变更已披露:仅 fork 克隆边界一处,即修复本身。
  2. CI 红已全部分账并处置:原 head 5 个红分片逐分片拉 log 核实 = CI Control Center: Centralized CI Failure Handling & Status Sync (Comment all CI issues here; do not open new issues) | CI 总控: CI 失败集中处理与状态同步(所有 CI 问题在此评论, 勿开新 issue) #4599 在册继承簇(含 fork 域的「HTTP fork revision」——报错与在册签名逐字一致,与本 diff 零交集);已 merge origin/ci-fixes(1fa9373)进分支,当前 head 7c0b6d0;本地 typecheck + 定向 62/62 绿。CI Control Center: Centralized CI Failure Handling & Status Sync (Comment all CI issues here; do not open new issues) | CI 总控: CI 失败集中处理与状态同步(所有 CI 问题在此评论, 勿开新 issue) #4599 已留一行记录。
  3. 重跑现状(run 40230235074):静态/契约门禁 12/12 绿;原继承簇全部转绿;唯一红 = 1 个在册 flaky(runLaunch opencode-inline,Windows 二进制解析簇,签名逐字一致);其余 8 个 test 分片因 CI 风暴后 runner 拥塞仍在排队,无新增失败。
  4. 判定:代码审查无阻塞项;触碰 fork/session-binding 路径,按 §7.4 属 human-only 合并层——请 owner 人工合并(若等剩余分片:预期除在册 flaky 外全绿;该 flaky 与 master 面同签名,不构成本 PR 的回归证据)。我不自行合并。

ci-check and others added 4 commits October 26, 2026 09:14
The ci-check lane's expectation change (c496cfb) exposed a real Windows
bug: stripInheritedProxy builds inlineEnv as a spread copy of process.env,
which keeps the original key casing (ComSpec) — Windows env vars are
case-insensitive but plain objects are not. planClientSpawn's exact
env.COMSPEC probe then missed it and silently degraded every wrapped spawn
to the bare-name 'cmd.exe' fallback (verified by repro on a real win32 box:
childEnv.COMSPEC=undefined while process.env.COMSPEC was set).

Fix: probe COMSPEC/ComSpec/comspec in planClientSpawn and planDshSpawn.
Verified on real Windows (Node 22): launcher-opencode-inline + fix-679 +
dsh-refresh 37/37; host tsc clean, 35 pass / 2 win32-skips.
…OMSPEC case-probe

c496cfb re-derived the win32 expectation from ambient process.env, which
still mismatches production: Node's process.env member access is
case-insensitive on Windows while the child env handed to the planner is a
plain object whose key keeps the OS casing (ComSpec), so the exact
env.COMSPEC probe fell through to the bare-name fallback. The assertion now
derives from the child's OWN captured env/options and probes
COMSPEC/ComSpec/comspec exactly like planClientSpawn does post-dfeea8a11 —
self-contained under any concurrent-test env churn in single-process CI
shards — and additionally pins windowsVerbatimArguments=true on the wrap.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

🔶 需要决策
(ai: vllm-qwen/qwen3.8-27b)

查重: 重复 —— 本 PR 修复的 #4730 已经通过 PR #4725 合入 master(commit 6aad27eac9,merge commit 931c66a2f9,2026-10-26 04:35Z)。本 PR 是同一修复的并行载体,已被 master 完全取代。

本轮核实(全部 live 验证,2026-11-13)

选项

默认(无决策时):A。 理由:修复已发布在 master,本 PR 继续挂着只会持续产生冲突噪音(本轮冲突即其一);它没有任何 master 上没有的东西。

结构化八问

  1. 是什么问题:PR [PR] fix: fork cut uses highest live row seq, not live-row COUNT (#4730) #4754 与 master 冲突(dirty)需要解冲突;解冲突时发现该 PR 修复的 Fork clones history using live-row COUNT as the cut, so any retired row makes the child silently lose its newest messages #4730 已经通过另一条路径([PR] chore: empty PR (no changes) #4725)合入 master,PR 整体被取代。
  2. 什么原因导致的:同一 issue(Fork clones history using live-row COUNT as the cut, so any retired row makes the child silently lose its newest messages #4730)在 2026-10-25/26 被两条并行修复同时开发——本 PR 与 [PR] chore: empty PR (no changes) #4725 分支;[PR] chore: empty PR (no changes) #4725 先合入(10-26 04:35Z),本 PR 按 §7.4 等人工合并期间一直挂着,之后 master 又经 The MySQL backend's fork clone/window read is not wired up: shadow only routes to SQLite, and the equivalent implementat | MySQL 后端的 fork 克隆/窗口读没接线:shadow 只路由 SQLite,mysql.ts 里的同款实现是死代码 #4911 把 fork 车道重构为异步,两边 API 形态分叉(本 PR:rename + -1 哨兵 + 同步门面;master:保留 liveRowCount + null + 异步)。
  3. 影响范围与严重程度:无用户面影响——修复已在 master 生效,线上行为以 master 为准;本 PR 只是仓库里的一个冲突空壳。严重程度:调度噪音(每轮 CI 工程师唤醒都撞同一个无解冲突),不是功能缺陷。
  4. 怎么修复的:本轮没有改任何东西——试解冲突(merge master)读完 6 处冲突两侧后确认「任何机械解法都不成立」,已 git merge --abort,工作树干净,未 push、未改 PR 正文、未开新 issue。
  5. 是否有回归问题:不涉及——未推送任何变更,master 行为零改动。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及(未做任何变更;选项 C 若被选中才会动设计方向,已标注为回归,不建议)。
  8. 是否引入新配置:不涉及。

判定:等 owner 拍板(推荐 A:按 duplicate 关闭,指向 #4725 / 6aad27eac9)。标签:pr + needs-decision + duplicate(本 PR 是已合入修复的重复载体,等待人工决策关闭)。

@ranxianglei ranxianglei added duplicate This issue or pull request already exists needs-decision labels Nov 13, 2026
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

状态复核(本轮 live 验证,无新动作):决策仍在等待 owner,状态与上一条「🔶 需要决策」(本线程 2026-11-13 00:46Z)完全一致。

结构化八问

  1. 是什么问题:同前——PR [PR] fix: fork cut uses highest live row seq, not live-row COUNT (#4730) #4754 与 master 冲突,且其修复的 Fork clones history using live-row COUNT as the cut, so any retired row makes the child silently lose its newest messages #4730 已经通过 [PR] chore: empty PR (no changes) #4725(6aad27eac9)在 master 上,PR 整体被取代。
  2. 什么原因导致的:同前——同一 issue 两条并行修复,[PR] chore: empty PR (no changes) #4725 先合入,本 PR 挂着等人工合并期间 master 又经 The MySQL backend's fork clone/window read is not wired up: shadow only routes to SQLite, and the equivalent implementat | MySQL 后端的 fork 克隆/窗口读没接线:shadow 只路由 SQLite,mysql.ts 里的同款实现是死代码 #4911 重构为异步车道,API 形态分叉。
  3. 影响范围与严重程度:无用户面影响(修复已在 master 生效);严重程度仅为本 PR 持续产生冲突噪音。
  4. 怎么修复的:本轮无修复动作——live 复核确认状态未变、决策未出,继续停在决策点。
  5. 是否有回归问题:不涉及——未推送任何变更。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及。
  8. 是否引入新配置:不涉及。

判定:维持上一条决策请求——推荐 A(按 duplicate 关闭,指向 #4725 / 6aad27eac9),无决策时默认 A。等 owner 拍板;拍板前本 PR 不再触碰。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

进度汇报(本轮 live 验证)——这是「等 owner 决策」的停驻态,不是卡死。

为什么我不能自己解掉这个 dirty:两条解法都不是机械动作——① 全取 master 侧 → PR 变空壳 + 一个必红重复测试;② 保留本 PR API 形态 → 回退 #4911 异步设计,构成回归。二者都需要 owner 拍板(见 floor 12 选项 A/B/C)。按 lane 规则(需要决策 → 停),我停在决策点,未 push、未改正文、未动分支。

请 owner 处置(解除阻塞的唯一动作):推荐 A —— 按 duplicate 关闭本 PR(指向 #4725 / 6aad27eac9)。关闭权在 owner(agent 无关闭权)。拍板前我继续停驻,不再重复贴分析。

结构化八问

  1. 是什么问题:PR 与 master 冲突(dirty);其修复的 Fork clones history using live-row COUNT as the cut, so any retired row makes the child silently lose its newest messages #4730 已在 master(经 [PR] chore: empty PR (no changes) #4725),PR 被整体取代。
  2. 什么原因导致的:同一 issue 两条并行修复,[PR] chore: empty PR (no changes) #4725 先合入;本 PR 等人工合并期间 master 又经 The MySQL backend's fork clone/window read is not wired up: shadow only routes to SQLite, and the equivalent implementat | MySQL 后端的 fork 克隆/窗口读没接线:shadow 只路由 SQLite,mysql.ts 里的同款实现是死代码 #4911 重构为异步车道,API 形态分叉。
  3. 影响范围与严重程度:无用户面影响(修复已在 master 生效);仅本 PR 持续产生冲突噪音。
  4. 怎么修复的:本轮无代码动作——live 复核确认 CI 绿、dirty 未解、决策未出,继续停在决策点。
  5. 是否有回归问题:不涉及——未推送任何变更。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及。
  8. 是否引入新配置:不涉及。

判定:CI 绿,唯一阻塞是 dirty,需 owner 拍板(推荐 A 关闭)。等 owner 处置;拍板前本 PR 不再触碰。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[ework] CI fix verified green ✓

@ranxianglei

Copy link
Copy Markdown
Owner Author

Closing: the fix landed on master as 6aad27e "fix: fork row clone uses last live seq, not row count (#4730)"; master src/persist.ts:2249-2259 exposes the highest-live-seq reader this PR adds (lastLiveSeqAsync).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists needs-decision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fork clones history using live-row COUNT as the cut, so any retired row makes the child silently lose its newest messages

1 participant