Repository navigation
[PR] [ci-unblock] Revert \"one-time ledger restamp …\" (#4575): restore the green master test matrix - #4668
Closed
ranxianglei wants to merge 1 commit into
Closed
[PR] [ci-unblock] Revert \"one-time ledger restamp …\" (#4575): restore the green master test matrix#4668ranxianglei wants to merge 1 commit into
ranxianglei wants to merge 1 commit into
Conversation
Contributor
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.5710-pr.4668.b90a366This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4668.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
|
Closing per owner decision (2026-10-25): #4316 layer-3 ledger restamp is a committed new feature and will NOT be rolled back — the regression will be fixed properly instead. All triage evidence (bisect chain, local reproduction matrix, mechanism analysis) is preserved above for whoever lands the fix. |
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: single-commit
git revert 380ef4da("feat: one-time ledger restamp of legacy counter refs + fork row cloning (#4316 layer 3 PR3/3)", landed via #4575 / merge 8ad3aed on Oct 24) applied to master tip 28b667b. No other changes.Why now: that commit is a deterministic regression that has left the entire master test matrix red on every open PR (8/16 shards: ubuntu 22,2·22,3·24,2·24,3 + windows 22,3·22,4·24,3·24,4), blocking merges behind master protection (incl. the #4660 release-model PR, which had to ship on owner bypass of the pre-existing reds).
Evidence (full triage available on request; worktree kept at /tmp/bc-ci-red-triage):
state.messageRefs.byRef.m00003 === "raw-new"getsundefinedafter cold-load recovery), plugin-fork (post-real-process-restart hydration losesrefLedgerAligned: true), storage-engine-proofs (full-vs-legacy-restart wire digest drift, 6 subtests). Runner classifies them "concrete" → no auto-retry mask.SessionStore.loadSync→maybeRestampToLedger, persist.ts), permanently renumberingmessageRefsonto store-row seqs and persistingCompressionState.refLedgerAligned— breaking the pinned invariant "full mode is invisible on the wire / restart == legacy". The later CI Control Center: Centralized CI Failure Handling & Status Sync (Comment all CI issues here; do not open new issues) | CI 总控: CI 失败集中处理与状态同步(所有 CI 问题在此评论, 勿开新 issue) #4599-sentinel golden regen (12e7753) moved only the metadata-section digest and did not cover the restart-comparison legs → still red at tip.Conflict resolutions (3 files, principle: drop exactly the #4316 PR3/3 contribution, preserve every post-#4575 change):
src/storage/store.ts: removed the one contiguous block added by 380ef4d (seqByRaw/liveRowCount/cloneSessionRows+ privateputContentRef; D5-5 windowing members below it untouched, verified zero remaining references repo-wide).CHANGELOG.md: removed only the "After model switch / client-side history rewrite, all message identities (content hashes) are replaced: ACP numbers re-m | 切模型/客户端重写历史后,消息身份(内容哈希)全部更换:acp 编号重铸、折叠覆盖大规模重挂、死 ref、churn 区临时膨胀重折 #4316 层 3 PR3/3" section.tests/seq-ledger-pr3.test.ts: deleted (its only post-commit touch was 12a2108's Windows teardown-handle fix, moot once the feature goes).Verification on the revert commit (this PR head): the three formerly-red suites now 72/72 pass (0 fail) under the exact CI invocation (
--importpreloads + tsx + TAP, ACP_TEST_CLAUDE_NATIVE=1);scripts/check-unused-exports.mjsclean; typecheck clean. Full matrix runs here as required checks.Trade-off, stated plainly: #4316 layer-3 (ledger restamp + fork row cloning) leaves master until it comes back properly fixed through the #4316/#4599 thread. It never shipped in any released version (verified absent from tags v0.1.206 and v0.1.207). If the intended path is to fix rather than roll back, close this PR and land that fix instead — until one of the two lands, the master PR queue stays merge-blocked.