Repository navigation
[PR] fix(hermes): prevent healthy proxy misdetection from disabling bili - #4657
Closed
yanhuojiyusheng wants to merge 1 commit into
Closed
yanhuojiyusheng wants to merge 1 commit into
yanhuojiyusheng wants to merge 1 commit into
Conversation
yanhuojiyusheng
force-pushed
the
2026-10-25_hermes-registry-ready
branch
from
October 25, 2026 15:01
eb5af8a to
e31e51d
Compare
yanhuojiyusheng
force-pushed
the
2026-10-25_hermes-registry-ready
branch
from
October 26, 2026 01:33
e31e51d to
16f4cf1
Compare
Contributor
Author
|
诊断成立(#4656 的机制已按代码复核:
三个新用例通过的原因是 可靠的身份凭证是刚 spawn 的子进程 pid(并发写入方伪造不了),#4658 已按此实现并全绿。本 PR 关闭;机制与现场证据已转入 #4656 / #4658。 |
ranxianglei
pushed a commit
to yanhuojiyusheng/billion-context
that referenced
this pull request
Oct 26, 2026
…ompression-channel comments (ranxianglei#4855) All six comments added by this PR cite ranxianglei#4657, which is an unrelated closed PR (hermes proxy-misdetection fix, Fixes ranxianglei#4656). The anchor must point at the issue being fixed, ranxianglei#4855. Comment text otherwise untouched.
yanhuojiyusheng
pushed a commit
to yanhuojiyusheng/billion-context
that referenced
this pull request
Oct 27, 2026
…ompression-channel comments (ranxianglei#4855) All six comments added by this PR cite ranxianglei#4657, which is an unrelated closed PR (hermes proxy-misdetection fix, Fixes ranxianglei#4656). The anchor must point at the issue being fixed, ranxianglei#4855. Comment text otherwise untouched.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4656
Hermes can completely lose bili compression for the lifetime of its host process even after its proxy has successfully started. When concurrent proxies overwrite the shared
proxy-origin,ensure_originsees a foreign launch token and never checks its own per-instance record. It eventually reports startup failure, terminates its healthy child, and leaves model traffic going direct/uncompressed. Long conversations can then exceed the upstream context window.Scan the existing per-instance registry alongside the shared pointer during spawn polling. Accept only the current launch token with a live PID and successful health probe, and retain the instance ID. No extra proxy, timeout increase, storage change, or configuration surface is introduced. This addresses the Python counterpart of #3326 / #3327 and is independent of #4642's host-load-deadline repair and #4644's recovery work.
Evidence: local 0.1.206 logs show proxies listening at 15:33:48 CST while the plugin still timed out at 15:34:50. The exact pointer overwrite was not captured live; the deterministic fixture reproduces it. With the fix installed on top of #4642, the reporter confirmed startup recovered. Database size is not asserted as the cause.
Validation on this independent branch based on master 8b24d1f:
npm run typecheck,npm run build, and diff whitespace checks passed.missing hermes CLIbecause the installed hermes executable remains discoverable through PATH; no unrelated fix is bundled.Only two files change. Remote CI remains to run; no claim of full-suite green.