Repository navigation
[PR] test: plugin-fork assertions branch by storage mode (runners without sqlite engine are no longer born-red) | test: plugin-fork 断言按存储模式分支(无 sqlite 引擎的 runner 不再 born-red) - #4652
Conversation
… sentinel follow-up) The unconditional 'refLedgerAligned = true' expectation assumed a unified-mode cold load. On runners without the node:sqlite engine the store resolves to legacy-only (liveStorageStamp), the one-time ledger restamp never runs, and the flag is absent from the loaded state — born-red on every windows leg since #4316 PR3/3 landed (master run 40167778049, w22s3/w22s4 legs). Key the expectation on SessionStore.liveStorageStamp (#3135/#3818 honest per-instance mode stamp): flag expected only when full mode actually holds the data. Verified both directions locally: default env (full -> flag expected, pass) and BILI_STORAGE_UNIFIED=legacy (legacy stamp -> flag not expected, pass).
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.9435-pr.4652.bb5bafaThis exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4652.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复——本 PR 即 #4635 合入后遗留裁决项 A/B 中「不动生产语义的最小修」的实现,#4599(CI 总控)清单项;未发现同签名在途 issue/PR。 标签: bug / scope/ci / p2(windows CI leg 确定性 born-red,纯测试期望问题,需绕行哨兵车道,无用户影响) 状态核对(分支已拉取、代码已核对、CI 已确认):
结构化八问:
结论:代码与描述一致、门禁等价性验证通过、本地双向钉住绿;待 CI windows leg 转绿即可合并。 |
(ai: vllm-qwen/qwen3.8-27b) CI 终局状态:head 诚实披露(调度失误):我前面打的三个标签(bug/scope/ci/p2)每次 labeled 事件都触发了一次 pull_request 重跑,并发把前两轮整轮取消——白烧了两轮舰队资源。时间线吻合(标签 06:47:16Z → 重跑 06:47:18Z),照实报告。 第一轮红的解释(run 40169909721,6 个 shard 红,与本 diff 无关):
八问(终版):
判定:head |
…ork-mode-aware-expectation # Conflicts: # tests/plugin-fork.test.ts
[bot] 冲突已解决,但 PR 已被 master 完全取代——建议关闭。 发生了什么: PR 分支 冲突分析:
master 还做了其他演进:
结论: merge 后 PR 分支与 master 内容完全一致( 建议: 关闭此 PR(superseded by #5608-D),无需合并——合并是 no-op。 |
[ework] CI fix verified green ✓ |
|
Closing: the branch is fully in sync with master — the three-dot diff against origin/master is empty; the plugin-fork mode-aware test assertions it carries are already on master. |
是什么
tests/plugin-fork.test.ts的「HTTP fork revision and originals survive a new proxy process」无条件期望冷加载后的 state 带refLedgerAligned: true(#4316 PR3/3 的一次性 ledger 对齐)。该对齐只在 unified(full)模式冷加载时执行;没有 node:sqlite 引擎的 runner(当前全部 windows-latest)上 store 解析为 legacy-only,restamp 不跑、标志缺失 → 该测试自 #4316 PR3/3 落地起在每个 windows leg born-red(master 52567f1 的 push run 40167778049 中 w22s3/w22s4 两条 leg 可见,diff 恰为- refLedgerAligned: true)。修法
期望值改为按
SessionStore.liveStorageStamp(#3135/#3818 的「当前实际持数模式」诚实戳)分支:仅当 full 模式实际持数时才期望该标志。只动测试期望构造,不碰 persist.ts 语义、不碰生产代码。验证(双向钉住)
BILI_STORAGE_UNIFIED=legacy(legacy 戳 → 不期望标志):同一单测通过。行为变更披露
仅测试面:无引擎 runner 上该测试从 born-red 变为通过;full 模式下的断言强度不变(仍要求标志存在)。生产行为零变化。
关联:#4599(CI 总控清单项,常驻 issue 不关闭);#4635 合入后的随车遗留——哨兵车道当时将其列为裁决项 A/B,本 PR 实现的是其中不动生产语义的最小修(测试侧按模式分支);若后续要根治 full 模式下 flushSync 不落 sidecar 的生产缺口,另行立项。