Repository navigation
[PR] fix: report fold-substrate vacuum instead of staying silent (#2438 F1-a) - #4617
ranxianglei wants to merge 9 commits into
Conversation
A session whose stored folds expose no anchorable covered surface (the host resent history matching none of the folded originals — mass representation drift, #2431/#2847 family) hit the covered-empty early exit of reconcileFoldCoverage, which reset drift state and returned silently. The terminal state therefore showed healthy book values and ZERO log lines: the v0.1.195 retest in #2438 (floor 18) produced no drifted/destroyed/ tolerated line at all, leaving operators blind while the wire stayed fully unfolded/doomed. Now, when stored blocks exist but none exposes an anchorable covered id: - one ERROR line per session lifetime (persisted free-form metadata latch, deliberately outside resetFoldDriftState so it cannot re-fire on every request of the episode); - one 'fold-vacuum' entry in the per-session conflict ledger (recordConflict already marks dirty, so the latch rides the existing save); - a dedicated pure-case tier in formatConflictSection so a vacuum-only ledger is framed as bili's own terminal diagnostic (no second compressor, recovery = host resends matching bytes or fresh conversation) instead of falling into the [suspected]-plugin advice or the generic remediation footer. Mixed ledgers keep their existing tiers verbatim (.every() gating, same pattern as the #2802/#2912 pure-case tiers). Report-only by design: zero behaviour change beyond the report — no wire, config, persistence-format, or fold-state change. The behavioural response layer (bound/regime/retire facets) stays pending #3978 coordination.
aefc669 to
8f5c071
Compare
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.6172-pr.4617.994d519This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4617.tgz
npm install -g packageInstall instructions are refreshed on each push. |
…orts gate) ClientBuildCheck in src/agent/client-build-note.ts was declared declare -x AGENT="1" declare -x BOT_TOKEN="5d1c86c9b157193cec730e4402d5f24b4f0527f7" declare -x BOT_USERNAME="ework-daemon" declare -x CI="true" declare -x DAEMON_DB_PATH="/var/lib/ework-daemon/share/ework-daemon/ework-daemon.db" declare -x DAEMON_ENDPOINT="127.0.0.1:3101" declare -x DAEMON_ENV="production" declare -x DAEMON_HOST="0.0.0.0" declare -x DAEMON_PORT="3101" declare -x DEBIAN_FRONTEND="noninteractive" declare -x EDITOR=":" declare -x EWORK_ISSUE="4617" declare -x EWORK_OWNER="ranxianglei" declare -x EWORK_REPO="billion-context" declare -x EWORK_SENDER="ework-daemon" declare -x EWORK_SESSION="ci-worker-r1" declare -x EWORK_WORKDIR="/var/lib/ework-daemon/share/opencode-workdir/ranxianglei--billion-context/4617/ci-worker-r1" declare -x GCM_INTERACTIVE="never" declare -x GITEA_TOKEN="5d1c86c9b157193cec730e4402d5f24b4f0527f7" declare -x GITEA_URL="http://127.0.0.1:3002" declare -x GITEA_WEBHOOK_SECRET="7c53562bdd4ab172bed0c886c101e8e0701fff74" declare -x GIT_EDITOR=":" declare -x GIT_MERGE_AUTOEDIT="no" declare -x GIT_PAGER="cat" declare -x GIT_SEQUENCE_EDITOR=":" declare -x GIT_TERMINAL_PROMPT="0" declare -x HOME="/var/lib/ework-daemon" declare -x HOMEBREW_NO_AUTO_UPDATE="1" declare -x INVOCATION_ID="0f0b7b69e4e24442a34e1cf7b3d9af89" declare -x JOURNAL_STREAM="8:3188990" declare -x LANG="C.UTF-8" declare -x LOGNAME="ework-daemon" declare -x MEMORY_PRESSURE_WATCH="/sys/fs/cgroup/system.slice/ework-daemon.service/memory.pressure" declare -x MEMORY_PRESSURE_WRITE="c29tZSAyMDAwMDAgMjAwMDAwMAA=" declare -x NPM_CONFIG_PREFIX="/var/lib/ework-daemon/share/opencode-workdir/ranxianglei--billion-context/4617/ci-worker-r1/.npm-global" declare -x OLDPWD declare -x OPENCODE="1" declare -x OPENCODE_BASE_WORKDIR="/var/lib/ework-daemon/share/opencode-workdir" declare -x OPENCODE_BINARY="/usr/local/bin/opencode" declare -x OPENCODE_PID="521762" declare -x OPENCODE_PROCESS_ROLE="main" declare -x OPENCODE_RUN_ID="285af316-ccc4-4efa-bb88-9f5509836493" declare -x PAGER="cat" declare -x PATH="/var/lib/ework-daemon/share/opencode-workdir/ranxianglei--billion-context/4617/ci-worker-r1/.npm-global/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/snap/bin" declare -x PIP_NO_INPUT="1" declare -x PWD="/var/lib/ework-daemon/share/opencode-workdir/ranxianglei--billion-context/4617/ci-worker-r1" declare -x SHLVL="1" declare -x SYSTEMD_EXEC_PID="3687321" declare -x TMPDIR="/var/lib/ework-daemon/share/opencode-workdir/ranxianglei--billion-context/4617/ci-worker-r1/.tmp" declare -x USER="ework-daemon" declare -x VISUAL="" declare -x WORK_CI_MAX_CONCURRENT="2" declare -x WORK_CONFLICT_MAX_CONCURRENT="2" declare -x WORK_DEFAULT_MODEL="vllm-qwen/qwen3.8-27b" declare -x WORK_INFRA_NIGHT_BOOST="0" declare -x WORK_MAX_CONCURRENT="12" declare -x WORK_MODEL_POOL="vllm-qwen/qwen3.8-27b" declare -x WORK_NODE_MODULES_TTL_DAYS="1" declare -x WORK_PI_BINARY="" declare -x WORK_PI_DEFAULT_MODEL="" declare -x WORK_PI_PROVIDER="" declare -x WORK_PROJECT_PRIORITIES="ranxianglei/ework=200,ranxianglei/billion-context=100,ranxianglei/opencode-acp=10,ranxianglei/opencode-stable=10,ranxianglei/opencode-ework=10" declare -x WORK_RUNTIME="opencode" declare -x WORK_WAKE_LOGINS="dog,ranxianglei,darkness-A" declare -x YARN_ENABLE_IMMUTABLE_INSTALLS="false" declare -x npm_config_tmp="/var/lib/ework-daemon/share/opencode-workdir/ranxianglei--billion-context/4617/ci-worker-r1/.tmp" declare -x npm_config_yes="true" but is referenced only within its own module (type annotations on maxTestedVersion / DSH_BUILD_CHECK / newerClientBuildMessage / emitNewerClientBuildNote); no other file imports it. The unused-exports gate flagged it as INTERNAL_ONLY on the PR merge ref. Drop the leading export so it becomes a module-local type — matches the repo's standing pattern for this gate class (cf. 4d34abf 'de-export 3 internal-only symbols'). Type-only, zero cross-module references, no behavior change.
(ai: vllm-qwen/qwen3.8-27b) CI 自动修复: 失败 job: 修复: 结构化回答(八问):
判定:几行级小修已就地完成并 push, |
(ai: vllm-qwen/qwen3.8-27b) 冲突车道判定:核验后当前不存在冲突,未做任何改动(无 rebase、无 push)。 系统转发了「上游 PR 冲突(dirty)」通知,核验结果如下:
当前真实阻塞(非冲突):head 结构化回答(八问):
判定:冲突态已清(核实结论),本车道零动作收工;剩余红为继承性 CI 红,跟踪在 #4599,等 #4606 合并后重触发即可。 |
(ai: vllm-qwen/qwen3.8-27b) 冲突处理完成:无需 rebase——分支已完全跟上 master,冲突态已清;CI 剩余红为继承性,等 #4606。 查重:不重复——本 PR 即 #2438 F1-a(可观测面)的修复载体,行为响应层在 #3978 协调中,无并列 issue/PR。 冲突核实(实测,非假设):
代码核对(按 [PR] 识别规则拉分支核对,diff 共 5 文件 +126/-2):
CI 分账(head
八问:
结论:冲突态已清、代码核对通过、CI 红全部归因继承(=#4599 盘点第 2 条),本 PR 侧零待办;#4606 合入后重触发即得完整矩阵,届时可由 owner 推进合并。 |
(ai: vllm-qwen/qwen3.8-27b) CI 自动修复 attempt 2/2 → 判定:继承性 master-red,不在本分支修,停止。 失败的是 11 个 即: 结构化回答(八问):
判定:停止自动修复(attempt 2/2)。这不是本分支能独立小修的——是协调中的继承性 master-red(#4606)。已在本帖留判定,并在 #4599 记一行。下一步:等 #4606 合入后,把本 PR rebase 到 master 即转绿,无需改本分支代码(届时我可一并丢弃 attempt-1 加的 ClientBuildCheck 去 export commit——#4606 已在 master 侧修了同一处,避免重复)。 |
master window commits 293ae65/de5e03659 bumped kernel/package.json to 0.0.165 without regenerating the lockfiles; lock-sync re-resolution then rewrites the stale recorded versions (root 0.0.163, kernel 0.0.164) and fails. Pure recorded-version sync via npm install --package-lock-only; no dependency or semantic change.
Part of #2438
What & why
A session whose stored folds expose no anchorable covered surface — the host resent history matching none of the folded originals (mass representation drift, #2431/#2847 family) — hit the covered-empty early exit of
reconcileFoldCoverage, which reset drift state and returned silently. The terminal state therefore showed healthy book values and zero log lines: the v0.1.195 retest in #2438 (floor 18) produced no drifted/destroyed/tolerated line at all, while the wire stayed fully unfolded/doomed. Operators were blind to the exact state they most need to see.This PR makes that state visible. When stored blocks exist but none exposes an anchorable covered id:
[fold-reconcile] fold substrate vacuum: N stored block(s) expose no anchorable covered surface — coverage cannot re-establish until the host resends matching bytes; summaries retained (#2438 F1-a)), with a persisted free-form metadata latch (foldVacuumNoted) deliberately kept OUTSIDEresetFoldDriftStateso it cannot re-fire on every request of the episode;fold-vacuumentry in the per-session conflict ledger (recordConflictalready marks dirty, so the latch rides the existing save — no new persistence path);formatConflictSectionso a vacuum-only ledger reads as bili's own terminal diagnostic ("NO second compressor involved … recovery = host resends matching bytes or fresh conversation") instead of falling into the[suspected]-plugin advice or the generic remediation footer. Mixed ledgers keep their existing tiers verbatim (.every()gating, same pattern as the feat: surface identity-loss takeovers with an identity-orphan conflict event (#2791) #2802/网页警告问题 #2912 pure-case tiers).Behaviour-change disclosure (additive observability only)
fold-vacuum+ new banner advice tier for pure vacuum ledgers. All pre-existing ledger shapes tier exactly as before (verified: every consumer ofConflictKinduses positive filters, no exhaustive switches).Tests
tests/fold-reconcile.test.ts: 4 new cases — M2 shape (active block, emptied id list) reports once then stays quiet incl. dedup-latch assertion; M1 shape (deactivated block, intact ids) reports; fresh session stays silent; healthy coverage neither reports nor sets the latch.tests/conflict-lifecycle.test.ts: 3 new cases — active vacuum-only tier wording + footer suppression; mixed native-compaction+vacuum ledger does NOT take the vacuum tier (pure-case gate); historical vacuum-only reads as stock.tests/fold-reconcile.test.ts tests/conflict-lifecycle.test.ts tests/conflict-remediation.test.ts tests/web-conflict-banner.test.ts→ 119/119 pass. Typecheck clean, build clean. Full-suite verdict = remote CI on this head.