Repository navigation
[PR] fix(tests): update dsh settings panel test expectations to #3719 five-tab layout + mount clock fallback cleanup, fix CI | fix(tests): dsh settings panel 测试期望更新到 #3719 五标签面 + mount 时钟兜底清理,修 CI 卡死 - #4436
Merged
Conversation
…can't hang the file (#4433) The #3719 follow-up added a Versions tab to the embedded settings panel but left dsh-settings-ui's tab expectations stale (5 buttons -> 6). The two bundle-mount tests then failed AFTER mounting, before their runCleanups() calls — the mounted client's origin-probe slow phase kept holding host timers through the sandbox clock, so the test file process never exited and every CI leg whose shard carries it hung to the job timeout (4 legs stuck 48-64min+ on the #4412 full-CI probe). Two changes: - update the tab surface expectations (five tabs incl. 版本, backup button index 5, row button count 6) - wrap the sandbox clock in mountClient: every host timer scheduled by the vm realm is tracked and released on cleanup; a file-level after() drains abandoned mounts after every test, so a mid-flight failure can no longer strand the poll chain (verified with a negative control: a deliberately stale expectation fails AND the file exits in 1s instead of hanging)
Contributor
📦 Built Package ArtifactBranch: Latest build — install this exact versionnpm install -g billion-context@0.0.5313-pr.4436.7f2fc9e-a2This exact version is immutable and reproducible. The rolling Recent builds (commit → version)
Download artifact
tar xzf billion-context-pr4436.tgz
npm install -g packageInstall instructions are refreshed on each push. |
ranxianglei
pushed a commit
that referenced
this pull request
Oct 23, 2026
… measured ~1s post-fix (#4437)
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4435
问题一句话:#3719 给 dsh 嵌入面板加了「版本」标签页但没更新测试期望,两个 bundle-mount 测试改为 mount 后失败,失败路径漏掉唯一清理点,测试文件进程永不退出,含它的 CI 分片全部挂到超时(master 全量 CI 4 腿卡死 48–64min+)。
两层修复:
after()在每个测试后 drain 被遗弃的 mount(测试失败没走到自己的 runCleanups 时兜底)。今后任何在 mount 之后失败的断言都不会再挂死文件。验证:
npm run typecheck干净。非目标:esbuild service 子进程生命周期不动(时钟链释放后它随进程正常退出,最小复现证明)。分片均衡(权重表/5 分片)是被关的 #4361 的话题,与本修复正交。
kernel/ 未触碰;纯 tests/ 修复。
(ai: zai/glm-5.3)