Skip to content

[PR] fix(tests): update dsh settings panel test expectations to #3719 five-tab layout + mount clock fallback cleanup, fix CI | fix(tests): dsh settings panel 测试期望更新到 #3719 五标签面 + mount 时钟兜底清理,修 CI 卡死 - #4436

Merged
ranxianglei merged 1 commit into
masterfrom
2026-10-24_dsh-settings-ui-hang
Oct 23, 2026

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Fixes #4435

问题一句话:#3719 给 dsh 嵌入面板加了「版本」标签页但没更新测试期望,两个 bundle-mount 测试改为 mount 后失败,失败路径漏掉唯一清理点,测试文件进程永不退出,含它的 CI 分片全部挂到超时(master 全量 CI 4 腿卡死 48–64min+)。

两层修复:

  1. 期望更新(触发层):按钮数 5→6(五标签+备份按钮)、标签列表加「版本」、备份按钮索引 4→5、tab 行按钮数 5→6,共 7 处断言。
  2. 兜底清理(机制层,防复发):mountClient 包裹注入 vm 沙箱的 setTimeout/clearTimeout——vm 域通过沙箱时钟排的每个宿主 timer 都被追踪,runCleanups 时全部释放;另加文件级 after() 在每个测试后 drain 被遗弃的 mount(测试失败没走到自己的 runCleanups 时兜底)。今后任何在 mount 之后失败的断言都不会再挂死文件。

验证:

非目标:esbuild service 子进程生命周期不动(时钟链释放后它随进程正常退出,最小复现证明)。分片均衡(权重表/5 分片)是被关的 #4361 的话题,与本修复正交。

kernel/ 未触碰;纯 tests/ 修复。

(ai: zai/glm-5.3)

…can't hang the file (#4433)

The #3719 follow-up added a Versions tab to the embedded settings panel but
left dsh-settings-ui's tab expectations stale (5 buttons -> 6). The two
bundle-mount tests then failed AFTER mounting, before their runCleanups()
calls — the mounted client's origin-probe slow phase kept holding host
timers through the sandbox clock, so the test file process never exited and
every CI leg whose shard carries it hung to the job timeout (4 legs stuck
48-64min+ on the #4412 full-CI probe).

Two changes:
- update the tab surface expectations (five tabs incl. 版本, backup button
  index 5, row button count 6)
- wrap the sandbox clock in mountClient: every host timer scheduled by the
  vm realm is tracked and released on cleanup; a file-level after() drains
  abandoned mounts after every test, so a mid-flight failure can no longer
  strand the poll chain (verified with a negative control: a deliberately
  stale expectation fails AND the file exits in 1s instead of hanging)
@ranxianglei ranxianglei changed the title fix(tests): dsh settings panel 测试期望更新到 #3719 五标签面 + mount 时钟兜底清理,修 CI 卡死 [PR] fix(tests): update dsh settings panel test expectations to #3719 five-tab layout + mount clock fallback cleanup, fix CI | fix(tests): dsh settings panel 测试期望更新到 #3719 五标签面 + mount 时钟兜底清理,修 CI 卡死 Oct 23, 2026
@ranxianglei
ranxianglei merged commit 320516f into master Oct 23, 2026
0 of 22 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-24_dsh-settings-ui-hang (7158489)

Latest build — install this exact version

npm install -g billion-context@0.0.5313-pr.4436.7f2fc9e-a2

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
7158489 billion-context@0.0.5313-pr.4436.7f2fc9e-a2 build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr4436.tgz
npm install -g package

Install instructions are refreshed on each push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant