Skip to content

[PR] ci: fix two minor red gates on master (unused-exports + lock-sync) | ci: 修掉 master 上的两个小红门(unused-exports + lock-sync) - #4419

Merged
ranxianglei merged 2 commits into
masterfrom
2026-10-23_master-unred
Oct 24, 2026
Merged

ranxianglei merged 2 commits into
masterfrom
2026-10-23_master-unred

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

什么问题

12:32 的 master CI run 39954118977 有两个静态门红了,测试腿本身全绿:

  1. unused-exports:[PR] fix(ci): run corrupt index.db degrade checks in a child process so windows cleanup can't hit EBUSY (#4338) #4378 引入的 tests/corrupt-index-child.ts 里 4 个导出(ENGPROOF_CHECK_NAMES、BANNER_CHECK_NAMES、CorruptIndexCheck、CorruptIndexVerdict)只在本文件内部使用,门要求删掉 export 关键字。父测试实际引用的是 ENGPROOF_CHECKS / spawnCorruptIndexChild,不受影响。
  2. lock-sync:今天 kernel 发版到 0.0.160 后,根目录 package-lock.json 里嵌入的 workspace 版本还停在 0.0.159,门要求对齐(与 e733727 同型的一条同步提交)。

怎么修

  • 去掉那 4 个 export(文件内使用照旧),本地 node scripts/check-unused-exports.mjs → ✓ unused-export gate: clean (6 waived)
  • npm install --package-lock-only 重新生成 lock → 只改 1 行(0.0.159 → 0.0.160)
  • 本地复跑 tests/storage-engine-proofs.test.ts 全过

影响面

纯红门修复,不改任何运行时行为;不依赖别的 PR。

…child.ts + sync root package-lock to acp-kernel 0.0.160

- unused-exports 门:corrupt-index-child.ts 里 4 个导出只在本文件内部使用,去掉 export 关键字即可(#4378 遗漏)
- lock-sync 门:kernel 发版到 0.0.160 后根目录 package-lock.json 还停在 0.0.159,重新生成对齐(与 e733727 同型)
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-23_master-unred (f7e43c8)

Latest build — install this exact version

npm install -g billion-context@0.0.5377-pr.4419.f068b08

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Recent builds (commit → version)

commit version build
f7e43c8 billion-context@0.0.5377-pr.4419.f068b08 build
ef07c25 billion-context@0.0.5277-pr.4419.a7a8bd0 build

Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr4419.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei ranxianglei changed the title ci: 修掉 master 上的两个小红门(unused-exports + lock-sync) [PR] ci: fix two minor red gates on master (unused-exports + lock-sync) | ci: 修掉 master 上的两个小红门(unused-exports + lock-sync) Oct 23, 2026
ranxianglei pushed a commit that referenced this pull request Oct 23, 2026
…e passes

#4434 (split-brain surface, merged at master tip) left three type exports with no cross-module consumers, red on pristine master. Drop the leading 'export' per the checker's INTERNAL_ONLY prescription — the types stay module-local. Complements in-flight #4419 (which covers the corrupt-index-child exports + lock-sync); different files, no overlap.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

来源:审 #4389(give-up 客户端事件带原因)时发现。

unused-exports 门在 master tip 上仍是红的,且失败签名已变——本 PR 的 diff 覆盖不到新出现的那部分:

接手本 PR 时建议:rebase 到当前 master 再合——corrupt-index-child 那组 hunk 依然有效;split-brain 那 3 个导出若不想与 #4389 重复处理,保持现状即可(两边改动不重叠,先后合入都不冲突)。若你更希望把全部门修复收拢到一个 PR,也可以把 b23c007 挪过来、在 #4389 撤掉,二选一都行。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

补一条(接上一条):master 红其实是第三个门——scripts/run-ci-tests.mjs 的 SPAWN_RE 三保险:#4434 新增的 tests/issue-split-brain-surface.test.ts(会 spawn 进程)没登记进 scripts/live-files.mjs LIVE_FILES,导致所有 test shard 在 preflight 直接挂(纯净 master 可复现)。已按 #1248 并发审查后在 #4389 追加登记(commit 87e5129,append-only 槽位约定)。接手本 PR rebase 时注意:若 #4389 先合,你这边只剩 corrupt-index-child 导出 + lock-sync 两组;顺序反过来也不冲突。

@ranxianglei
ranxianglei merged commit bc41fe4 into master Oct 24, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.786-master.bc41fe4 (rolling master tag).

npm install -g billion-context@0.0.786-master.bc41fe4  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant