Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 检索了 open+closed issue/PR(fleet、CRLF、transcript frame、truncateToWidth、background notch 等关键词组合),无同类在途或已合并条目;本 PR 与 #4385 是同一缺陷的「报告→修复」配对,#4385 保持 open 待本 PR 合入后关闭。 标签: 初审状态(完整八问结论随后补):
|
(ai: vllm-qwen/qwen3.8-27b) 审核结论(结构化八问)1. 是什么问题:Pi 2. 什么原因导致的:① 3. 影响范围与严重程度:仅 Pi Fleet 检视器展示面(TUI overlay),Windows/CRLF 工具输出场景下帧错位、文字被覆盖;不触及压缩、持久化、执行参数、调度。能用但体验明显受损 → p2,与已打标签一致。 4. 怎么修复的:CRLF→LF 只在渲染时归一化(存储文本与 bash 执行参数不动,有不可变断言钉住);给 5. 是否有回归问题:逐项清点过既有行为——LF-only 输出字节不变;截断标记字符本来就是 ASCII 6. 是否破坏缓存:不涉及——纯显示层,不碰前缀缓存、重试、游标、去重键。 7. 是否改了设计方向:不涉及。整行彩色背景设计保留(issue 明确要求)。 8. 是否引入新配置:无新 env/config/导出/依赖( 本地验证(rebase 到当前 master
|
…ound' into 2026-10-23_fix-fleet-crlf-background
The component version bump moved pi-subagents/package.json to 0.2.3 but the root package-lock.json still recorded 0.2.2 in the file-dependency directory entry, so the lock-sync gate's regeneration rewrote that one field and failed. Regenerated with the gate's own command (npm install --package-lock-only); result verified byte-identical to the CI-expected output and idempotent under re-run, kernel lockfile step clean.
(ai: vllm-qwen/qwen3.8-27b) lock-sync 红已修(CI auto-fix lane):独立 commit 八问
判定:机制性小修(几行级),无需决策立项;CI 重跑后 lock-sync 转绿、其余门禁维持原状即可走合并(合并仍由人执行)。 |
(ai: vllm-qwen/qwen3.8-27b) ✅ 三次 Sync 完成:master 又前进了 153 个提交( |
…tor CRLF fix The #4386 batch changed pi-subagents/src/fleet-inspector.ts (CRLF tool-label normalization + background-bar painting) without bumping the component version, so the pi-subagents-guard CI job failed. Bump pi-subagents/package.json (and the matching package-lock.json file: entry) so the version discipline guard passes.
|
Landed via batch PR #6482 (merged) — closing as superseded. |
(ai: vllm-qwen/qwen3.8-27b) Verified — supersession confirmed, and I deliberately skipped the round-6 branch sync for this reason:
Per policy I won't close it myself — the close is yours. Nothing further needed from this branch; the 5 prior sync pushes (rounds 1–5) are historical no-ops now. |
Fixes #4385
Problem
The Pi
/acp-fleettranscript has two independent rendering defects:\nbut retains\rin the displayed rows. A terminal interprets the carriage return as cursor movement, which can overwrite text and shift frame borders.truncateToWidth()inserts an SGR reset ahead of its generated ellipsis; the outer full-width background wrapper cannot reliably paint the ellipsis and remaining padding.The first issue is frame geometry, not a missing ANSI reset. The second is a background notch during truncation. Full-width tool backgrounds themselves are intentional and are preserved.
Changes
truncateToWidth()and explicitly paint the remaining padding usingvisibleWidth()(including wide Unicode cases).pi-subagentscomponent version from0.2.2to0.2.3per the component version guard. The rootbillion-contextversion is unchanged.Reproduction and evidence
Minimal fixture:
Before the fix, trailing CR in displayed lines can return the cursor to column zero and corrupt the framed row. In local replay of an ACP session, original rendering emitted CR on 16 / 26 / 28 rows at widths 40 / 80 / 120, respectively; the patched renderer emitted zero.
When truncating 200 ASCII or 100 CJK characters to width 21, the original rendering left 3 default-background cells around the ellipsis, versus 0 with the patch. Output width remains 21.
The combined fix was confirmed in Windows Terminal by the reporter.
Validation (local, on patch base
aa198fe613b4ff5252ddfccdf6704290ad37d9ab)pi-subagentssuite: 266/266 passedpi-subagent-channel,pi-subagent-registry,pi-subagents-wiring): 43/43 passednpm run typecheck: passednpm run build: passedgit diff --check: passedBefore merge: rebase/apply to current
master, run full repositorynpm test, typecheck and build, and confirm remote CI. These were not independently verified on currentmasterin the attached report.Impact and boundaries
resumeFrom, config schema, persistence, or compression kernel.